From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85332C433F5 for ; Mon, 16 May 2022 06:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239432AbiEPG34 (ORCPT ); Mon, 16 May 2022 02:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232090AbiEPG3z (ORCPT ); Mon, 16 May 2022 02:29:55 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94F0F26AFE; Sun, 15 May 2022 23:29:54 -0700 (PDT) Date: Mon, 16 May 2022 08:29:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652682591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2Br0kGTz97gFRI4UoHpjTrAphLEpHX8G3A3EWdmkCo=; b=cil+zbCowMsn2/G+DxFU0NbmaeYTCghUfXe4n8ZAQNo4fW3GYLIaNYsUMp/eRH7tK6l9WH vEOt/i93dsLzwhNpl5F5TQXYXD8heNoAgrlQbJPDAAjM5DK/Uc+lKy3huZgajIMcJ3F5pv gXHqEt44ira47nMMMLsk1WVsUn8BLUo674UZBnsPZ19ZBWyixbexW14wZLpfe4wpUurCdh 2fD4wF1uds3iOPY5yhql9e4RK6OjBFkrbeuXG9CIK/ygxTC52mExQnCIQUUKJj0SzqKW9+ sJsq3QIhAXhOnuOY1hUBeTOel5rBnPBU1LlEC0TvW6P+FG448SFiTXwBt9CZag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652682591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2Br0kGTz97gFRI4UoHpjTrAphLEpHX8G3A3EWdmkCo=; b=h6Pg68+btj1eb0yWjhiNtumHNaV2y/bYZwna19lkebWnNIHB1My4fT5m4PtiVIBtfB/Byx b58Z8SaQXr+2pJCA== From: Sebastian Andrzej Siewior To: Lukas Wunner Cc: Thomas Gleixner , Marc Zyngier , Mark Rutland , Jakub Kicinski , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Octavian Purdila , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] genirq: Deduplicate WARN_ON_ONCE() in generic_handle_domain_irq() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2022-05-10 09:56:05 [+0200], Lukas Wunner wrote: > An example for irqchips where the warning is false positive are > USB-attached GPIO controllers such as drivers/gpio/gpio-dln2.c: They are not false positives because=E2=80=A6 > USB gadgets are incapable of directly signaling an interrupt because > they cannot initiate a bus transaction by themselves. All communication > on the bus is initiated by the host controller, which polls a gadget's > Interrupt Endpoint in regular intervals. If an interrupt is pending, > that information is passed up the stack in softirq context, from which > a hardirq is synthesized via generic_handle_domain_irq(). they tell you that the context is wrong. From looking at gpio-dln2 this is called from USB URB's callback which is softirq. In the end dln2_gpio_event() is invoked while dln2_dev::event_cb_lock is acquired. That lock is acquired by disabling interrupts which is what gets the locking right for generic_handle_domain_irq(). If that lock lifted to spin_lock_bh() (because it is always in urb's calback context and all HCDs complete in one context unlike now) then this breaks. And PREEMPT_RT is broken already. Therefore, last week, I've been promoting generic_handle_domain_irq_safe() https://lkml.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de and sadly I missed dln2. Please let me know if you have more users similar to dln2. I will add those to my list once upstream buys that interface. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D8FBC433F5 for ; Mon, 16 May 2022 06:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TqxSNsEPeMblxqF9iVMot8w/yD0Aaua2fXyo32kMbg4=; b=D3Xv4wNlsT9+eJ WIHVeKdIFLM4UGJZnUxoncBVjN3szZeh+5MhlQUWCu9w6MJaOxKTyYbAwbOVIm0LS5CGSW2w5QaZM /cKqflTz709f/aWw6JTm5bTijLVZJob3V5k2VXZpTKzbU/Gqw7A4v8Ztw8SAXZz67vGZHgsP1DYnk 3rSCU+Rz0zdUM2NePwPcGQy7ccQ3vdpibQ3SPlVKBLRDP4L1Yd5oPX9SO/99/dB8kal3ainqMRqBz AJF433gE8enV42GBhLVSUga8Tz0XGOcz4Ma5EejKvdJcst9rXoWiqvaMsHNnZUJQdaehHJjifNS1P GKMuZY0nAvjtuEhRBssA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUF8-006COd-74; Mon, 16 May 2022 06:30:10 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUF4-006CKg-Bj for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 06:30:07 +0000 Date: Mon, 16 May 2022 08:29:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652682591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2Br0kGTz97gFRI4UoHpjTrAphLEpHX8G3A3EWdmkCo=; b=cil+zbCowMsn2/G+DxFU0NbmaeYTCghUfXe4n8ZAQNo4fW3GYLIaNYsUMp/eRH7tK6l9WH vEOt/i93dsLzwhNpl5F5TQXYXD8heNoAgrlQbJPDAAjM5DK/Uc+lKy3huZgajIMcJ3F5pv gXHqEt44ira47nMMMLsk1WVsUn8BLUo674UZBnsPZ19ZBWyixbexW14wZLpfe4wpUurCdh 2fD4wF1uds3iOPY5yhql9e4RK6OjBFkrbeuXG9CIK/ygxTC52mExQnCIQUUKJj0SzqKW9+ sJsq3QIhAXhOnuOY1hUBeTOel5rBnPBU1LlEC0TvW6P+FG448SFiTXwBt9CZag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652682591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2Br0kGTz97gFRI4UoHpjTrAphLEpHX8G3A3EWdmkCo=; b=h6Pg68+btj1eb0yWjhiNtumHNaV2y/bYZwna19lkebWnNIHB1My4fT5m4PtiVIBtfB/Byx b58Z8SaQXr+2pJCA== From: Sebastian Andrzej Siewior To: Lukas Wunner Cc: Thomas Gleixner , Marc Zyngier , Mark Rutland , Jakub Kicinski , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Octavian Purdila , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] genirq: Deduplicate WARN_ON_ONCE() in generic_handle_domain_irq() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220515_233006_579649_A146B91E X-CRM114-Status: UNSURE ( 9.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi0wNS0xMCAwOTo1NjowNSBbKzAyMDBdLCBMdWthcyBXdW5uZXIgd3JvdGU6Cj4gQW4g ZXhhbXBsZSBmb3IgaXJxY2hpcHMgd2hlcmUgdGhlIHdhcm5pbmcgaXMgZmFsc2UgcG9zaXRpdmUg YXJlCj4gVVNCLWF0dGFjaGVkIEdQSU8gY29udHJvbGxlcnMgc3VjaCBhcyBkcml2ZXJzL2dwaW8v Z3Bpby1kbG4yLmM6CgpUaGV5IGFyZSBub3QgZmFsc2UgcG9zaXRpdmVzIGJlY2F1c2XigKYKCj4g VVNCIGdhZGdldHMgYXJlIGluY2FwYWJsZSBvZiBkaXJlY3RseSBzaWduYWxpbmcgYW4gaW50ZXJy dXB0IGJlY2F1c2UKPiB0aGV5IGNhbm5vdCBpbml0aWF0ZSBhIGJ1cyB0cmFuc2FjdGlvbiBieSB0 aGVtc2VsdmVzLiAgQWxsIGNvbW11bmljYXRpb24KPiBvbiB0aGUgYnVzIGlzIGluaXRpYXRlZCBi eSB0aGUgaG9zdCBjb250cm9sbGVyLCB3aGljaCBwb2xscyBhIGdhZGdldCdzCj4gSW50ZXJydXB0 IEVuZHBvaW50IGluIHJlZ3VsYXIgaW50ZXJ2YWxzLiAgSWYgYW4gaW50ZXJydXB0IGlzIHBlbmRp bmcsCj4gdGhhdCBpbmZvcm1hdGlvbiBpcyBwYXNzZWQgdXAgdGhlIHN0YWNrIGluIHNvZnRpcnEg Y29udGV4dCwgZnJvbSB3aGljaAo+IGEgaGFyZGlycSBpcyBzeW50aGVzaXplZCB2aWEgZ2VuZXJp Y19oYW5kbGVfZG9tYWluX2lycSgpLgoKdGhleSB0ZWxsIHlvdSB0aGF0IHRoZSBjb250ZXh0IGlz IHdyb25nLiBGcm9tIGxvb2tpbmcgYXQgZ3Bpby1kbG4yCnRoaXMgaXMgY2FsbGVkIGZyb20gVVNC IFVSQidzIGNhbGxiYWNrIHdoaWNoIGlzIHNvZnRpcnEuIEluIHRoZSBlbmQKZGxuMl9ncGlvX2V2 ZW50KCkgaXMgaW52b2tlZCB3aGlsZSBkbG4yX2Rldjo6ZXZlbnRfY2JfbG9jayBpcyBhY3F1aXJl ZC4KVGhhdCBsb2NrIGlzIGFjcXVpcmVkIGJ5IGRpc2FibGluZyBpbnRlcnJ1cHRzIHdoaWNoIGlz IHdoYXQgZ2V0cyB0aGUKbG9ja2luZyByaWdodCBmb3IgZ2VuZXJpY19oYW5kbGVfZG9tYWluX2ly cSgpLiBJZiB0aGF0IGxvY2sgbGlmdGVkIHRvCnNwaW5fbG9ja19iaCgpIChiZWNhdXNlIGl0IGlz IGFsd2F5cyBpbiB1cmIncyBjYWxiYWNrIGNvbnRleHQgYW5kIGFsbApIQ0RzIGNvbXBsZXRlIGlu IG9uZSBjb250ZXh0IHVubGlrZSBub3cpIHRoZW4gdGhpcyBicmVha3MuIEFuZApQUkVFTVBUX1JU IGlzIGJyb2tlbiBhbHJlYWR5LiBUaGVyZWZvcmUsIGxhc3Qgd2VlaywgSSd2ZSBiZWVuIHByb21v dGluZwpnZW5lcmljX2hhbmRsZV9kb21haW5faXJxX3NhZmUoKQogICBodHRwczovL2xrbWwua2Vy bmVsLm9yZy9yL1lua2ZXRnp2dXNGRmt0U3RAbGludXRyb25peC5kZQoKYW5kIHNhZGx5IEkgbWlz c2VkIGRsbjIuIFBsZWFzZSBsZXQgbWUga25vdyBpZiB5b3UgaGF2ZSBtb3JlIHVzZXJzCnNpbWls YXIgdG8gZGxuMi4gSSB3aWxsIGFkZCB0aG9zZSB0byBteSBsaXN0IG9uY2UgdXBzdHJlYW0gYnV5 cyB0aGF0CmludGVyZmFjZS4KClNlYmFzdGlhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=