From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608B7C433EF for ; Mon, 16 May 2022 14:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244301AbiEPONP (ORCPT ); Mon, 16 May 2022 10:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244080AbiEPONN (ORCPT ); Mon, 16 May 2022 10:13:13 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A9D832066; Mon, 16 May 2022 07:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652710392; x=1684246392; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q8T0jBh7cGQQ4AUWl+1aBVbwpP+Txn2+ZD1GDsXUmwY=; b=M49qI2RJYNeFyww4GpPEloAJZf3RvDjzRG/yy1d94WdKvwT70eNfFVah rHztlRV/mWPf6deUpgZmot8zsEE3Sy4c/WuAal94+s7f8JXFx2DBmFSEJ LJ/nAuUNJhgdsbdkTnhBU+aPmZqkuYbowLgerMOOuCzCnpZ7+BFG4OOUG E5oQgCkYYpvy3ZH2pI4dWq1GLRVAS14Mc3vr9ZJme/SJAHxU9qCXD4JuQ BDOOW2soJYlGtKzCHw7/1xW9gkEGPhH/YmvpaVjd9dorsFmN8inO1eeib YgU4SB2U0qnzuooP5UuyHm64U2EzZu1f37bbqi0xs4zewgcHeRUaZ5voi Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="252906637" X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="252906637" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 07:13:11 -0700 X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="638258613" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 07:13:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nqbQv-0006ib-VU; Mon, 16 May 2022 17:10:49 +0300 Date: Mon, 16 May 2022 17:10:49 +0300 From: Andy Shevchenko To: Michael Ellerman Cc: Wolfram Sang , Marc Kleine-Budde , Damien Le Moal , Mark Brown , chris.packham@alliedtelesis.co.nz, Sergey Shtylyov , "David S. Miller" , Jakub Kicinski , Greg Kroah-Hartman , Jiri Slaby , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-i2c@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Anatolij Gustschin , Wolfgang Grandegger , Eric Dumazet , Paolo Abeni , Pantelis Antoniou Subject: Re: [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API Message-ID: References: <20220507100147.5802-1-andriy.shevchenko@linux.intel.com> <20220507100147.5802-4-andriy.shevchenko@linux.intel.com> <877d6l7fmy.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote: > On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote: > > Andy Shevchenko writes: > > > We may convert the GPT driver to use fwnode API for the sake > > > of consistency of the used APIs inside the driver. > > > > I'm not sure about this one. > > > > It's more consistent to use fwnode in this driver, but it's very > > inconsistent with the rest of the powerpc code. We have basically no > > uses of the fwnode APIs at the moment. > > Fair point! > > > It seems like a pretty straight-forward conversion, but there could > > easily be a bug in there, I don't have any way to test it. Do you? > > Nope, only compile testing. The important part of this series is to > clean up of_node from GPIO library, so since here it's a user of > it I want to do that. This patch is just ad-hoc conversion that I > noticed is possible. But there is no any requirement to do so. > > Lemme drop this from v3. I just realize that there is no point to send a v3. You can just apply first 3 patches. Or is your comment against entire series? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0479C433EF for ; Mon, 16 May 2022 14:13:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L21Sz1wz6z3cDx for ; Tue, 17 May 2022 00:13:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cn5VNekr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cn5VNekr; dkim-atps=neutral Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L21SG42m3z2xsc for ; Tue, 17 May 2022 00:13:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652710398; x=1684246398; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q8T0jBh7cGQQ4AUWl+1aBVbwpP+Txn2+ZD1GDsXUmwY=; b=Cn5VNekrEnPPa9Jsye535dFObXMGdnFUTS0DqPSdpoK9LrA3CK4gWRXY rsQvi4YLiKZqgBv84VuiFGfEhXg+sIC6TjkNGZWgz/DZjw1sTME40Nx8W 4YlS3PF1+NlROWP9ROT/LjgJXSNKRg/jnIu+gm2OirH3FbXzCBNtau6C2 ZQqO7NxAMEW6sCGt9VguPE70Ix0K812vL2We0Yi8JLbnS8keCLSPbGot0 +oS0lofJiY/cqk55LmTxNlHH4FK8mBCo/9O0koGzBOLIYe5flW1syIK18 rRMWln3OF86HOTLUBaTKwHXg3rXB+0xn9RzwaZk9ftLVlzWBtndkFRh/U A==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="333897358" X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="333897358" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 07:13:12 -0700 X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="638258613" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 07:13:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nqbQv-0006ib-VU; Mon, 16 May 2022 17:10:49 +0300 Date: Mon, 16 May 2022 17:10:49 +0300 From: Andy Shevchenko To: Michael Ellerman Subject: Re: [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API Message-ID: References: <20220507100147.5802-1-andriy.shevchenko@linux.intel.com> <20220507100147.5802-4-andriy.shevchenko@linux.intel.com> <877d6l7fmy.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ide@vger.kernel.org, Eric Dumazet , Paul Mackerras , linux-i2c@vger.kernel.org, Paolo Abeni , Jiri Slaby , Damien Le Moal , linux-serial@vger.kernel.org, Jakub Kicinski , Anatolij Gustschin , Wolfgang Grandegger , linux-can@vger.kernel.org, Mark Brown , Marc Kleine-Budde , Sergey Shtylyov , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Wolfram Sang , chris.packham@alliedtelesis.co.nz, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote: > On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote: > > Andy Shevchenko writes: > > > We may convert the GPT driver to use fwnode API for the sake > > > of consistency of the used APIs inside the driver. > > > > I'm not sure about this one. > > > > It's more consistent to use fwnode in this driver, but it's very > > inconsistent with the rest of the powerpc code. We have basically no > > uses of the fwnode APIs at the moment. > > Fair point! > > > It seems like a pretty straight-forward conversion, but there could > > easily be a bug in there, I don't have any way to test it. Do you? > > Nope, only compile testing. The important part of this series is to > clean up of_node from GPIO library, so since here it's a user of > it I want to do that. This patch is just ad-hoc conversion that I > noticed is possible. But there is no any requirement to do so. > > Lemme drop this from v3. I just realize that there is no point to send a v3. You can just apply first 3 patches. Or is your comment against entire series? -- With Best Regards, Andy Shevchenko