Re: [PATCH 1/5] KVM: Shove vm stats_id init into kvm_create_vm_debugfs()

[Sean Christopherson <seanjc@google.com>]

On Fri, Apr 15, 2022, Oliver Upton wrote:
> The field is only ever used for debugfs; put the initialization where
> it belongs.

No?

static ssize_t kvm_vm_stats_read(struct file *file, char __user *user_buffer,
			      size_t size, loff_t *offset)
{
	struct kvm *kvm = file->private_data;

	return kvm_stats_read(kvm->stats_id, &kvm_vm_stats_header,
				&kvm_vm_stats_desc[0], &kvm->stat,
				sizeof(kvm->stat), user_buffer, size, offset);
}

static const struct file_operations kvm_vm_stats_fops = {
	.read = kvm_vm_stats_read,
	.llseek = noop_llseek,
};


And with a name like kvm->stats_id, debugfs seems like it's piggbacking stats,
not the other way 'round.