From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] i2c: gpio: support write-only sda
Date: Mon, 16 May 2022 21:37:44 +0200 [thread overview]
Message-ID: <YoKoCFU/apFMyUUC@kunai> (raw)
In-Reply-To: <a09b4c2e-5256-25b7-59da-f93b04d128c5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
> + * If SCL/SDA both are write-only, then this indicates I2C-like slaves
> + * with read-only SCL/SDA. Such slaves don't need open-drain, and partially
> + * don't even work with open-drain.
This comment is great!
> + * @sda_is_output_only: I2C-like interface, SDA is write-only.
This one not so much ;)
> * @scl_is_open_drain: SCL is set up as open drain. Same requirements
> * as for sda_is_open_drain apply.
> * @scl_is_output_only: SCL output drivers cannot be turned off.
I think we whould use a similar description for SDA like we have for
SCL. Maybe we should also repeat here that this setup is for clients
which can only read SDA/SCL?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-05-16 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 19:20 [PATCH v2 0/3] i2c: gpio: support write-only sda Heiner Kallweit
2022-04-27 19:23 ` [PATCH v2 1/3] dt-bindings: i2c-gpio: Add property i2c-gpio,sda-output-only Heiner Kallweit
2022-05-03 21:11 ` Rob Herring
2022-04-27 19:24 ` [PATCH v2 2/3] i2c: algo: bit: allow getsda to be NULL Heiner Kallweit
2022-05-16 19:31 ` Wolfram Sang
2022-08-14 21:06 ` Heiner Kallweit
2022-12-11 14:52 ` Heiner Kallweit
2022-04-27 19:25 ` [PATCH v2 3/3] i2c: gpio: support write-only sda Heiner Kallweit
2022-05-16 19:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoKoCFU/apFMyUUC@kunai \
--to=wsa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.