From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0A63C433F5 for ; Tue, 17 May 2022 00:47:03 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nqlMd-0006lw-6q; Tue, 17 May 2022 00:47:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqlMb-0006li-KN for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 00:47:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kt73Bnav7cAqkJhCevXD0n2PfLUPuwWXUtq/Rn12uDc=; b=J2Bz2GgOD8/ZtG9b4nDtSjX0Ts mfKtYtzOnBvl+aqeESVWssE2E0rSFaq9ESrjB6b7DV1ViaNMRVUrfbxHQ/XxZi3M+jvMbB9E9i60D ZgxiaMKs9GCveo2/gzn1cyAEq3MFD5nhtbuQA7InYlHwJcOVawWOuUW59YxPZdchofzo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kt73Bnav7cAqkJhCevXD0n2PfLUPuwWXUtq/Rn12uDc=; b=GAw9CvnckRsdz+2LgzTw0CwRgc SWfQRx2JmoGEcPG02Aj5UUm+oPbShJA+eGgLQNS36b1YJ5mJ+exFJL3Oj9ckRpRva5pPhvmyEG5bs 3S9Gk6E/2JEzYEwn1MtoV/yyk/qXrM3Q0wGQNBybGsFiGEruzmrsw2+Hw6BgDhyQyb/g=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nqlMW-0002TI-36 for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 00:46:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1F1360B15; Tue, 17 May 2022 00:46:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23A7DC385AA; Tue, 17 May 2022 00:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652748409; bh=ufFkiJ8jCbR/3dqnyjJjzAoF4JiGJFufQ2JZEyKasEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cYfIWaInZxzuaTCW8ZZGogzVczuFa/lI6hVHNOYimJny12nEj2xtBAer+2L40UwW0 1PBafMkcy7A2UsOMMCeiaPkiEQl/akHfNvB/rgo+XLSpJDN8Q5HILG36ixNN+kuAI9 Rmg9mIUHAXDIEtxAArtxRvHPbW5U26LeSIMJWGY2VseSuwo/w+EbzCBX+FxXu3mWb+ y8tXDC/kdRUeP5Ocp5mLpOkHL1W6Ms/TPZwVydMQ/w42von+yqvlBpbwtfEGeuc4J0 KmnFf3K887uCjs4lllDu30NPBy0fGCfLO4Q46PfEyRK8l51wsphfGqXEOtIH1ooZM/ biIncuFF7jwow== Date: Mon, 16 May 2022 17:46:47 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220515090547.1914-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220515090547.1914-1-chao@kernel.org> X-Headers-End: 1nqlMW-0002TI-36 Subject: Re: [f2fs-dev] [PATCH v3] f2fs: fix to do sanity check for inline inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ming Yan , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/15, Chao Yu wrote: > Yanming reported a kernel bug in Bugzilla kernel [1], which can be > reproduced. The bug message is: > > The kernel message is shown below: > > kernel BUG at fs/inode.c:611! > Call Trace: > evict+0x282/0x4e0 > __dentry_kill+0x2b2/0x4d0 > dput+0x2dd/0x720 > do_renameat2+0x596/0x970 > __x64_sys_rename+0x78/0x90 > do_syscall_64+0x3b/0x90 > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=215895 > > The bug is due to fuzzed inode has both inline_data and encrypted flags. > During f2fs_evict_inode(), as the inode was deleted by rename(), it > will cause inline data conversion due to conflicting flags. The page > cache will be polluted and the panic will be triggered in clear_inode(). > > Try fixing the bug by doing more sanity checks for inline data inode in > sanity_check_inode(). > > Cc: stable@vger.kernel.org > Reported-by: Ming Yan > Signed-off-by: Chao Yu > --- > v3: > - clean up commit message suggested by Bagas Sanjaya. > fs/f2fs/f2fs.h | 8 ++++++++ > fs/f2fs/inode.c | 3 +-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 492af5b96de1..0dc2461ef02c 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -4126,6 +4126,14 @@ static inline void f2fs_set_encrypted_inode(struct inode *inode) > */ > static inline bool f2fs_post_read_required(struct inode *inode) > { > + /* > + * used by sanity_check_inode(), when disk layout fields has not > + * been synchronized to inmem fields. > + */ > + if (S_ISREG(inode->i_mode) && (file_is_encrypt(inode) || > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL || > + file_is_verity(inode))) > + return true; Again, I prefer to check this in sanity_check_inode(), since we don't need to check all the time here. > return f2fs_encrypted_file(inode) || fsverity_active(inode) || > f2fs_compressed_file(inode); > } > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 2fce8fa0dac8..5e494c98e3c2 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -276,8 +276,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > } > } > > - if (f2fs_has_inline_data(inode) && > - (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))) { > + if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) { > set_sbi_flag(sbi, SBI_NEED_FSCK); > f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > __func__, inode->i_ino, inode->i_mode); > -- > 2.32.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379C8C433EF for ; Tue, 17 May 2022 00:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234245AbiEQAqz (ORCPT ); Mon, 16 May 2022 20:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbiEQAqx (ORCPT ); Mon, 16 May 2022 20:46:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 142E613D40; Mon, 16 May 2022 17:46:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD39CB815CE; Tue, 17 May 2022 00:46:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23A7DC385AA; Tue, 17 May 2022 00:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652748409; bh=ufFkiJ8jCbR/3dqnyjJjzAoF4JiGJFufQ2JZEyKasEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cYfIWaInZxzuaTCW8ZZGogzVczuFa/lI6hVHNOYimJny12nEj2xtBAer+2L40UwW0 1PBafMkcy7A2UsOMMCeiaPkiEQl/akHfNvB/rgo+XLSpJDN8Q5HILG36ixNN+kuAI9 Rmg9mIUHAXDIEtxAArtxRvHPbW5U26LeSIMJWGY2VseSuwo/w+EbzCBX+FxXu3mWb+ y8tXDC/kdRUeP5Ocp5mLpOkHL1W6Ms/TPZwVydMQ/w42von+yqvlBpbwtfEGeuc4J0 KmnFf3K887uCjs4lllDu30NPBy0fGCfLO4Q46PfEyRK8l51wsphfGqXEOtIH1ooZM/ biIncuFF7jwow== Date: Mon, 16 May 2022 17:46:47 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ming Yan , Chao Yu Subject: Re: [PATCH v3] f2fs: fix to do sanity check for inline inode Message-ID: References: <20220515090547.1914-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220515090547.1914-1-chao@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15, Chao Yu wrote: > Yanming reported a kernel bug in Bugzilla kernel [1], which can be > reproduced. The bug message is: > > The kernel message is shown below: > > kernel BUG at fs/inode.c:611! > Call Trace: > evict+0x282/0x4e0 > __dentry_kill+0x2b2/0x4d0 > dput+0x2dd/0x720 > do_renameat2+0x596/0x970 > __x64_sys_rename+0x78/0x90 > do_syscall_64+0x3b/0x90 > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=215895 > > The bug is due to fuzzed inode has both inline_data and encrypted flags. > During f2fs_evict_inode(), as the inode was deleted by rename(), it > will cause inline data conversion due to conflicting flags. The page > cache will be polluted and the panic will be triggered in clear_inode(). > > Try fixing the bug by doing more sanity checks for inline data inode in > sanity_check_inode(). > > Cc: stable@vger.kernel.org > Reported-by: Ming Yan > Signed-off-by: Chao Yu > --- > v3: > - clean up commit message suggested by Bagas Sanjaya. > fs/f2fs/f2fs.h | 8 ++++++++ > fs/f2fs/inode.c | 3 +-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 492af5b96de1..0dc2461ef02c 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -4126,6 +4126,14 @@ static inline void f2fs_set_encrypted_inode(struct inode *inode) > */ > static inline bool f2fs_post_read_required(struct inode *inode) > { > + /* > + * used by sanity_check_inode(), when disk layout fields has not > + * been synchronized to inmem fields. > + */ > + if (S_ISREG(inode->i_mode) && (file_is_encrypt(inode) || > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL || > + file_is_verity(inode))) > + return true; Again, I prefer to check this in sanity_check_inode(), since we don't need to check all the time here. > return f2fs_encrypted_file(inode) || fsverity_active(inode) || > f2fs_compressed_file(inode); > } > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 2fce8fa0dac8..5e494c98e3c2 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -276,8 +276,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > } > } > > - if (f2fs_has_inline_data(inode) && > - (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))) { > + if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) { > set_sbi_flag(sbi, SBI_NEED_FSCK); > f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > __func__, inode->i_ino, inode->i_mode); > -- > 2.32.0