All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zev Weiss <zev@bewilderbeest.net>
To: Joel Stanley <joel@jms.id.au>, openbmc@lists.ozlabs.org
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	"Ryan Chen" <ryan_chen@aspeedtech.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH] ftgmac100: use bus name in mdio error messages
Date: Mon, 16 May 2022 21:51:15 -0700	[thread overview]
Message-ID: <YoMpw1WrKC+RBez4@hatter.bewilderbeest.net> (raw)
In-Reply-To: <20220517043825.26893-1-zev@bewilderbeest.net>

On Mon, May 16, 2022 at 09:38:25PM PDT, Zev Weiss wrote:
> Previously we'd been using a device name retrieved via
> ftgmac100_data->phydev, but the mdio read/write functions may be
> called before that member is initialized in ftgmac100_phy_init(),
> leading to a NULL pointer dereference while printing the error message
> issued if the mdio access fails.  We can instead use bus->name, which
> is already available at that point.
> 
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> Fixes: 538e75d3fc54 ("net: ftgmac100: add MDIO bus and phylib support")
> ---
>  drivers/net/ftgmac100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Sorry, forgot the subject-prefix tag on this one -- this is for u-boot 
v2019.04-aspeed-openbmc in case it wasn't clear.

Zev


  reply	other threads:[~2022-05-17  4:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  4:38 [PATCH] ftgmac100: use bus name in mdio error messages Zev Weiss
2022-05-17  4:51 ` Zev Weiss [this message]
2022-05-17  4:54   ` Joel Stanley
2022-05-17  9:28     ` Zev Weiss
2022-05-17  9:31       ` Joel Stanley
2022-05-17  5:44 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoMpw1WrKC+RBez4@hatter.bewilderbeest.net \
    --to=zev@bewilderbeest.net \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.