From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D661C433FE for ; Tue, 17 May 2022 13:13:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4632110F040; Tue, 17 May 2022 13:13:10 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71C0B112FDF for ; Tue, 17 May 2022 10:06:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEBDF61517; Tue, 17 May 2022 10:06:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59AE9C34113; Tue, 17 May 2022 10:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652781992; bh=HhKKBm3wiaE0xpknwdH7ZBGXkWj2DptvFeir39Hw/ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4nSFNRTu0P8ATljrJdxEj6spDFOWhsmBg7TkrTDh2dqNptrLPUH7PzVSw+aVXFm8 0tPHPUBt/fc5Ue24QZByFrUBjiqMeuMx/eLrQHt5bMIT18zYXfATHho/FluGkpmYfU lEl1JaLzl7F1l7D07G+6GoGhkDuL5q1uj1UYXfkk= Date: Tue, 17 May 2022 12:06:27 +0200 From: Greg KH To: Yuanjun Gong Subject: Re: [PATCH 1/1] drm/amd/pm: fix a potential gpu_metrics_table memory leak Message-ID: References: <20220517095746.7537-1-ruc_gongyuanjun@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517095746.7537-1-ruc_gongyuanjun@163.com> X-Mailman-Approved-At: Tue, 17 May 2022 13:13:09 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Evan Quan , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, May 17, 2022 at 05:57:46PM +0800, Yuanjun Gong wrote: > From: Gong Yuanjun > > gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but > not freed in yellow_carp_fini_smc_tables(). > > Signed-off-by: Gong Yuanjun > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > index e2d099409123..c66c39ccf19c 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > @@ -190,6 +190,9 @@ static int yellow_carp_fini_smc_tables(struct smu_context *smu) > kfree(smu_table->watermarks_table); > smu_table->watermarks_table = NULL; > > + kfree(smu_table->gpu_metrics_table); > + smu_table->gpu_metrics_table = NULL; > + > return 0; > } > > -- > 2.17.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2CAC433EF for ; Tue, 17 May 2022 10:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343628AbiEQKJv (ORCPT ); Tue, 17 May 2022 06:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343788AbiEQKGz (ORCPT ); Tue, 17 May 2022 06:06:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F35F12A8D; Tue, 17 May 2022 03:06:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A443B817DF; Tue, 17 May 2022 10:06:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59AE9C34113; Tue, 17 May 2022 10:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652781992; bh=HhKKBm3wiaE0xpknwdH7ZBGXkWj2DptvFeir39Hw/ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4nSFNRTu0P8ATljrJdxEj6spDFOWhsmBg7TkrTDh2dqNptrLPUH7PzVSw+aVXFm8 0tPHPUBt/fc5Ue24QZByFrUBjiqMeuMx/eLrQHt5bMIT18zYXfATHho/FluGkpmYfU lEl1JaLzl7F1l7D07G+6GoGhkDuL5q1uj1UYXfkk= Date: Tue, 17 May 2022 12:06:27 +0200 From: Greg KH To: Yuanjun Gong Cc: Evan Quan , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] drm/amd/pm: fix a potential gpu_metrics_table memory leak Message-ID: References: <20220517095746.7537-1-ruc_gongyuanjun@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517095746.7537-1-ruc_gongyuanjun@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 05:57:46PM +0800, Yuanjun Gong wrote: > From: Gong Yuanjun > > gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but > not freed in yellow_carp_fini_smc_tables(). > > Signed-off-by: Gong Yuanjun > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > index e2d099409123..c66c39ccf19c 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c > @@ -190,6 +190,9 @@ static int yellow_carp_fini_smc_tables(struct smu_context *smu) > kfree(smu_table->watermarks_table); > smu_table->watermarks_table = NULL; > > + kfree(smu_table->gpu_metrics_table); > + smu_table->gpu_metrics_table = NULL; > + > return 0; > } > > -- > 2.17.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.