From: Dan Carpenter <dan.carpenter@oracle.com>
To: haijun.liu@mediatek.com
Cc: linux-mediatek@lists.infradead.org
Subject: [bug report] net: wwan: t7xx: Data path HW layer
Date: Tue, 17 May 2022 14:49:13 +0300 [thread overview]
Message-ID: <YoOLubp7ZUz4Sngw@kili> (raw)
Hello Haijun Liu,
The patch 33f78ab5a38a: "net: wwan: t7xx: Data path HW layer" from
May 6, 2022, leads to the following Smatch static checker warning:
drivers/net/wwan/t7xx/t7xx_dpmaif.c:1054 t7xx_dl_add_timedout()
warn: signedness bug returning '(-110)'
drivers/net/wwan/t7xx/t7xx_dpmaif.c
1046 static bool t7xx_dl_add_timedout(struct dpmaif_hw_info *hw_info)
^^^^
1047 {
1048 u32 value;
1049 int ret;
1050
1051 ret = ioread32_poll_timeout_atomic(hw_info->pcie_base + DPMAIF_DL_BAT_ADD,
1052 value, !(value & DPMAIF_DL_ADD_NOT_READY), 0,
1053 DPMAIF_CHECK_TIMEOUT_US);
--> 1054 return ret;
Returning negative error codes to bool is non-standard but, in this
case, harmless.
1055 }
regards,
dan carpenter
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
reply other threads:[~2022-05-17 11:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOLubp7ZUz4Sngw@kili \
--to=dan.carpenter@oracle.com \
--cc=haijun.liu@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.