From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC62CC433F5 for ; Tue, 17 May 2022 14:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=muqPgs+Q1ZBcLRdyDOjR3cvMTt+QX/STuacLczOldWA=; b=zNA2Bp9jwA8tH0 qCBKTQnxDrmr+D63/kJpvshh+fGnArFEv+1k5maf1ToK4oY9Ikc8bApNVllG5PH5VosgDT8KDZA3p FhylgJKTEHStRtXxSQJt/i+4BqngqQ1HCQbXA5PLFR2dagnYaUxwmjbfmB70+YhGd4GCf7v4N9ovp g8N2EGwJtBQHuFGMLxAAsvMdO4HJr7J4hm5sTlbaT1aki4wZXFL4jHcG5W1NPAfMw0rOvZ8DMACfJ 9wjfs7S/Cl/ZaHdxo2tepiZKZpRw2VJGC/EciKTRGTXVSQlEv7D/ozDT9y+7DsjaGlNMnByQOweGC iozlFVXASoB+OUTIbk9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqy4m-00EJIL-1K; Tue, 17 May 2022 14:21:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqy4c-00EIF4-DZ for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 14:21:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fQzWuq6EodGqOHx9GjfS0em/RXgWCwpj6VxGmmEdosQ=; b=GSTBgEDKg243NCQCyGxq80aNwY UFyU1aun29GdmgxMKObbq2Hbt2UesJp8w7dKQHvVHGRXf67gtQFmxsekfTF+fQVtABv8mDgXc/Icf Y9rVTbiiqWz00VT1N9LAWk/eDmZ4v6v2fFdBKW/pU8dkf9m1pLFOqsNF6TpZrnYyWh0CbZ0NUpI9n SToxgqngGYftWPXFOiV8Pyp4s+bUygYNahLOMWMGEKS2LOxu0VmyokMbOVQGKgTgSNSEX60hu7eVu rwgJ7S98vmojp8OkpyaV5QcgivGOwCpJPO6P97f6CfWPFMCrLpDYXRHdS9HRc4x34nG+NhQVE857h viTCLWzA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60744) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqy2Q-0000NU-O8; Tue, 17 May 2022 15:19:03 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nqy2O-0004VH-36; Tue, 17 May 2022 15:19:00 +0100 Date: Tue, 17 May 2022 15:19:00 +0100 From: "Russell King (Oracle)" To: Chen Zhongjin Cc: alexander.sverdlin@nokia.com, ardb@kernel.org, linus.walleij@linaro.org, nico@fluxnic.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module Message-ID: References: <20220401131534.241205-1-chenzhongjin@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220401131534.241205-1-chenzhongjin@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_072118_501245_4C8C9849 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote: > struct mod_arch_specific { > #ifdef CONFIG_ARM_UNWIND > - struct unwind_table *unwind[ARM_SEC_MAX]; > + struct unwind_table unwind_list; Why is this not a: struct list_head unwind_list; because, from what I can tell, the _only_ member that is used in this struct unwind_table is the "mod_list" member - so everything else is entirely unused and redundant. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1322CC433FE for ; Tue, 17 May 2022 14:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348698AbiEQOTV (ORCPT ); Tue, 17 May 2022 10:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236741AbiEQOTR (ORCPT ); Tue, 17 May 2022 10:19:17 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB9D0344FA for ; Tue, 17 May 2022 07:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fQzWuq6EodGqOHx9GjfS0em/RXgWCwpj6VxGmmEdosQ=; b=GSTBgEDKg243NCQCyGxq80aNwY UFyU1aun29GdmgxMKObbq2Hbt2UesJp8w7dKQHvVHGRXf67gtQFmxsekfTF+fQVtABv8mDgXc/Icf Y9rVTbiiqWz00VT1N9LAWk/eDmZ4v6v2fFdBKW/pU8dkf9m1pLFOqsNF6TpZrnYyWh0CbZ0NUpI9n SToxgqngGYftWPXFOiV8Pyp4s+bUygYNahLOMWMGEKS2LOxu0VmyokMbOVQGKgTgSNSEX60hu7eVu rwgJ7S98vmojp8OkpyaV5QcgivGOwCpJPO6P97f6CfWPFMCrLpDYXRHdS9HRc4x34nG+NhQVE857h viTCLWzA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60744) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqy2Q-0000NU-O8; Tue, 17 May 2022 15:19:03 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nqy2O-0004VH-36; Tue, 17 May 2022 15:19:00 +0100 Date: Tue, 17 May 2022 15:19:00 +0100 From: "Russell King (Oracle)" To: Chen Zhongjin Cc: alexander.sverdlin@nokia.com, ardb@kernel.org, linus.walleij@linaro.org, nico@fluxnic.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module Message-ID: References: <20220401131534.241205-1-chenzhongjin@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220401131534.241205-1-chenzhongjin@huawei.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote: > struct mod_arch_specific { > #ifdef CONFIG_ARM_UNWIND > - struct unwind_table *unwind[ARM_SEC_MAX]; > + struct unwind_table unwind_list; Why is this not a: struct list_head unwind_list; because, from what I can tell, the _only_ member that is used in this struct unwind_table is the "mod_list" member - so everything else is entirely unused and redundant. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!