All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Zongmin Zhou <zhouzongmin@kylinos.cn>
Cc: linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/vmmouse: Add vmmouse_reset() function to disable vmmouse before entering suspend mode
Date: Tue, 17 May 2022 21:56:55 -0700	[thread overview]
Message-ID: <YoR8l/UK8rXS1F8A@google.com> (raw)
In-Reply-To: <20220322021046.1087954-1-zhouzongmin@kylinos.cn>

On Tue, Mar 22, 2022 at 10:10:46AM +0800, Zongmin Zhou wrote:
> Details:
> When I use VirtualPS/2 VMMouse on virtual machine,There will be an error message after resume from suspend mode.
> like below:
> psmouse serio1: vmmouse: Unable to re-enable mouse when reconnecting, err: -6
> And vmmouse will be unusable,so have to do full rescan to find a another driver to use for the port.
> 
> This error is due to QEMU still generate PS2 events to notify kernel driver to read from queue,
> but kernel can't process the data in suspend mode, resulting a surge of s->nb_queue value,
> which ultimately led to an error getting VMMOUSE_VERSION_ID after resume.
> 
> Test scenario:
> 1)virtual machine started with qemu command "vmport=on",it will use VirtualPS/2 VMMouse
> 2)click suspend botton to enter suspend mode
> 3)resume and will get the error message from dmesg
> 
> Fixed by:
> Disabling the vmmouse in its reset handler,It will notify qemu to stop vmmouse and remove handler.
> 
> Signed-off-by: Zongmin Zhou<zhouzongmin@kylinos.cn>

Applied, thank you.

-- 
Dmitry

      parent reply	other threads:[~2022-05-18  4:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  2:10 [PATCH] input/vmmouse: Add vmmouse_reset() function to disable vmmouse before entering suspend mode Zongmin Zhou
2022-03-31  1:59 ` [RESEND PATCH] " Zongmin Zhou
2022-04-06 10:08 ` Zongmin Zhou
2022-04-26  2:40 ` [PATCH] " Zack Rusin
2022-05-18  4:56 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoR8l/UK8rXS1F8A@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=zhouzongmin@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.