From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-doc@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Benson Leung <bleung@google.com>,
Guenter Roeck <groeck@chromium.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH 1/2] platform/chrome: Use tables for values lists of ChromeOS ACPI sysfs ABI
Date: Wed, 18 May 2022 15:19:04 +0800 [thread overview]
Message-ID: <YoSd6NQBvX41y7Fb@google.com> (raw)
In-Reply-To: <2816e961-08f9-407b-e8f8-b63f844d864c@gmail.com>
On Wed, May 18, 2022 at 01:50:26PM +0700, Bagas Sanjaya wrote:
> On 5/18/22 10:37, Tzung-Bi Shih wrote:
> > On Wed, May 18, 2022 at 10:17:50AM +0700, Bagas Sanjaya wrote:
> >> What: /sys/bus/platform/devices/GGL0001:*/CHSW
> >> Date: May 2022
> >> KernelVersion: 5.19
> >> Description:
> >> This file shows the switch position for the Chrome OS specific
> >> - hardware switches.
> >> - * 0 - No changes.
> >> - * 2 - Recovery button was pressed when firmware booted.
> >> - * 4 - Recovery button was pressed when EC firmware booted.
> >> - * 32 - Developer switch was enabled when firmware booted.
> >> - * 512 - Firmware write protection was disabled when firmware
> >> - booted.
> >> + hardware switches when the firmare is booted.
> >
> > s/firmare/firmware/.
> >
> > Could you fix it in v2 and also Cc to <chrome-platform@lists.linux.dev>?
>
> OK, but regarding the schedule, we are on -rc7 (official mainline release
> will be imminent). Maybe I can send the v2 immediately, or should I wait
> for a day?
I think either way is fine. The patch introduced the sphinx warning is still
in chrome-platform's for-next branch[1]. And it should send to mainline when
the next merge window opens.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/commit/?h=for-next&id=0a4cad9c11ad46662ede48d94f08ecb7cd9f6916
next prev parent reply other threads:[~2022-05-18 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 3:17 [PATCH 0/2] platform/chrome: Documentation update for Chrome OS ACPI Bagas Sanjaya
2022-05-18 3:17 ` [PATCH 1/2] platform/chrome: Use tables for values lists of ChromeOS ACPI sysfs ABI Bagas Sanjaya
2022-05-18 3:37 ` Tzung-Bi Shih
2022-05-18 6:50 ` Bagas Sanjaya
2022-05-18 7:19 ` Tzung-Bi Shih [this message]
2022-05-18 3:17 ` [PATCH 2/2] platform/chrome: Use imperative mood for ChromeOS ACPI sysfs ABI descriptions Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoSd6NQBvX41y7Fb@google.com \
--to=tzungbi@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bleung@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sfr@canb.auug.org.au \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.