All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Liang Chen <liangchen.linux@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
	jmoyer@redhat.com, jack@suse.cz, lczerner@redhat.com
Subject: Re: [PATCH v2] fs: Fix page cache inconsistency when mixing buffered and AIO DIO for bdev
Date: Wed, 18 May 2022 06:47:34 -0700	[thread overview]
Message-ID: <YoT49tEhHu8uMUt2@infradead.org> (raw)
In-Reply-To: <20220507041033.9588-1-lchen@localhost.localdomain>

On Sat, May 07, 2022 at 12:10:33PM +0800, Liang Chen wrote:
> From: Liang Chen <liangchen.linux@gmail.com>
> 
> As pointed out in commit 332391a, mixing buffered reads and asynchronous
> direct writes risks ending up with a situation where stale data is left
> in page cache while new data is already written to disk. The same problem
> hits block dev fs too. A similar approach needs to be taken here.

What is the real issue here?  If you mix direct and buffered I/O
you generally get what you pay for.  Even more so on block devices that
don't even follow Posix file system semantics.

  parent reply	other threads:[~2022-05-18 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  4:10 [PATCH v2] fs: Fix page cache inconsistency when mixing buffered and AIO DIO for bdev Liang Chen
2022-05-07  4:28 ` Dave Chinner
2022-05-07  8:51   ` Liang Chen
2022-05-18 13:47 ` Christoph Hellwig [this message]
2022-06-08  9:48   ` Liang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoT49tEhHu8uMUt2@infradead.org \
    --to=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jmoyer@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=liangchen.linux@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.