From: Heiko Carstens <hca@linux.ibm.com>
To: Jann Horn <jannh@google.com>,
Harald Freudenberger <freude@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/crypto: fix scatterwalk_unmap() callers in AES-GCM
Date: Wed, 18 May 2022 13:19:39 +0200 [thread overview]
Message-ID: <YoTWSxEYPo1MLQTc@osiris> (raw)
In-Reply-To: <20220517143047.3054498-1-jannh@google.com>
On Tue, May 17, 2022 at 04:30:47PM +0200, Jann Horn wrote:
> The argument of scatterwalk_unmap() is supposed to be the void* that was
> returned by the previous scatterwalk_map() call.
> The s390 AES-GCM implementation was instead passing the pointer to the
> struct scatter_walk.
>
> This doesn't actually break anything because scatterwalk_unmap() only uses
> its argument under CONFIG_HIGHMEM and ARCH_HAS_FLUSH_ON_KUNMAP.
>
> Note that I have not tested this patch in any way, not even compile-tested
> it.
>
> Fixes: bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm support.")
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> IDK which tree this has to go through - s390 or crypto?
> maybe s390 is better, since they can actually test it?
Applied to s390 tree. Thanks!
prev parent reply other threads:[~2022-05-18 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 14:30 [PATCH] s390/crypto: fix scatterwalk_unmap() callers in AES-GCM Jann Horn
2022-05-17 18:01 ` Heiko Carstens
2022-05-18 6:50 ` Harald Freudenberger
2022-05-18 8:30 ` Harald Freudenberger
2022-05-18 11:19 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoTWSxEYPo1MLQTc@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jannh@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.