From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0D3C433FE for ; Thu, 19 May 2022 15:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240856AbiESPY2 (ORCPT ); Thu, 19 May 2022 11:24:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbiESPY1 (ORCPT ); Thu, 19 May 2022 11:24:27 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27A27EBEAD for ; Thu, 19 May 2022 08:24:26 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id i24so5439145pfa.7 for ; Thu, 19 May 2022 08:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RxxDW43556pg8Ua5FCLecPALXbP2iIESOPIMcw9n7sE=; b=dD66mv1j+KlBHvLn/Pnd3LT4IkaDHF185QUHOArIhQ3vq98mh9FVYd4M7G4sAVR6BO 2hjja+BFzPr53FRFkDuOrDIBIE9+tEC7d7kPat/DprLa38AMrc7KSFg4y8ieiLtjRXci YBAv8+zvh67gdCTv8jasxHfsFmUuEUi6IZxmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RxxDW43556pg8Ua5FCLecPALXbP2iIESOPIMcw9n7sE=; b=0gYRGt9Y3DN/89R+d9OwJiFT8LyR9rTlSDDXCOZtQ0IS+PHOMKzppaoN3+52SOGy9a wgEv0UDsTLZvwC3Y1bxO9/rf/X4smWbaH8bdJQheuU902QmgnAyq8SaAzKeBaTDQyVZ9 wBDd2/3RBsX8ujdxbp5YwgqF3vNkXifmyNH/dSq2EaqL+JbPWnlXY2WPuP9ILZ7a9+GK XXDqTEdjDinkp+Vsm/rLDqDFv9y1xwy5n4BBXbSRIb6QjjdDSHP4Zz9uW1AFKbOKUFqq tSORO9cf4w0Azvp70UOqQ1OMPStWupTAELAuSW91cV0jZDiBPHrnoQgvJMFetBfQ9X7A 4ilQ== X-Gm-Message-State: AOAM531oqRYNque8RWxzpJuNkp8daQZmign+5+DXOXHdcBQhg+tB3nFE RPg3OuFybbI4hWDg3pCJKynxGQ== X-Google-Smtp-Source: ABdhPJxWH5HSd2a6kok2fOfyjwjkJ1jaC6v18twZR2TofpZX4x8hZTHdx9Okw9/W96CBOGNO3cnUYA== X-Received: by 2002:a05:6a02:19c:b0:3aa:1bf8:7388 with SMTP id bj28-20020a056a02019c00b003aa1bf87388mr4409154pgb.455.1652973865333; Thu, 19 May 2022 08:24:25 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:e229:79ea:227e:d9dd]) by smtp.gmail.com with UTF8SMTPSA id er14-20020a17090af6ce00b001cd4989fecesm5761149pjb.26.2022.05.19.08.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 08:24:25 -0700 (PDT) Date: Thu, 19 May 2022 08:24:23 -0700 From: Matthias Kaehlcke To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , dianders@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v1 1/3] arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S Message-ID: References: <20220519084119.675990-1-judyhsiao@chromium.org> <20220519084119.675990-2-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220519084119.675990-2-judyhsiao@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 19, 2022 at 08:41:17AM +0000, Judy Hsiao wrote: > Subject: arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S > > Add drive strength property for secondary MI2S on sc7280 based platforms That's not an accurate description, this patch only adjust settings for herobrine based boards. This should be reflected at list in the subject. Besides setting the drive strengths this patch also disables the pulls on some lines, so maybe better say something like "arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1". > Signed-off-by: Judy Hsiao > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_ws { > + drive-strength = <6>; > +}; > + > &pcie1_clkreq_n { > bias-pull-up; > drive-strength = <2>; > -- > 2.36.1.124.g0e6072fb45-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76672C433EF for ; Thu, 19 May 2022 15:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6lRbZSW8hxBDNzQfAREqnlVH1Pu/XDbWwr5S94cyqKU=; b=xfwcp5NfMVupje equIIXGO/3+IWSEcHBylowvaFHIwlPiJr6sfNJFjlUG+EBlxNZ9/7rcQ8n7YNlsUhemSnGCyyRN6J qcWUAafbWiv4HCDnhY8TtJ0sR0bG+GDYRPq/1GTwH9nKabdy4FgsVQZ62Mae2iioPO8iQzlgXZraW AiEf+kBWB+AheUKP6n7potmHEzAT2D0KkFwhRPqA2gOZIHw+Y6HZYEyP+fpbv0aZLymiWOxNEKzcz WizBrG1InFaUrj1LehdH76j2ze3Q7gcXZH0i0aeCPBhhcJRXN1q+RTI4cIq+2SZhB4Z9KYTDXRMGo HC6q187hEddhb2hJweEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nri6e-007xgz-Jy; Thu, 19 May 2022 15:30:29 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nri0t-007uja-D6 for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 15:24:33 +0000 Received: by mail-pf1-x42e.google.com with SMTP id c14so5461954pfn.2 for ; Thu, 19 May 2022 08:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RxxDW43556pg8Ua5FCLecPALXbP2iIESOPIMcw9n7sE=; b=dD66mv1j+KlBHvLn/Pnd3LT4IkaDHF185QUHOArIhQ3vq98mh9FVYd4M7G4sAVR6BO 2hjja+BFzPr53FRFkDuOrDIBIE9+tEC7d7kPat/DprLa38AMrc7KSFg4y8ieiLtjRXci YBAv8+zvh67gdCTv8jasxHfsFmUuEUi6IZxmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RxxDW43556pg8Ua5FCLecPALXbP2iIESOPIMcw9n7sE=; b=mfcMMsocLrGwAMiRFMuKEsscPC90HyHzUaKj+9LAdcKrFjALZkbSO26RZxBJfI+MZK PqWDDpG2mI9eJ9GQHcujEJ/5A0Wzca32Lbjp4RlKhHN353S0zkFHKxP5sED/MMKqqLyb WUzHyW8hvx7hr8rc8SNu4slBMmJLbUvRuTL1Rk7ck0W9UYgeK7z0mMmP99URPmokZ392 4utM37dfcqI/lpo3/Erdci3LGiwhUrqjPjFmJVD2gobGCFfkBp+2OCOA2H/swPvkk87E JIKVX0i1IK7ODPiIUtdzpATnuqUT+u6n6cnajz7nYj/RH9erP9tU88DChMpItG5JlRKz 2m3A== X-Gm-Message-State: AOAM530aSj0ufC7A052aUAf7fDdwUuEszRVMMqLGH8Juld/mCLFziD6N oFYjvyoGz575LKnX1OZKWHRI9mS3fpQgLA== X-Google-Smtp-Source: ABdhPJxWH5HSd2a6kok2fOfyjwjkJ1jaC6v18twZR2TofpZX4x8hZTHdx9Okw9/W96CBOGNO3cnUYA== X-Received: by 2002:a05:6a02:19c:b0:3aa:1bf8:7388 with SMTP id bj28-20020a056a02019c00b003aa1bf87388mr4409154pgb.455.1652973865333; Thu, 19 May 2022 08:24:25 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:e229:79ea:227e:d9dd]) by smtp.gmail.com with UTF8SMTPSA id er14-20020a17090af6ce00b001cd4989fecesm5761149pjb.26.2022.05.19.08.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 08:24:25 -0700 (PDT) Date: Thu, 19 May 2022 08:24:23 -0700 From: Matthias Kaehlcke To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , dianders@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v1 1/3] arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S Message-ID: References: <20220519084119.675990-1-judyhsiao@chromium.org> <20220519084119.675990-2-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220519084119.675990-2-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220519_082431_482843_BC31B09A X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 19, 2022 at 08:41:17AM +0000, Judy Hsiao wrote: > Subject: arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S > > Add drive strength property for secondary MI2S on sc7280 based platforms That's not an accurate description, this patch only adjust settings for herobrine based boards. This should be reflected at list in the subject. Besides setting the drive strengths this patch also disables the pulls on some lines, so maybe better say something like "arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1". > Signed-off-by: Judy Hsiao > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; > +}; > + > +&mi2s1_ws { > + drive-strength = <6>; > +}; > + > &pcie1_clkreq_n { > bias-pull-up; > drive-strength = <2>; > -- > 2.36.1.124.g0e6072fb45-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel