From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0BA928EE
	for <linux-staging@lists.linux.dev>; Thu, 19 May 2022 15:36:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14AE3C385AA;
	Thu, 19 May 2022 15:36:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1652974576;
	bh=vy65R7ZsafQHBZhnUCG7N55ApplrExwQMDdxSADZFsY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=O8dSUKFhLphktISiz+w4ZJn6xy/hfqwJNaRmdcCUXG1am2Eil/+f5wWFncdR0ijyd
	 55GfQtwDqtuXBtxGvdQMMeke7S/aV0g507bIXavDu3hbAa+fZZ5//lR9Qd/mc8ZkLW
	 0CtyS6rCZ5RKtfcgyAZl+Cit03FgRUKgHToBPUOg=
Date: Thu, 19 May 2022 17:36:13 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Srivathsan Sivakumar <sri.skumar05@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: spi.c: prefer ftrace
Message-ID: <YoZj7RS+awq/bC2R@kroah.com>
References: <YoP3S6mGQEwUTQDC@Sassy>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YoP3S6mGQEwUTQDC@Sassy>

On Tue, May 17, 2022 at 03:28:11PM -0400, Srivathsan Sivakumar wrote:
> fix the following checkpatch.pl warning:
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Srivathsan Sivakumar <sri.skumar05@gmail.com>
> ---
>  drivers/staging/rts5208/spi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
> index f1e9e80044ed..0d2d065508d3 100644
> --- a/drivers/staging/rts5208/spi.c
> +++ b/drivers/staging/rts5208/spi.c
> @@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
>  	spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
>  	spi->write_en = srb->cmnd[6];
>  
> -	dev_dbg(rtsx_dev(chip), "%s: ", __func__);
>  	dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
>  	dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
>  	dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);

All three of the remaining ones should be on one line, right?

Can you fix this up and do that all at once?


thanks,

greg k-h