From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4634C433EF for ; Thu, 19 May 2022 15:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241767AbiESPtW (ORCPT ); Thu, 19 May 2022 11:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241642AbiESPtN (ORCPT ); Thu, 19 May 2022 11:49:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5CD108A83; Thu, 19 May 2022 08:45:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEBDF61BE0; Thu, 19 May 2022 15:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C921EC385AA; Thu, 19 May 2022 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652975134; bh=grMrez5z/qqSwQfDRZjfSNqC7wVFEopD1oJJWSiFoLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jrk0HJqiDHGsWZNXPq68+mIaObqaevRudF9yM+wIPbrZ967oq1V/YgY1OopBbe2GL Hu5bwu2Ue/AV2h3DJuSxElAYPYVqaOKx49MzyHwMNCvAVDV8QgBGXsob+KRyapthIn OKzOQ2/3INec1Nf6Txp/YOn9ek493BKfBSCPslwk= Date: Thu, 19 May 2022 17:45:31 +0200 From: Greg KH To: Denis Efremov Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, dan.carpenter@oracle.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, stable Subject: Re: [PATCH] staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan() Message-ID: References: <20220518070052.108287-1-denis.e.efremov@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518070052.108287-1-denis.e.efremov@oracle.com> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Wed, May 18, 2022 at 11:00:52AM +0400, Denis Efremov wrote: > This code has a check to prevent read overflow but it needs another > check to prevent writing beyond the end of the ->Ssid[] array. > > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver") > Cc: stable > Signed-off-by: Denis Efremov > --- > > This patch is a copy of Dan's 74b6b20df8cf (CVE-2021-28660). > Drivers r8188eu and rtl8188eu share the same code. This does not apply to my tree at all. This file is not present anymore, what tree did you make it against? confused, greg k-h