From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46559C433F5 for ; Thu, 19 May 2022 16:43:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55E3C10E9FB; Thu, 19 May 2022 16:43:57 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7583911A321 for ; Thu, 19 May 2022 16:43:56 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id n8so5309438plh.1 for ; Thu, 19 May 2022 09:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=221Yw0kf0kWHOuKCBmfC/ycEQMuPJsFgC9zSqVTAwSA=; b=bu8vQ+GWvqJrRdEuq8YVrsfud1b3bQhlBNIuRQm9N4t2Lj3E7ojrr5du8GpLJyVQpt zI6LAgP0cWVNyhkC2dx8jWx3d1dzS6qKn2apfQz90gm0zn8LV2J6jLUuu+darR0d5jp1 LpTWI9ig8g7I0oCfkW8terjt+U3QuRwraIIgfyUbQlX7hnu3WzrJLPVhPL16qrotB7X8 X0sGHQiLnxPwCuwzmOoubt1yCoAYcRgt5bbtFh+Kh0gFthhZS04NdGml6wCRoLPw4YTT 8exX0VVLnNWqt0NnU9LMNUK3s3E1Z3IQqSxPNndBTJ1hO64zu+VRfQofIL4ohxv4FNRK FrmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=221Yw0kf0kWHOuKCBmfC/ycEQMuPJsFgC9zSqVTAwSA=; b=A2toaBnXs0vRvoEwgntCeQK+T7rqg+OR0NKx2lHc5gBSCUjN6sg0BzQUs+MjPogkh8 2/BKLmgcbMu5fYQ97KbRL+gP2cFZA2tCqCvufOMOVWJxNz5KC2tvIT4JVZOwY0wVwccw vEE07SQEwJ/8HbwWQB9gd/ALF+d+xdJvTOpFpNypmfQ+Lfxxu/4INRurs03sort+Qg8d VEWmoA2SDLjrN6j2bfyLMQcbH7zBF/LfYPG4jgbfGoccrhCPfJGZowe8SQhCn3PDsmUR Gfe+7C3OHQ8wXWQ69H/4Kmgk1bDwXuzNlorA7Vr9l2wnWG7lPKvtbCNKstaiHGruORWj c4yg== X-Gm-Message-State: AOAM531ScT8okQOyygJveIRX+9TqLAqNdzKcbkbMTiU9rSYzQF9N2TsE cyQsvy9cNiY2lMX+NsQzT5RT8Q== X-Google-Smtp-Source: ABdhPJw2CROjZjF/tfI3pH/231wqbGMtrzoTlXEZCDadRe7+Y7fJupSq7bjozl06CSrvxLG1Gs7+EA== X-Received: by 2002:a17:902:b289:b0:161:872d:6f03 with SMTP id u9-20020a170902b28900b00161872d6f03mr5698065plr.30.1652978635790; Thu, 19 May 2022 09:43:55 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id jh9-20020a170903328900b0015e8d4eb1f8sm4027559plb.66.2022.05.19.09.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 09:43:55 -0700 (PDT) Date: Thu, 19 May 2022 16:43:51 +0000 From: Sean Christopherson To: Maxim Levitsky Subject: Re: [RFC PATCH v3 06/19] KVM: x86: mmu: add gfn_in_memslot helper Message-ID: References: <20220427200314.276673-1-mlevitsk@redhat.com> <20220427200314.276673-7-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427200314.276673-7-mlevitsk@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Airlie , Dave Hansen , dri-devel@lists.freedesktop.org, "H. Peter Anvin" , Brijesh Singh , Joerg Roedel , x86@kernel.org, Ingo Molnar , Zhi Wang , Tom Lendacky , intel-gfx@lists.freedesktop.org, Borislav Petkov , Rodrigo Vivi , Thomas Gleixner , intel-gvt-dev@lists.freedesktop.org, Jim Mattson , Tvrtko Ursulin , linux-kernel@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 27, 2022, Maxim Levitsky wrote: > This is a tiny refactoring, and can be useful to check > if a GPA/GFN is within a memslot a bit more cleanly. This doesn't explain the actual motivation, which is to use the new helper from arch code. > Signed-off-by: Maxim Levitsky > --- > include/linux/kvm_host.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 252ee4a61b58b..12e261559070b 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1580,6 +1580,13 @@ int kvm_request_irq_source_id(struct kvm *kvm); > void kvm_free_irq_source_id(struct kvm *kvm, int irq_source_id); > bool kvm_arch_irqfd_allowed(struct kvm *kvm, struct kvm_irqfd *args); > > + > +static inline bool gfn_in_memslot(struct kvm_memory_slot *slot, gfn_t gfn) > +{ > + return (gfn >= slot->base_gfn && gfn < slot->base_gfn + slot->npages); > +} > + Spurious newline. > + > /* > * Returns a pointer to the memslot if it contains gfn. > * Otherwise returns NULL. > @@ -1590,12 +1597,13 @@ try_get_memslot(struct kvm_memory_slot *slot, gfn_t gfn) > if (!slot) > return NULL; > > - if (gfn >= slot->base_gfn && gfn < slot->base_gfn + slot->npages) > + if (gfn_in_memslot(slot, gfn)) > return slot; > else > return NULL; At this point, maybe: if (!slot || !gfn_in_memslot(slot, gfn)) return NULL; return slot; > } > > + > /* > * Returns a pointer to the memslot that contains gfn. Otherwise returns NULL. > * > -- > 2.26.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B7CC433EF for ; Thu, 19 May 2022 16:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbiESQoC (ORCPT ); Thu, 19 May 2022 12:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbiESQn5 (ORCPT ); Thu, 19 May 2022 12:43:57 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ABE15AEC9 for ; Thu, 19 May 2022 09:43:56 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id m12so5300691plb.4 for ; Thu, 19 May 2022 09:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=221Yw0kf0kWHOuKCBmfC/ycEQMuPJsFgC9zSqVTAwSA=; b=bu8vQ+GWvqJrRdEuq8YVrsfud1b3bQhlBNIuRQm9N4t2Lj3E7ojrr5du8GpLJyVQpt zI6LAgP0cWVNyhkC2dx8jWx3d1dzS6qKn2apfQz90gm0zn8LV2J6jLUuu+darR0d5jp1 LpTWI9ig8g7I0oCfkW8terjt+U3QuRwraIIgfyUbQlX7hnu3WzrJLPVhPL16qrotB7X8 X0sGHQiLnxPwCuwzmOoubt1yCoAYcRgt5bbtFh+Kh0gFthhZS04NdGml6wCRoLPw4YTT 8exX0VVLnNWqt0NnU9LMNUK3s3E1Z3IQqSxPNndBTJ1hO64zu+VRfQofIL4ohxv4FNRK FrmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=221Yw0kf0kWHOuKCBmfC/ycEQMuPJsFgC9zSqVTAwSA=; b=VOyIO+t0zNgGBFqMwYIiAV941b6flxwHdn+ZSwfmWcJxs7Qzbq2JyeIO1Duv8QaHm+ 8pvMAOdGNqofPrZh5APVBadiYZddh8ovN07OG2dKGzcD4euVejvFTI6vOIZU2w288dau aqVLYURz5x0YwThxEAbzl88DP22ySbbW7HNlGy+620poZ9oZ/n2TKkkoc4PZxuu3zVFy Q7mZ9CbfnX4Azpxoti8mk3XnSa3MYH5dMNtx1vjYfSPtDIZaTo8KXf5Edrczp73LqT4v 5zHqSGNK+HAb+tJteDURVWHIT3UYBozgzkNjYuOoebZW3gM9tYdHd31iknJFtZBouNRo Ti8A== X-Gm-Message-State: AOAM531fd70nauXIN3+9EkBo6L1EcoX3gviC45lGasbG61v/A96Ej9s7 VVnP4GDGNVE0bB4idjwt0Dlg1XxLyangVw== X-Google-Smtp-Source: ABdhPJw2CROjZjF/tfI3pH/231wqbGMtrzoTlXEZCDadRe7+Y7fJupSq7bjozl06CSrvxLG1Gs7+EA== X-Received: by 2002:a17:902:b289:b0:161:872d:6f03 with SMTP id u9-20020a170902b28900b00161872d6f03mr5698065plr.30.1652978635790; Thu, 19 May 2022 09:43:55 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id jh9-20020a170903328900b0015e8d4eb1f8sm4027559plb.66.2022.05.19.09.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 09:43:55 -0700 (PDT) Date: Thu, 19 May 2022 16:43:51 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Wanpeng Li , Vitaly Kuznetsov , Jani Nikula , Paolo Bonzini , Tvrtko Ursulin , Rodrigo Vivi , Zhenyu Wang , Joonas Lahtinen , Tom Lendacky , Ingo Molnar , David Airlie , Thomas Gleixner , Dave Hansen , x86@kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , Borislav Petkov , Joerg Roedel , linux-kernel@vger.kernel.org, Jim Mattson , Zhi Wang , Brijesh Singh , "H. Peter Anvin" , intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC PATCH v3 06/19] KVM: x86: mmu: add gfn_in_memslot helper Message-ID: References: <20220427200314.276673-1-mlevitsk@redhat.com> <20220427200314.276673-7-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427200314.276673-7-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Apr 27, 2022, Maxim Levitsky wrote: > This is a tiny refactoring, and can be useful to check > if a GPA/GFN is within a memslot a bit more cleanly. This doesn't explain the actual motivation, which is to use the new helper from arch code. > Signed-off-by: Maxim Levitsky > --- > include/linux/kvm_host.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 252ee4a61b58b..12e261559070b 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1580,6 +1580,13 @@ int kvm_request_irq_source_id(struct kvm *kvm); > void kvm_free_irq_source_id(struct kvm *kvm, int irq_source_id); > bool kvm_arch_irqfd_allowed(struct kvm *kvm, struct kvm_irqfd *args); > > + > +static inline bool gfn_in_memslot(struct kvm_memory_slot *slot, gfn_t gfn) > +{ > + return (gfn >= slot->base_gfn && gfn < slot->base_gfn + slot->npages); > +} > + Spurious newline. > + > /* > * Returns a pointer to the memslot if it contains gfn. > * Otherwise returns NULL. > @@ -1590,12 +1597,13 @@ try_get_memslot(struct kvm_memory_slot *slot, gfn_t gfn) > if (!slot) > return NULL; > > - if (gfn >= slot->base_gfn && gfn < slot->base_gfn + slot->npages) > + if (gfn_in_memslot(slot, gfn)) > return slot; > else > return NULL; At this point, maybe: if (!slot || !gfn_in_memslot(slot, gfn)) return NULL; return slot; > } > > + > /* > * Returns a pointer to the memslot that contains gfn. Otherwise returns NULL. > * > -- > 2.26.3 >