Re: [PATCH v2 07/28] lib/printbuf: Unit specifiers

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, May 19, 2022 at 01:24:00PM -0400, Kent Overstreet wrote:
> This adds options to printbuf for specifying whether units should be
> printed raw (default) or with human readable units, and for controlling
> whether human-readable units should be base 2 (default), or base 10.
> 
> This also adds new helpers that obey these options:
> 
>  - pr_human_readable_u64
>  - pr_human_readable_s64
> These obey printbuf->si_units
> 
>  - pr_units_u64
>  - pr_units_s64
> These obey both printbuf-human_readable_units and printbuf->si_units

...

> +void pr_human_readable_s64(struct printbuf *buf, s64 v)
> +{
> +	if (v < 0)
> +		pr_char(buf, '-');
> +	pr_human_readable_u64(buf, abs(v));

Wouldn't -v work?

> +}

...

> + * pr_human_readable_u64 - Print out a u64 according to printbuf unit options

Have you ever compile this? We have kernel doc validator running when compiling
the code...

> + * Units are either raw (default), or human reabable units (controlled via
> + * @buf->human_readable_units)
> + */
> +void pr_units_u64(struct printbuf *out, u64 v)
> +{
> +	if (out->human_readable_units)
> +		pr_human_readable_u64(out, v);
> +	else
> +		pr_buf(out, "%llu", v);
> +}
> +EXPORT_SYMBOL(pr_units_u64);
> +
> +/**
> + * pr_human_readable_s64 - Print out a s64 according to printbuf unit options

Ditto.

> + * Units are either raw (default), or human reabable units (controlled via
> + * @buf->human_readable_units)
> + */
> +void pr_units_s64(struct printbuf *out, s64 v)
> +{
> +	if (v < 0)
> +		pr_char(out, '-');
> +	pr_units_u64(out, v);

Please, start with test cases.

> +}

-- 
With Best Regards,
Andy Shevchenko