From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Florian Westphal <fw@strlen.de>,
Oliver Smith <osmith@sysmocom.de>,
netdev@vger.kernel.org, Harald Welte <laforge@gnumonks.org>
Subject: Re: regression: 'ctnetlink_dump_one_entry' defined but not used
Date: Thu, 19 May 2022 22:31:11 +0200 [thread overview]
Message-ID: <YoapDx2ZIBlXs3nr@salvia> (raw)
In-Reply-To: <20220519131341.36c8b24e@kernel.org>
On Thu, May 19, 2022 at 01:13:41PM -0700, Jakub Kicinski wrote:
> On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> > Oliver Smith <osmith@sysmocom.de> wrote:
> > > Hi Florian,
> > >
> > > since May 17 we see some automatic builds against net-next.git fail with:
> > >
> > > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > > > 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > Looks like this is a regression from your patch 8a75a2c17, I guess
> > > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
> >
> > Its fixed in nf-next.
>
> Let's get it out to net-next, please, I'm carrying this patch locally
> as well :(
I'll prepare a pull request asap.
prev parent reply other threads:[~2022-05-19 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 9:06 regression: 'ctnetlink_dump_one_entry' defined but not used Oliver Smith
2022-05-19 10:21 ` Florian Westphal
2022-05-19 20:13 ` Jakub Kicinski
2022-05-19 20:31 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoapDx2ZIBlXs3nr@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=osmith@sysmocom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.