From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] random: convert to using fops->write_iter()
Date: Fri, 20 May 2022 02:18:04 +0200 [thread overview]
Message-ID: <YobePA1M0htNbTRN@zx2c4.com> (raw)
In-Reply-To: <f871a510-d262-bc98-757e-204976e1b82c@kernel.dk>
Hi Jens,
On Thu, May 19, 2022 at 05:43:15PM -0600, Jens Axboe wrote:
> + while (iov_iter_count(iter)) {
> + block_len = min(iov_iter_count(iter), sizeof(block));
Whereas get_random_bytes_user() used a separate len param, it looks like
this function is using iov's len. Maybe that's not such a bad idea? I'll
give a shot at fixing that up in both places, and you can tell me what
you think.
Jason
next prev parent reply other threads:[~2022-05-20 0:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 23:43 [PATCH] random: convert to using fops->write_iter() Jens Axboe
2022-05-19 23:52 ` Jens Axboe
2022-05-20 0:08 ` Jason A. Donenfeld
2022-05-20 0:32 ` Jens Axboe
2022-05-20 0:18 ` Jason A. Donenfeld [this message]
2022-05-20 0:32 ` Jens Axboe
2022-05-20 3:01 ` Al Viro
2022-05-20 3:25 ` Jens Axboe
2022-05-20 3:31 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YobePA1M0htNbTRN@zx2c4.com \
--to=jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.