From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Date: Fri, 20 May 2022 07:33:46 +0000 Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-Id: List-Id: References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> In-Reply-To: <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > > For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > ptrace_freeze_traced has completed successfully. Which fundamentally > means the lock dance of dropping siglock and grabbing tasklist_lock does > not work on PREEMPT_RT. So I have worked through what is necessary so > that tasklist_lock does not need to be grabbed in ptrace_stop after > siglock is dropped. … It took me a while to realise that this is a follow-up I somehow assumed that you added a few patches on top. Might have been the yesterday's heat. b4 also refused to download this series because the v4 in this thread looked newer… Anyway. Both series applied: | ============================= | WARNING: suspicious RCU usage | 5.18.0-rc7+ #16 Not tainted | ----------------------------- | include/linux/ptrace.h:120 suspicious rcu_dereference_check() usage! | | other info that might help us debug this: | | rcu_scheduler_active = 2, debug_locks = 1 | 2 locks held by ssdd/1734: | #0: ffff88800eaa6918 (&sighand->siglock){....}-{2:2}, at: lock_parents_siglocks+0xf0/0x3b0 | #1: ffff88800eaa71d8 (&sighand->siglock/2){....}-{2:2}, at: lock_parents_siglocks+0x115/0x3b0 | | stack backtrace: | CPU: 2 PID: 1734 Comm: ssdd Not tainted 5.18.0-rc7+ #16 | Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 | Call Trace: | | dump_stack_lvl+0x45/0x5a | unlock_parents_siglocks+0xb6/0xc0 | ptrace_stop+0xb9/0x390 | get_signal+0x51c/0x8d0 | arch_do_signal_or_restart+0x31/0x750 | exit_to_user_mode_prepare+0x157/0x220 | irqentry_exit_to_user_mode+0x5/0x50 | asm_sysvec_apic_timer_interrupt+0x12/0x20 That is ptrace_parent() in unlock_parents_siglocks(). Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59139C433F5 for ; Fri, 20 May 2022 07:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345912AbiETHdx (ORCPT ); Fri, 20 May 2022 03:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235940AbiETHdw (ORCPT ); Fri, 20 May 2022 03:33:52 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFE4914AC97; Fri, 20 May 2022 00:33:50 -0700 (PDT) Date: Fri, 20 May 2022 09:33:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1653032028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WO3Qag7yVyo0GFmwDFCkyWbSVTR+kGU+HMvb/D9bjOo=; b=h4dL5j62evAr9rItV/vck1C6kA0EcttM1m0b1Da0ljJr4V7XdOnxfSv+mWxSutuS2anLKN neSSgNQkpP53eeKBE5CT48hYBJKpeL2q5GmrRpUfJSrhbbAgR96xaZFLm2m9HyNl2hpRjT p4R0TUJObBZ8LuvElhNTARZVzJSH+sfB8hS+wPzXOg5CKr62geGJqavEKMI2R0SUtV5/8r jm0hy5BI7tr3GfOMHLvYq1VeO3ehLaTFzPsyd262aPCmYuf6k1919aqHhR+iCvZFAB5r9g WDP5zU50AT8WP6hpkDrViT7FZkOgF4nok3fWjosNMDT8fokR0m0ESQUltn3zng== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1653032028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WO3Qag7yVyo0GFmwDFCkyWbSVTR+kGU+HMvb/D9bjOo=; b=4tb6POwNJbbl9CtNBPZJfUGQvl1P67iM9z/Z0O1ewVgldWrTMWuavKsCaXBCXYv5PsOEiU eksDJVhVX6WxZDDw== From: Sebastian Andrzej Siewior To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-ID: References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: >=20 > For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > ptrace_freeze_traced has completed successfully. Which fundamentally > means the lock dance of dropping siglock and grabbing tasklist_lock does > not work on PREEMPT_RT. So I have worked through what is necessary so > that tasklist_lock does not need to be grabbed in ptrace_stop after > siglock is dropped. =E2=80=A6 It took me a while to realise that this is a follow-up I somehow assumed that you added a few patches on top. Might have been the yesterday's heat. b4 also refused to download this series because the v4 in this thread looked newer=E2=80=A6 Anyway. Both series applied: | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D | WARNING: suspicious RCU usage | 5.18.0-rc7+ #16 Not tainted | ----------------------------- | include/linux/ptrace.h:120 suspicious rcu_dereference_check() usage! | | other info that might help us debug this: | | rcu_scheduler_active =3D 2, debug_locks =3D 1 | 2 locks held by ssdd/1734: | #0: ffff88800eaa6918 (&sighand->siglock){....}-{2:2}, at: lock_parents_s= iglocks+0xf0/0x3b0 | #1: ffff88800eaa71d8 (&sighand->siglock/2){....}-{2:2}, at: lock_parents= _siglocks+0x115/0x3b0 | | stack backtrace: | CPU: 2 PID: 1734 Comm: ssdd Not tainted 5.18.0-rc7+ #16 | Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.= 16.0-4 04/01/2014 | Call Trace: | | dump_stack_lvl+0x45/0x5a | unlock_parents_siglocks+0xb6/0xc0 | ptrace_stop+0xb9/0x390 | get_signal+0x51c/0x8d0 | arch_do_signal_or_restart+0x31/0x750 | exit_to_user_mode_prepare+0x157/0x220 | irqentry_exit_to_user_mode+0x5/0x50 | asm_sysvec_apic_timer_interrupt+0x12/0x20 That is ptrace_parent() in unlock_parents_siglocks(). Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrx96-00B5qc-7Q for linux-um@lists.infradead.org; Fri, 20 May 2022 07:34:02 +0000 Date: Fri, 20 May 2022 09:33:46 +0200 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Message-ID: References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Jann Horn , Kees Cook , linux-ia64@vger.kernel.org, Robert O'Callahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras T24gMjAyMi0wNS0xOCAxNzo0OTo1MCBbLTA1MDBdLCBFcmljIFcuIEJpZWRlcm1hbiB3cm90ZToK PiAKPiBGb3IgcHRyYWNlX3N0b3AgdG8gd29yayBvbiBQUkVFTVRfUlQgbm8gc3BpbmxvY2tzIGNh biBiZSB0YWtlbiBvbmNlCj4gcHRyYWNlX2ZyZWV6ZV90cmFjZWQgaGFzIGNvbXBsZXRlZCBzdWNj ZXNzZnVsbHkuICBXaGljaCBmdW5kYW1lbnRhbGx5Cj4gbWVhbnMgdGhlIGxvY2sgZGFuY2Ugb2Yg ZHJvcHBpbmcgc2lnbG9jayBhbmQgZ3JhYmJpbmcgdGFza2xpc3RfbG9jayBkb2VzCj4gbm90IHdv cmsgb24gUFJFRU1QVF9SVC4gIFNvIEkgaGF2ZSB3b3JrZWQgdGhyb3VnaCB3aGF0IGlzIG5lY2Vz c2FyeSBzbwo+IHRoYXQgdGFza2xpc3RfbG9jayBkb2VzIG5vdCBuZWVkIHRvIGJlIGdyYWJiZWQg aW4gcHRyYWNlX3N0b3AgYWZ0ZXIKPiBzaWdsb2NrIGlzIGRyb3BwZWQuCuKApgpJdCB0b29rIG1l IGEgd2hpbGUgdG8gcmVhbGlzZSB0aGF0IHRoaXMgaXMgYSBmb2xsb3ctdXAgSSBzb21laG93IGFz c3VtZWQKdGhhdCB5b3UgYWRkZWQgYSBmZXcgcGF0Y2hlcyBvbiB0b3AuIE1pZ2h0IGhhdmUgYmVl biB0aGUgeWVzdGVyZGF5J3MKaGVhdC4gYjQgYWxzbyByZWZ1c2VkIHRvIGRvd25sb2FkIHRoaXMg c2VyaWVzIGJlY2F1c2UgdGhlIHY0IGluIHRoaXMKdGhyZWFkIGxvb2tlZCBuZXdlcuKApiBBbnl3 YXkuIEJvdGggc2VyaWVzIGFwcGxpZWQ6Cgp8ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 CnwgV0FSTklORzogc3VzcGljaW91cyBSQ1UgdXNhZ2UKfCA1LjE4LjAtcmM3KyAjMTYgTm90IHRh aW50ZWQKfCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQp8IGluY2x1ZGUvbGludXgvcHRy YWNlLmg6MTIwIHN1c3BpY2lvdXMgcmN1X2RlcmVmZXJlbmNlX2NoZWNrKCkgdXNhZ2UhCnwKfCBv dGhlciBpbmZvIHRoYXQgbWlnaHQgaGVscCB1cyBkZWJ1ZyB0aGlzOgp8CnwgcmN1X3NjaGVkdWxl cl9hY3RpdmUgPSAyLCBkZWJ1Z19sb2NrcyA9IDEKfCAyIGxvY2tzIGhlbGQgYnkgc3NkZC8xNzM0 Ogp8ICAjMDogZmZmZjg4ODAwZWFhNjkxOCAoJnNpZ2hhbmQtPnNpZ2xvY2spey4uLi59LXsyOjJ9 LCBhdDogbG9ja19wYXJlbnRzX3NpZ2xvY2tzKzB4ZjAvMHgzYjAKfCAgIzE6IGZmZmY4ODgwMGVh YTcxZDggKCZzaWdoYW5kLT5zaWdsb2NrLzIpey4uLi59LXsyOjJ9LCBhdDogbG9ja19wYXJlbnRz X3NpZ2xvY2tzKzB4MTE1LzB4M2IwCnwKfCBzdGFjayBiYWNrdHJhY2U6CnwgQ1BVOiAyIFBJRDog MTczNCBDb21tOiBzc2RkIE5vdCB0YWludGVkIDUuMTguMC1yYzcrICMxNgp8IEhhcmR3YXJlIG5h bWU6IFFFTVUgU3RhbmRhcmQgUEMgKFEzNSArIElDSDksIDIwMDkpLCBCSU9TIDEuMTYuMC1kZWJp YW4tMS4xNi4wLTQgMDQvMDEvMjAxNAp8IENhbGwgVHJhY2U6CnwgIDxUQVNLPgp8ICBkdW1wX3N0 YWNrX2x2bCsweDQ1LzB4NWEKfCAgdW5sb2NrX3BhcmVudHNfc2lnbG9ja3MrMHhiNi8weGMwCnwg IHB0cmFjZV9zdG9wKzB4YjkvMHgzOTAKfCAgZ2V0X3NpZ25hbCsweDUxYy8weDhkMAp8ICBhcmNo X2RvX3NpZ25hbF9vcl9yZXN0YXJ0KzB4MzEvMHg3NTAKfCAgZXhpdF90b191c2VyX21vZGVfcHJl cGFyZSsweDE1Ny8weDIyMAp8ICBpcnFlbnRyeV9leGl0X3RvX3VzZXJfbW9kZSsweDUvMHg1MAp8 ICBhc21fc3lzdmVjX2FwaWNfdGltZXJfaW50ZXJydXB0KzB4MTIvMHgyMAoKVGhhdCBpcyBwdHJh Y2VfcGFyZW50KCkgaW4gdW5sb2NrX3BhcmVudHNfc2lnbG9ja3MoKS4KClNlYmFzdGlhbgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFp bGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=