From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F35C27E for ; Fri, 20 May 2022 08:16:04 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id s28so10290810wrb.7 for ; Fri, 20 May 2022 01:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=sgVdkj+m0vdYfC42vgmnXcgErywSFim9EldJP/IRKb8=; b=UbCjQtGRYjLqlisKKVYQpJgMYj/br9KZw6pGqNIRnL84QxknHPwih4CK9F5I2S/7Ki IiOelDJRDtgCgP298udFAK1aWzVaCZ7RT4ZahHcBGmee5L74RImyWtVZcWbHwwmS31Vb KRCORvITE+zT6KppLMaGOMhi7pFikUYxpIb3NGlyYZ0qLcnYIJ2GAP6R1lpgYwgMX/LB 7IHc+a+uWC+czjVbCL9a0shS9FDqRkGALziE0pfwdtD6S7qevDZOKUIRXJ9/Z+5O3bhU bak0XChjaPwOdMDWTkYPt7rKc16wH1TAgCSMNsAijtXjymRrf4RfcKq5SOzqu8iL3ZW/ z1bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=sgVdkj+m0vdYfC42vgmnXcgErywSFim9EldJP/IRKb8=; b=hMpiGsPXWw/cFBsXN8cBXNSgbSzG4db5CccQCbgxGagbzBC22R5UqkGOCdJql1JVp2 /gBJUiOb1neFgfUkqTC0KCxszqTNET8dhqTwgNkoQVdXBtVa6wBNBMRZGwBAvkX+BuLh d0wjAyM0pHaYkQGb/UFv2S1kfy4iVkuvTQKqsjTeuMQHskE++MLQVny8AQIwDWVHx4CG jyZ72dHtBbef2IWmwvivDtnsToH2XWrhmb0pLCepkjnDv3vWO/3S7NYiDqqPrfxz7BJo ZufMBJRf/u/rKeRZYTexLBScI5f7ipryAocM3FvXk0Zo9sketS9NqX1WsdoE+zlxKJNO EhVA== X-Gm-Message-State: AOAM533ATXDSZeKS4/gt2tp+gl62ci/AcFSsfj0SEWq5LdnXiKcSkfjz +7vtMe2tH3k0+ClAgc7nIsJoTQ== X-Google-Smtp-Source: ABdhPJyJit3hnS/YjTniZmJ2kknMK6SoFyfAJ/HlzlsgZ7pfH0IL0m/0hSt8/6YePAJ85te1SjUyuQ== X-Received: by 2002:a5d:598b:0:b0:20e:6288:8c6a with SMTP id n11-20020a5d598b000000b0020e62888c6amr7114554wri.531.1653034563061; Fri, 20 May 2022 01:16:03 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id l6-20020a05600c088600b00397335cf750sm1283305wmp.47.2022.05.20.01.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 01:16:02 -0700 (PDT) Date: Fri, 20 May 2022 10:15:55 +0200 From: LABBE Corentin To: Krzysztof Kozlowski Cc: Mark Brown , Andrew Lunn , calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Message-ID: References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> <0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org> Le Fri, May 20, 2022 at 09:57:26AM +0200, Krzysztof Kozlowski a écrit : > On 19/05/2022 17:49, Mark Brown wrote: > > On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote: > >> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote: > >>> On 19/05/2022 13:31, Mark Brown wrote: > >>>> On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote: > >>>>> On 18/05/2022 22:09, Corentin Labbe wrote: > > > >>>>>> + regulators: > >>>>>> + description: > >>>>>> + List of phandle to regulators needed for the PHY > > > >>>>> I don't understand that... is your PHY defining the regulators or using > >>>>> supplies? If it needs a regulator (as a supply), you need to document > >>>>> supplies, using existing bindings. > > > >>>> They're trying to have a generic driver which works with any random PHY > >>>> so the binding has no idea what supplies it might need. > > > >>> OK, that makes sense, but then question is why not using existing > >>> naming, so "supplies" and "supply-names"? > > > >> I'm not saying it is not possible, but in general, the names are not > >> interesting. All that is needed is that they are all on, or > >> potentially all off to save power on shutdown. We don't care how many > >> there are, or what order they are enabled. > > > > I think Krzysztof is referring to the name of the property rather than > > the contents of the -names property there. > > Yes, exactly. Existing pattern for single regulator supply is > "xxx-supply", so why this uses a bit different pattern instead of > something more consistent ("supplies" and "supply-names")? > I agree that supplies and supply-names are better. But in another answer Rob is against it, so if I understand well, we are stuck to use individual xxx-supply. I will try to create a new regulator_get_bulk_all() which scan all properties matching xxx-supply From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 620C3C433F5 for ; Fri, 20 May 2022 08:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tl1tC12IKr1n9Rm99qlP1RAIUUmLI+CyooJz43nA3dQ=; b=Yqwf/vcNhak15M 78oXoQ4iqbzU5sAf2GGMHrjotUUU9FrdvDqkkuSZz2RZ6x6kkflez0bbmeNNMiZX8EtrdSw3zwmA+ SQkhwde+Q2WDJ0U/fC1htFhJT7xfpbZUbjlhiOkbj1cI6FHzc3yIwlnUVhAkncbpE5v/1b7uJpsR2 wEU54EI0udrnTAVojub3gJujfGLrwT4IjSzF5bhVl1te3jPMk/lI7fcBTAhO8ru96Y+XzMVR4itju aZQTdJXX4AVweauwD2iA9jPi+mvVCilx9SwjqeH4lS5KysaqQ59Q1Wo0yjCdPyX5IO86UVsmaH6Y2 gG/KJYNP1UIZfavX4odQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrxo3-00BCcg-Hk; Fri, 20 May 2022 08:16:19 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrxnz-00BCYH-CS for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 08:16:16 +0000 Received: by mail-wr1-x431.google.com with SMTP id h14so10437515wrc.6 for ; Fri, 20 May 2022 01:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=sgVdkj+m0vdYfC42vgmnXcgErywSFim9EldJP/IRKb8=; b=UbCjQtGRYjLqlisKKVYQpJgMYj/br9KZw6pGqNIRnL84QxknHPwih4CK9F5I2S/7Ki IiOelDJRDtgCgP298udFAK1aWzVaCZ7RT4ZahHcBGmee5L74RImyWtVZcWbHwwmS31Vb KRCORvITE+zT6KppLMaGOMhi7pFikUYxpIb3NGlyYZ0qLcnYIJ2GAP6R1lpgYwgMX/LB 7IHc+a+uWC+czjVbCL9a0shS9FDqRkGALziE0pfwdtD6S7qevDZOKUIRXJ9/Z+5O3bhU bak0XChjaPwOdMDWTkYPt7rKc16wH1TAgCSMNsAijtXjymRrf4RfcKq5SOzqu8iL3ZW/ z1bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=sgVdkj+m0vdYfC42vgmnXcgErywSFim9EldJP/IRKb8=; b=jrRk9Nf3aIVZXaSj5XjnjbBIV1l+IFDm+gLHwhz/uh+8WikKJFc5BXfngxNAR5DWOm fyO+8WTGa74yqvkVvzvG9Yef4AYEyMcBCIvZcWnQ2Pjb/yIq5S+jQ8j688N7p3HhRU9n cBE/NVPiULmpG1KrbP5R9xQPUF7WlqsJVfCuaij3kRILwgDa5JZZH2+V0+xJGSDLT0j1 AlXazSnHvIHB18Up0ljRmDhZOJNTNqPZylxnlKIhSGrMEhws7Av5N0m1g0jlYozL94rG fb5wCjIkwbnjB115AU0UFT9TJLr9fLzRtcI5/XGCifcDWKgzYLW10YAUKLiPctH2HtyL E9Yg== X-Gm-Message-State: AOAM53025JIApfL8/VivOp8pyOekpUlCLFtbfO6Vv2Uuuhw6x7K+GCPc 2xu8QTEts0LrllkwRrTd+5wsEw== X-Google-Smtp-Source: ABdhPJyJit3hnS/YjTniZmJ2kknMK6SoFyfAJ/HlzlsgZ7pfH0IL0m/0hSt8/6YePAJ85te1SjUyuQ== X-Received: by 2002:a5d:598b:0:b0:20e:6288:8c6a with SMTP id n11-20020a5d598b000000b0020e62888c6amr7114554wri.531.1653034563061; Fri, 20 May 2022 01:16:03 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id l6-20020a05600c088600b00397335cf750sm1283305wmp.47.2022.05.20.01.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 01:16:02 -0700 (PDT) Date: Fri, 20 May 2022 10:15:55 +0200 From: LABBE Corentin To: Krzysztof Kozlowski Cc: Mark Brown , Andrew Lunn , calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Message-ID: References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> <0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_011615_450144_54421FFE X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Fri, May 20, 2022 at 09:57:26AM +0200, Krzysztof Kozlowski a =E9crit : > On 19/05/2022 17:49, Mark Brown wrote: > > On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote: > >> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote: > >>> On 19/05/2022 13:31, Mark Brown wrote: > >>>> On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote: > >>>>> On 18/05/2022 22:09, Corentin Labbe wrote: > > = > >>>>>> + regulators: > >>>>>> + description: > >>>>>> + List of phandle to regulators needed for the PHY > > = > >>>>> I don't understand that... is your PHY defining the regulators or u= sing > >>>>> supplies? If it needs a regulator (as a supply), you need to docume= nt > >>>>> supplies, using existing bindings. > > = > >>>> They're trying to have a generic driver which works with any random = PHY > >>>> so the binding has no idea what supplies it might need. > > = > >>> OK, that makes sense, but then question is why not using existing > >>> naming, so "supplies" and "supply-names"? > > = > >> I'm not saying it is not possible, but in general, the names are not > >> interesting. All that is needed is that they are all on, or > >> potentially all off to save power on shutdown. We don't care how many > >> there are, or what order they are enabled. > > = > > I think Krzysztof is referring to the name of the property rather than > > the contents of the -names property there. > = > Yes, exactly. Existing pattern for single regulator supply is > "xxx-supply", so why this uses a bit different pattern instead of > something more consistent ("supplies" and "supply-names")? > = I agree that supplies and supply-names are better. But in another answer Rob is against it, so if I understand well, we are st= uck to use individual xxx-supply. I will try to create a new regulator_get_bulk_all() which scan all properti= es matching xxx-supply _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel