From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] pty07: Resize console to the same size as before
Date: Fri, 20 May 2022 13:50:56 +0200 [thread overview]
Message-ID: <YoeAoLQ0Wfp7SOJb@pevik> (raw)
In-Reply-To: <e5fd3db9-d113-c3b0-82a6-58d45bb4a246@suse.cz>
> On 20. 05. 22 11:26, Cyril Hrubis wrote:
> > I guess that the actual size we pass to VT_RESIZEX does not matter when
> > we attempt to trigger the race.
> I've tested this on SLE-15SP1 GM kernel which is older than the fix and
> this version still triggers the crash. Technically we could even pass
> all zeroes which would simply leave all console parameters unchanged and
> it'd still work because the ioctl implementation sets a flag in the
> freed memory anyway. But that behavior might change in the future so
> I've decided to just set the rows and cols to the values queried from
> kernel.
+1. Merged this one, thank you!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-05-20 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:10 [LTP] [PATCH 1/2] pty07: Resize console to the same size as before Martin Doucha
2022-05-19 12:10 ` [LTP] [PATCH 2/2] pty04: Fix cleanup Martin Doucha
2022-05-20 9:01 ` Petr Vorel
2022-05-20 9:08 ` Martin Doucha
2022-05-20 9:13 ` Petr Vorel
2022-05-20 9:21 ` Cyril Hrubis
2022-05-20 11:30 ` Petr Vorel
2022-05-20 9:22 ` Cyril Hrubis
2022-05-20 11:55 ` Petr Vorel
2022-05-20 9:05 ` [LTP] [PATCH 1/2] pty07: Resize console to the same size as before Petr Vorel
2022-05-20 9:26 ` Cyril Hrubis
2022-05-20 9:33 ` Martin Doucha
2022-05-20 11:50 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoeAoLQ0Wfp7SOJb@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.