From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C943EC433EF for ; Fri, 20 May 2022 12:32:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243910AbiETMco (ORCPT ); Fri, 20 May 2022 08:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349270AbiETMcn (ORCPT ); Fri, 20 May 2022 08:32:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A771B1632B8; Fri, 20 May 2022 05:32:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51E84B82B41; Fri, 20 May 2022 12:32:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA2CBC385A9; Fri, 20 May 2022 12:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653049959; bh=fAEdgqMEdnQTAHFprj1rFAfr5TzMf8KKvVtECUecqXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NKH/tOGboM7ia5MkeSzgP/aTkCBmn3o/VjPvMBq+dAna0x3clRrkfu4PhYh2EDaB5 oTbyV8CzQzEnQ5kcsdZxJQUtioQsW7sJtEqLw6rZZjnhwYvsCxEo/fRbLwNdUbS8iw vVOwTMFjqbYpuzyJAAxcocjwY1kpNSw6aM43bn5wNeKn+KH0FfcPc86zSCBT5VFfk5 C5ExlE4iYTo9EjUcgWmWq1+tgdPzkJrsZoxalPtIZyr9rf1RL7Dp1+r0LDjfUhoIdu tTKGlyboaN9ZEN+JL5g2PaAZZvCle705v+OTQO7V5APs7WbrAoLo2r1lnp8HuLEdOP N6oly8pOMdz9Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 01E2A400B1; Fri, 20 May 2022 09:32:36 -0300 (-03) Date: Fri, 20 May 2022 09:32:36 -0300 From: Arnaldo Carvalho de Melo To: German Gomez Cc: James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, leo.yan@linaro.org, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/2] perf: arm64: Tools support for Dwarf unwinding through SVE functions Message-ID: References: <20220517102005.3022017-1-james.clark@arm.com> <995099d3-a170-69dc-d12e-c9b2e4753f35@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <995099d3-a170-69dc-d12e-c9b2e4753f35@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, May 20, 2022 at 12:46:24PM +0100, German Gomez escreveu: > > On 17/05/2022 15:58, Arnaldo Carvalho de Melo wrote: > > Em Tue, May 17, 2022 at 11:20:01AM +0100, James Clark escreveu: > >> Changes since v1: > >> > >> * Split patchset into kernel side and Perf tool changes > > Thanks, now I'll wait for the kernel side to be merged. > > > > - Arnaldo > > > > Hi, > > I think we also need to fix the below import (it's trying to import the > perf_regs.h from the kernel, not the tools/ dir). Sure, that is why it is important to do a: make -C tools/perf build-test before posting patches, as it will do, among other tests, a detached tarball test using: ⬢[acme@toolbox perf-urgent]$ make help | grep perf perf-tar-src-pkg - Build perf-5.18.0-rc7.tar source tarball perf-targz-src-pkg - Build perf-5.18.0-rc7.tar.gz source tarball perf-tarbz2-src-pkg - Build perf-5.18.0-rc7.tar.bz2 source tarball perf-tarxz-src-pkg - Build perf-5.18.0-rc7.tar.xz source tarball perf-tarzst-src-pkg - Build perf-5.18.0-rc7.tar.zst source tarball ⬢[acme@toolbox perf-urgent]$ That will pick just what is in tools/perf/MANIFEST and that doesn´t include the kernel headers, just what is in tools/ then building with this patchkit would fail. To recap: ⬢[acme@toolbox perf-urgent]$ make perf-tarxz-src-pkg TAR PERF_VERSION = 5.18.rc7.gc645054ef517 ⬢[acme@toolbox perf-urgent]$ ls -la perf-5.18.0-rc7.tar.xz -rw-r--r--. 1 acme acme 2364832 May 20 09:32 perf-5.18.0-rc7.tar.xz ⬢[acme@toolbox perf-urgent]$ tar tvf perf-5.18.0-rc7.tar.xz | tail -rw-rw-r-- root/root 7364 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/vdso.c -rw-rw-r-- root/root 639 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/vdso.h -rw-rw-r-- root/root 1793 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/zlib.c -rw-rw-r-- root/root 2672 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/zstd.c drwxrwxr-x root/root 0 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/ -rw-rw-r-- root/root 1091 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/Makefile.arch -rw-rw-r-- root/root 5905 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/Makefile.include -rw-rw-r-- root/root 5288 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/utilities.mak -rw-r--r-- acme/acme 41 2022-05-20 09:32 perf-5.18.0-rc7/HEAD -rw-r--r-- acme/acme 46 2022-05-20 09:32 perf-5.18.0-rc7/PERF-VERSION-FILE ⬢[acme@toolbox perf-urgent]$ - Arnaldo > diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c > index 15f60fd09424..014d82159656 100644 > --- a/tools/perf/util/libunwind/arm64.c > +++ b/tools/perf/util/libunwind/arm64.c > @@ -24,7 +24,7 @@ >  #include "unwind.h" >  #include "libunwind-aarch64.h" >  #define perf_event_arm_regs perf_event_arm64_regs > -#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h> > +#include <../../../arch/arm64/include/uapi/asm/perf_regs.h> >  #undef perf_event_arm_regs >  #include "../../arch/arm64/util/unwind-libunwind.c" > -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93A32C433F5 for ; Fri, 20 May 2022 12:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DDUUC9JIQlSFoK7V2dMfnRlsXi6klsKYCfV4kirr4ek=; b=BMkuU+s64NWad3 2vXU0BhxskUi6OXMncfdro5Zdq/D5LUR6jbIrmQm8ZFn1PcWbf2MnVspRe4yMqp3kaeuAPSpeQmOO AWLuc4k6AvBJBYBQm3KznkXAcIjzodSdmH4Xr5uKUNxuxvBY/tot+2GyKTKVTsGh+UA93NmEmauor X6ZXeEqnaxZuP9xWTXPNpWInokeEiLgDtR85xsG7YVDaO+bjoauZiBByXupomixVPaNgSFrrqV1/n Y4ef2tOHXnvEopNP2ZFU6SP+NMOcdKVeXIw5j8AwI5oPnGDa7IXiCOw6SLs/6uZkSsr1J7S/jlMkd xxZr8CaeWI3WDjK1dj/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1oG-00CL9W-Cy; Fri, 20 May 2022 12:32:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1oB-00CL6A-Qt for linux-arm-kernel@bombadil.infradead.org; Fri, 20 May 2022 12:32:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Aw+5SdRadIWFAtZ++Uu6bUdsA3ScaQZx+Hjq9wUAZH8=; b=UMuLcAWXbZHW4qQfHOhBINmAlx qChlmSQR77Zb0tVP5ylC4pvbznU5VdbhAaL4iuihfLorhQtMnhmP66rP0eP7T9i3TiutlWFM6tGyp TJryTjhLPuhXdv3VODYMnGjuLMC6pH4+bJqr8OjEKnFIJgLwsdjzF53YPrUzW57TSREF3z1UyJ64b t1aLSM4K3GVnnKa76nImL2RTI1aigA6Vaqol3b8RaR0nhoafx1y8asagcXAOo0+sF2GVZpn3zQW0F zIThNI896Bt6R6FWhERGPfO+yzhY5ldvtbxDnURRObsnRR4p6N7hJ2VRc8K/BLx36pDAAp699Y1ZQ nIoNhPog==; Received: from [187.19.239.237] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns1o9-002KfF-3t; Fri, 20 May 2022 12:32:41 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 01E2A400B1; Fri, 20 May 2022 09:32:36 -0300 (-03) Date: Fri, 20 May 2022 09:32:36 -0300 From: Arnaldo Carvalho de Melo To: German Gomez Cc: James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, leo.yan@linaro.org, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/2] perf: arm64: Tools support for Dwarf unwinding through SVE functions Message-ID: References: <20220517102005.3022017-1-james.clark@arm.com> <995099d3-a170-69dc-d12e-c9b2e4753f35@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <995099d3-a170-69dc-d12e-c9b2e4753f35@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gRnJpLCBNYXkgMjAsIDIwMjIgYXQgMTI6NDY6MjRQTSArMDEwMCwgR2VybWFuIEdvbWV6IGVz Y3JldmV1Ogo+IAo+IE9uIDE3LzA1LzIwMjIgMTU6NTgsIEFybmFsZG8gQ2FydmFsaG8gZGUgTWVs byB3cm90ZToKPiA+IEVtIFR1ZSwgTWF5IDE3LCAyMDIyIGF0IDExOjIwOjAxQU0gKzAxMDAsIEph bWVzIENsYXJrIGVzY3JldmV1Ogo+ID4+IENoYW5nZXMgc2luY2UgdjE6Cj4gPj4KPiA+PiAgICog U3BsaXQgcGF0Y2hzZXQgaW50byBrZXJuZWwgc2lkZSBhbmQgUGVyZiB0b29sIGNoYW5nZXMKPiA+ IFRoYW5rcywgbm93IEknbGwgd2FpdCBmb3IgdGhlIGtlcm5lbCBzaWRlIHRvIGJlIG1lcmdlZC4K PiA+Cj4gPiAtIEFybmFsZG8KPiA+ICAKPiAKPiBIaSwKPiAKPiBJIHRoaW5rIHdlIGFsc28gbmVl ZCB0byBmaXggdGhlIGJlbG93IGltcG9ydCAoaXQncyB0cnlpbmcgdG8gaW1wb3J0IHRoZQo+IHBl cmZfcmVncy5oIGZyb20gdGhlIGtlcm5lbCwgbm90IHRoZSB0b29scy8gZGlyKS4KClN1cmUsIHRo YXQgaXMgd2h5IGl0IGlzIGltcG9ydGFudCB0byBkbyBhOgoKbWFrZSAtQyB0b29scy9wZXJmIGJ1 aWxkLXRlc3QKCmJlZm9yZSBwb3N0aW5nIHBhdGNoZXMsIGFzIGl0IHdpbGwgZG8sIGFtb25nIG90 aGVyIHRlc3RzLCBhIGRldGFjaGVkIHRhcmJhbGwgdGVzdCB1c2luZzoKCuKsolthY21lQHRvb2xi b3ggcGVyZi11cmdlbnRdJCBtYWtlIGhlbHAgfCBncmVwIHBlcmYKICBwZXJmLXRhci1zcmMtcGtn ICAgIC0gQnVpbGQgcGVyZi01LjE4LjAtcmM3LnRhciBzb3VyY2UgdGFyYmFsbAogIHBlcmYtdGFy Z3otc3JjLXBrZyAgLSBCdWlsZCBwZXJmLTUuMTguMC1yYzcudGFyLmd6IHNvdXJjZSB0YXJiYWxs CiAgcGVyZi10YXJiejItc3JjLXBrZyAtIEJ1aWxkIHBlcmYtNS4xOC4wLXJjNy50YXIuYnoyIHNv dXJjZSB0YXJiYWxsCiAgcGVyZi10YXJ4ei1zcmMtcGtnICAtIEJ1aWxkIHBlcmYtNS4xOC4wLXJj Ny50YXIueHogc291cmNlIHRhcmJhbGwKICBwZXJmLXRhcnpzdC1zcmMtcGtnIC0gQnVpbGQgcGVy Zi01LjE4LjAtcmM3LnRhci56c3Qgc291cmNlIHRhcmJhbGwK4qyiW2FjbWVAdG9vbGJveCBwZXJm LXVyZ2VudF0kCgpUaGF0IHdpbGwgcGljayBqdXN0IHdoYXQgaXMgaW4gdG9vbHMvcGVyZi9NQU5J RkVTVCBhbmQgdGhhdCBkb2VzbsK0dAppbmNsdWRlIHRoZSBrZXJuZWwgaGVhZGVycywganVzdCB3 aGF0IGlzIGluIHRvb2xzLyB0aGVuIGJ1aWxkaW5nIHdpdGgKdGhpcyBwYXRjaGtpdCB3b3VsZCBm YWlsLgoKVG8gcmVjYXA6CgrirKJbYWNtZUB0b29sYm94IHBlcmYtdXJnZW50XSQgbWFrZSBwZXJm LXRhcnh6LXNyYy1wa2cKICBUQVIKICBQRVJGX1ZFUlNJT04gPSA1LjE4LnJjNy5nYzY0NTA1NGVm NTE3CuKsolthY21lQHRvb2xib3ggcGVyZi11cmdlbnRdJCBscyAtbGEgcGVyZi01LjE4LjAtcmM3 LnRhci54egotcnctci0tci0tLiAxIGFjbWUgYWNtZSAyMzY0ODMyIE1heSAyMCAwOTozMiBwZXJm LTUuMTguMC1yYzcudGFyLnh6CuKsolthY21lQHRvb2xib3ggcGVyZi11cmdlbnRdJCB0YXIgdHZm IHBlcmYtNS4xOC4wLXJjNy50YXIueHogfCB0YWlsCi1ydy1ydy1yLS0gcm9vdC9yb290ICAgICAg NzM2NCAyMDIyLTA1LTIwIDA5OjMyIHBlcmYtNS4xOC4wLXJjNy90b29scy9wZXJmL3V0aWwvdmRz by5jCi1ydy1ydy1yLS0gcm9vdC9yb290ICAgICAgIDYzOSAyMDIyLTA1LTIwIDA5OjMyIHBlcmYt NS4xOC4wLXJjNy90b29scy9wZXJmL3V0aWwvdmRzby5oCi1ydy1ydy1yLS0gcm9vdC9yb290ICAg ICAgMTc5MyAyMDIyLTA1LTIwIDA5OjMyIHBlcmYtNS4xOC4wLXJjNy90b29scy9wZXJmL3V0aWwv emxpYi5jCi1ydy1ydy1yLS0gcm9vdC9yb290ICAgICAgMjY3MiAyMDIyLTA1LTIwIDA5OjMyIHBl cmYtNS4xOC4wLXJjNy90b29scy9wZXJmL3V0aWwvenN0ZC5jCmRyd3hyd3hyLXggcm9vdC9yb290 ICAgICAgICAgMCAyMDIyLTA1LTIwIDA5OjMyIHBlcmYtNS4xOC4wLXJjNy90b29scy9zY3JpcHRz Lwotcnctcnctci0tIHJvb3Qvcm9vdCAgICAgIDEwOTEgMjAyMi0wNS0yMCAwOTozMiBwZXJmLTUu MTguMC1yYzcvdG9vbHMvc2NyaXB0cy9NYWtlZmlsZS5hcmNoCi1ydy1ydy1yLS0gcm9vdC9yb290 ICAgICAgNTkwNSAyMDIyLTA1LTIwIDA5OjMyIHBlcmYtNS4xOC4wLXJjNy90b29scy9zY3JpcHRz L01ha2VmaWxlLmluY2x1ZGUKLXJ3LXJ3LXItLSByb290L3Jvb3QgICAgICA1Mjg4IDIwMjItMDUt MjAgMDk6MzIgcGVyZi01LjE4LjAtcmM3L3Rvb2xzL3NjcmlwdHMvdXRpbGl0aWVzLm1hawotcnct ci0tci0tIGFjbWUvYWNtZSAgICAgICAgNDEgMjAyMi0wNS0yMCAwOTozMiBwZXJmLTUuMTguMC1y YzcvSEVBRAotcnctci0tci0tIGFjbWUvYWNtZSAgICAgICAgNDYgMjAyMi0wNS0yMCAwOTozMiBw ZXJmLTUuMTguMC1yYzcvUEVSRi1WRVJTSU9OLUZJTEUK4qyiW2FjbWVAdG9vbGJveCBwZXJmLXVy Z2VudF0kCgotIEFybmFsZG8KIAo+IGRpZmYgLS1naXQgYS90b29scy9wZXJmL3V0aWwvbGlidW53 aW5kL2FybTY0LmMgYi90b29scy9wZXJmL3V0aWwvbGlidW53aW5kL2FybTY0LmMKPiBpbmRleCAx NWY2MGZkMDk0MjQuLjAxNGQ4MjE1OTY1NiAxMDA2NDQKPiAtLS0gYS90b29scy9wZXJmL3V0aWwv bGlidW53aW5kL2FybTY0LmMKPiArKysgYi90b29scy9wZXJmL3V0aWwvbGlidW53aW5kL2FybTY0 LmMKPiBAQCAtMjQsNyArMjQsNyBAQAo+IMKgI2luY2x1ZGUgInVud2luZC5oIgo+IMKgI2luY2x1 ZGUgImxpYnVud2luZC1hYXJjaDY0LmgiCj4gwqAjZGVmaW5lIHBlcmZfZXZlbnRfYXJtX3JlZ3Mg cGVyZl9ldmVudF9hcm02NF9yZWdzCj4gLSNpbmNsdWRlIDwuLi8uLi8uLi8uLi9hcmNoL2FybTY0 L2luY2x1ZGUvdWFwaS9hc20vcGVyZl9yZWdzLmg+Cj4gKyNpbmNsdWRlIDwuLi8uLi8uLi9hcmNo L2FybTY0L2luY2x1ZGUvdWFwaS9hc20vcGVyZl9yZWdzLmg+Cj4gwqAjdW5kZWYgcGVyZl9ldmVu dF9hcm1fcmVncwo+IMKgI2luY2x1ZGUgIi4uLy4uL2FyY2gvYXJtNjQvdXRpbC91bndpbmQtbGli dW53aW5kLmMiCj4gCgotLSAKCi0gQXJuYWxkbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=