From: Anthony PERARD <anthony.perard@citrix.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate vars
Date: Fri, 20 May 2022 14:48:00 +0100 [thread overview]
Message-ID: <YoecEPofeL97eFEP@perard.uk.xensource.com> (raw)
In-Reply-To: <a444edf57dbb1ea45ce4af471bf2c5f9b362bbde.1651285313.git.ehem+xen@m5p.com>
On Fri, Apr 29, 2022 at 03:45:25PM -0700, Elliott Mitchell wrote:
> Rather than having shadow variables for every element of dom_info, it is
> better to properly initialize dom_info at the start. This also removes
> the misleading memset() in the middle of main_create().
>
> Remove the dryrun element of domain_create as that has been displaced
> by the global "dryrun_only" variable.
>
> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks for the clean up.
--
Anthony PERARD
prev parent reply other threads:[~2022-05-20 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 2:21 [PATCH v2 0/3] Allow use of JSON in domain configuration files Elliott Mitchell
2022-04-20 1:23 ` [PATCH v2 3/3] tools/xl: Allow specifying JSON for domain configuration file format Elliott Mitchell
2022-05-20 14:12 ` Anthony PERARD
2022-06-01 1:25 ` Elliott Mitchell
2022-06-10 14:00 ` Anthony PERARD
2022-04-20 1:56 ` [PATCH v2 1/3] tools/xl: Sort create command options Elliott Mitchell
2022-05-20 10:36 ` Anthony PERARD
2022-04-29 22:45 ` [PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate vars Elliott Mitchell
2022-05-20 13:48 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoecEPofeL97eFEP@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=ehem+xen@m5p.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.