From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BE6C433F5 for ; Fri, 20 May 2022 17:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239515AbiETRgW (ORCPT ); Fri, 20 May 2022 13:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233897AbiETRgU (ORCPT ); Fri, 20 May 2022 13:36:20 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 656F480221 for ; Fri, 20 May 2022 10:36:19 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id nr2-20020a17090b240200b001df2b1bfc40so12052975pjb.5 for ; Fri, 20 May 2022 10:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pGTJhxGq4NRXnqMsGQiqbCMB+N3bs1Q8cueXx9EoXoc=; b=Vdn1Q04weaeDmve1R0VnEbxYbLnsYVgVtMFoJBSb2LnRquGBT8YF9uJ6sT//LxT5Vc zr1pqnrJEie4BUL2q5H4wyhHIldR429BTbCdXIrqeFTMlgIPqwsXKeUR3D6iVYelunXM PSgBvAL3Da1xW1mEQ2Ip+aDGc26hqOYxUaYYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pGTJhxGq4NRXnqMsGQiqbCMB+N3bs1Q8cueXx9EoXoc=; b=E+l+zCRKeEfA0T8y1r71jOv/tUk+rxKWwKYUTa7jlnq66LMjgC8yr0kgvqNXrn0dKI FbQqB1qdMLimL8d+CosCsH32SthFdUrYGKjfb5KiBsGiDhWhiteBdMGsjsZJ8U7pXBaC AXqrCISWSfJcXGlT0KK8XjI1bTnlg2sePnUjdyQJvuvaPDF3LOpiEZ+QTd3wL91jk+Gb jugXyMeUpftArqjt+bzAAd1ABbeAlp3wYuG5LxaS4SvmQNAxongyGGJvdFQChu1udFT9 q95gdmZbdYmRXj5wH+PNrdK0cTrVMWiHVtyWLH5EGvcg+/XuKHRhvZiW4FN77rI7TDUu 0iHA== X-Gm-Message-State: AOAM5333ObU6yLpRn/tggjeoucg8yc/psv6GIY0ndrE0hRoT3cqytcCG q3Vn7AHOL1Ig3mpLUN9zjDy6mg== X-Google-Smtp-Source: ABdhPJxpuxzegEOsmYqFaMkZd1lrc6b7kou9uzD1zcGtYR43ETtk8hSvIjCQ5rY8JthgeEXXzOmATw== X-Received: by 2002:a17:903:41c1:b0:161:bec6:b308 with SMTP id u1-20020a17090341c100b00161bec6b308mr11030318ple.161.1653068178945; Fri, 20 May 2022 10:36:18 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:5332:2096:60a3:3455]) by smtp.gmail.com with UTF8SMTPSA id f2-20020a170902f38200b0015e8d4eb24fsm25680ple.153.2022.05.20.10.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 10:36:18 -0700 (PDT) Date: Fri, 20 May 2022 10:36:17 -0700 From: Matthias Kaehlcke To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , dianders@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Message-ID: References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-3-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220520161004.1141554-3-judyhsiao@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 20, 2022 at 04:10:03PM +0000, Judy Hsiao wrote: > Audio dtsi for sc7280 boards that using rt5682 headset codec: > 1. Add dt nodes for sound card which use I2S playback and record > through rt5682s and I2S playback through max98357a. > 2. Enable lpass cpu node and add pin control and dai-links. > > Signed-off-by: Judy Hsiao > --- > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++ > 1 file changed, 120 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > new file mode 100644 > index 000000000000..d83e99f1d417 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * > + * This file defines the common audio settings for the child boards using rt5682 codec. > + * > + * Copyright 2022 Google LLC. > + */ > + > +/ { > + /* BOARD-SPECIFIC TOP LEVEL NODES */ > + sound: sound { nit: the label might not be needed, unless we expect board files to override settings. But well, there is also nothing inherently wrong with having it :) Reviewed-by: Matthias Kaehlcke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1FBCC433EF for ; Fri, 20 May 2022 17:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jSP2fzAxQTrTgF3nyBJ4+JGGcsS6rhOcsbfKP4WVRCQ=; b=1AcUz+11CacjKP d9sw38SKQNiUHNGfMwHjI2Y/HNVbpyq1jjF0SgB50wuq2rhKNCuYRPNSaPjKbkY7HjTVSNCSATrIR fX1N/y8Qq7r5KWulnd3RaeE4YZXJZ82r+U/PUFCLpRZTQH5YQLW8STO27zqsa0JWUp/HuNYtwLMEL CmxYH4MjoXgQnElE9mnjzD5l0sv+ecL27Ss+Ci90+DhDhehJjQpn/FXeu8iIMfWkvkcn56leqdcDy 7PHA6Xs+TX2MSDErupxHWJ7a6HfBV3ln0jYJHDgA5RqHq0Nhxn72vYihsNtoe8FLvWUfDKoasq343 MNAnt4pMEg89SJZLtUyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns6Y5-00Dwcn-Ml; Fri, 20 May 2022 17:36:25 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns6Y2-00Dwc9-5e for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 17:36:23 +0000 Received: by mail-pj1-x1030.google.com with SMTP id t11-20020a17090a6a0b00b001df6f318a8bso12056558pjj.4 for ; Fri, 20 May 2022 10:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pGTJhxGq4NRXnqMsGQiqbCMB+N3bs1Q8cueXx9EoXoc=; b=Vdn1Q04weaeDmve1R0VnEbxYbLnsYVgVtMFoJBSb2LnRquGBT8YF9uJ6sT//LxT5Vc zr1pqnrJEie4BUL2q5H4wyhHIldR429BTbCdXIrqeFTMlgIPqwsXKeUR3D6iVYelunXM PSgBvAL3Da1xW1mEQ2Ip+aDGc26hqOYxUaYYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pGTJhxGq4NRXnqMsGQiqbCMB+N3bs1Q8cueXx9EoXoc=; b=e4vmpNipMXgoJbnxUkQE5mJyqWtRs51yJzGDGE1TR6Bkr0QQEnXYX5IhEfZp9yWcmv fnabaxpOJXJHZEjSasjOouqhv5IVuywl8ofH44jYApn0bRr9xqglURjJvAFRR8mZbhXu dc5F+ntdAoVQD0mfltVeLT5spkRdyu4e0A9KHZuBIQwbwk8k3tsWb2RlWbh/bzECPC82 CkWL3OX9Uo/HBpTBhcFnFTRyjVzcBmErAineVne559MVIKP5r7yE/Dyf4UVv73mPBg4u u83fkWE6WED01sH209s9xI6apjnnI0fLwbMM6jliszKcA+JmwxHGV9ccG+2Yr2hzG0Ez pxCQ== X-Gm-Message-State: AOAM5338BDLo2nahiilMiJDgzKX/iBw6CwuGgaqR672w2g8v+TQRLJLE nvdEQZqP+rocO2V3hakA12OdeWzqb4iO4g== X-Google-Smtp-Source: ABdhPJxpuxzegEOsmYqFaMkZd1lrc6b7kou9uzD1zcGtYR43ETtk8hSvIjCQ5rY8JthgeEXXzOmATw== X-Received: by 2002:a17:903:41c1:b0:161:bec6:b308 with SMTP id u1-20020a17090341c100b00161bec6b308mr11030318ple.161.1653068178945; Fri, 20 May 2022 10:36:18 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:5332:2096:60a3:3455]) by smtp.gmail.com with UTF8SMTPSA id f2-20020a170902f38200b0015e8d4eb24fsm25680ple.153.2022.05.20.10.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 10:36:18 -0700 (PDT) Date: Fri, 20 May 2022 10:36:17 -0700 From: Matthias Kaehlcke To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , dianders@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Message-ID: References: <20220520161004.1141554-1-judyhsiao@chromium.org> <20220520161004.1141554-3-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520161004.1141554-3-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_103622_267251_98F9FBC9 X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 20, 2022 at 04:10:03PM +0000, Judy Hsiao wrote: > Audio dtsi for sc7280 boards that using rt5682 headset codec: > 1. Add dt nodes for sound card which use I2S playback and record > through rt5682s and I2S playback through max98357a. > 2. Enable lpass cpu node and add pin control and dai-links. > > Signed-off-by: Judy Hsiao > --- > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++ > 1 file changed, 120 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > new file mode 100644 > index 000000000000..d83e99f1d417 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * > + * This file defines the common audio settings for the child boards using rt5682 codec. > + * > + * Copyright 2022 Google LLC. > + */ > + > +/ { > + /* BOARD-SPECIFIC TOP LEVEL NODES */ > + sound: sound { nit: the label might not be needed, unless we expect board files to override settings. But well, there is also nothing inherently wrong with having it :) Reviewed-by: Matthias Kaehlcke _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel