From: Wolfram Sang <wsa@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: ismt: Provide a DMA buffer for Interrupt Cause Logging
Date: Sat, 21 May 2022 12:53:57 +0200 [thread overview]
Message-ID: <YojExZeax9nCbhty@shikoro> (raw)
In-Reply-To: <20220427101910.47438-1-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On Wed, Apr 27, 2022 at 01:19:10PM +0300, Mika Westerberg wrote:
> Before sending a MSI the hardware writes information pertinent to the
> interrupt cause to a memory location pointed by SMTICL register. This
> memory holds three double words where the least significant bit tells
> whether the interrupt cause of master/target/error is valid. The driver
> does not use this but we need to set it up because otherwise it will
> perform DMA write to the default address (0) and this will cause an
> IOMMU fault such as below:
>
> DMAR: DRHD: handling fault status reg 2
> DMAR: [DMA Write] Request device [00:12.0] PASID ffffffff fault addr 0
> [fault reason 05] PTE Write access is not set
>
> To prevent this from happening, provide a proper DMA buffer for this
> that then gets mapped by the IOMMU accordingly.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
No maintainer response so far, but given this looks like an important
bugfix and you guys are all from Intel as well, I'll apply it this time.
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-21 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 10:19 [PATCH] i2c: ismt: Provide a DMA buffer for Interrupt Cause Logging Mika Westerberg
2022-04-27 15:19 ` Andy Shevchenko
2022-05-21 10:53 ` Wolfram Sang [this message]
2022-05-22 9:37 ` Andy Shevchenko
2022-05-23 8:51 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YojExZeax9nCbhty@shikoro \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nhorman@tuxdriver.com \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.