From: Srivathsan Sivakumar <sri.skumar05@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2] staging: rts5208: spi.c: clean up dynamic debug code
Date: Sat, 21 May 2022 08:53:42 -0400 [thread overview]
Message-ID: <Yojg1nXXTIL3G82l@Sassy> (raw)
I've condensed the three dev_dbg() lines into one as you requested in the
previous patch thread; and sent them all as a singular patch.
fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Srivathsan Sivakumar <sri.skumar05@gmail.com>
Changes in v2:
- Condense three dev_dbg() code lines into one
---
drivers/staging/rts5208/spi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
index f1e9e80044ed..ea736a73e58c 100644
--- a/drivers/staging/rts5208/spi.c
+++ b/drivers/staging/rts5208/spi.c
@@ -460,10 +460,7 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
spi->write_en = srb->cmnd[6];
- dev_dbg(rtsx_dev(chip), "%s: ", __func__);
- dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
- dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
- dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);
+ dev_dbg(rtsx_dev(chip), "spi_clock = %d, clk_div = %d, write_en = %d\n ", spi->spi_clock, spi->clk_div, spi->write_en);
return STATUS_SUCCESS;
}
--
2.34.1
next reply other threads:[~2022-05-21 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 12:53 Srivathsan Sivakumar [this message]
2022-05-21 13:20 ` [PATCH v2] staging: rts5208: spi.c: clean up dynamic debug code Greg Kroah-Hartman
2022-05-21 17:17 ` Srivathsan Sivakumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yojg1nXXTIL3G82l@Sassy \
--to=sri.skumar05@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.