From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] perf build: Error for BPF skeletons without LIBBPF
Date: Mon, 23 May 2022 09:34:07 -0300 [thread overview]
Message-ID: <Yot/P/QO0sAK2iwg@kernel.org> (raw)
In-Reply-To: <YotP8BrIK/dwLJLL@krava>
Em Mon, May 23, 2022 at 11:12:16AM +0200, Jiri Olsa escreveu:
> On Fri, May 20, 2022 at 02:18:26PM -0700, Ian Rogers wrote:
> > LIBBPF requires LIBELF so doing "make BUILD_BPF_SKEL=1 NO_LIBELF=1"
> > fails with compiler errors about missing declarations. Similar could
> > happen if libbpf feature detection fails. Prefer to error when
> > BUILD_BPF_SKEL is enabled but LIBBPF isn't.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
> thanks,
> jirka
>
> > ---
> > tools/perf/Makefile.config | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index d9b699ad402c..bedb734bd6f2 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -664,6 +664,9 @@ ifdef BUILD_BPF_SKEL
> > ifeq ($(feature-clang-bpf-co-re), 0)
> > dummy := $(error Error: clang too old/not installed. Please install recent clang to build with BUILD_BPF_SKEL)
> > endif
> > + ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)
> > + dummy := $(error Error: BPF skeleton support requires libbpf)
> > + endif
> > $(call detected,CONFIG_PERF_BPF_SKEL)
> > CFLAGS += -DHAVE_BPF_SKEL
> > endif
> > --
> > 2.36.1.124.g0e6072fb45-goog
> >
--
- Arnaldo
prev parent reply other threads:[~2022-05-23 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 21:18 [PATCH] perf build: Error for BPF skeletons without LIBBPF Ian Rogers
2022-05-23 9:12 ` Jiri Olsa
2022-05-23 12:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yot/P/QO0sAK2iwg@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.