From: Lee Jones <lee.jones@linaro.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, nsekhar@ti.com, arnd@arndb.de
Subject: Re: [PATCH] mfd: davinci_voicecodec: fix possible null-ptr-deref davinci_vc_probe()
Date: Mon, 23 May 2022 14:53:03 +0100 [thread overview]
Message-ID: <YouRvxARt4ZWaKIp@google.com> (raw)
In-Reply-To: <20220426030857.3539336-1-yangyingliang@huawei.com>
On Tue, 26 Apr 2022, Yang Yingliang wrote:
> It will cause null-ptr-deref when using 'res', if platform_get_resource()
> returns NULL, so move using 'res' after devm_ioremap_resource() that
> will check it to avoid null-ptr-deref.
> And use devm_platform_get_and_ioremap_resource() to simplify code.
>
> Fixes: b5e29aa880be ("mfd: davinci_voicecodec: Remove pointless #include")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/mfd/davinci_voicecodec.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2022-05-23 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 3:08 [PATCH] mfd: davinci_voicecodec: fix possible null-ptr-deref davinci_vc_probe() Yang Yingliang
2022-05-23 13:53 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YouRvxARt4ZWaKIp@google.com \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.