From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: linux-integrity@vger.kernel.org, zohar@linux.ibm.com,
dhowells@redhat.com, keyrings@vger.kernel.org
Subject: Re: [PATCH] keys: Use struct_size and size_add helper with alloc
Date: Mon, 23 May 2022 22:58:12 +0300 [thread overview]
Message-ID: <YovnVMxsd2aZ9hF8@kernel.org> (raw)
In-Reply-To: <0563f30f-f5c5-f202-9091-a8ce095057e5@huawei.com>
On Fri, May 20, 2022 at 03:35:09PM +0800, Guozihua (Scott) wrote:
> On 2022/5/20 4:49, Jarkko Sakkinen wrote:
> > On Thu, May 19, 2022 at 10:47:02AM +0800, GUO Zihua wrote:
> > > Use struct_size helper for calculating size of flexible struct to avoid
> > > potential issues and improve readibility. Use size_add to calculate
> > > addition of size to prevent potential issues.
> >
> > What issues? Please explicitly state the issues.
> >
> > BR, Jarkko
> > .
>
> Hi Jarkko,
>
> This is a clean-up/optimization patch mostly focuses on readability and no
> actual issue is observed at the moment.
But the commit message is talking about potential issues.
BR, Jarkko
next prev parent reply other threads:[~2022-05-23 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 2:47 [PATCH] keys: Use struct_size and size_add helper with alloc GUO Zihua
2022-05-19 20:49 ` Jarkko Sakkinen
2022-05-20 7:35 ` Guozihua (Scott)
2022-05-23 19:58 ` Jarkko Sakkinen [this message]
2022-05-24 1:58 ` Guozihua (Scott)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YovnVMxsd2aZ9hF8@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=guozihua@huawei.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.