From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 225ABC43334 for ; Mon, 6 Jun 2022 17:42:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 284D611BAF8; Mon, 6 Jun 2022 17:42:34 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by gabe.freedesktop.org (Postfix) with ESMTPS id B36DC11BAF7 for ; Mon, 6 Jun 2022 17:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o6KcmZERReMj91I4Z2hAEfo65JLY4e4eAS5un7mwvs8=; b=PTT0GDJfE3l97+z6Athyiwm7C5 Ct6bJeSh2TYszVTIOOtyn7LU3RO1NbVPk25Dz7VJScrAYkijDfMqaWmqRHJ8ht3PvwGvJgX1HRA+v Fc9kx0d6/APwwqpcOgosf3oBbC85APJ2ZPfhDI7aADVCacdKENkNBpfr7TDi8jBFY72JPJMjIiXXm 78l4Qej2seXMVb8N/oGOdqEBgdZhQNVzGyVOWtiI6ZfhzBFRpjPVJe3BHbJ3UC3mN4qOJRTtiTzU5 X9CNm9lh2k91LeGsfDx35pacyJZxJXQ2OFXx1DJ8GWuOBsC+2jxi93oeDKbcLmFYTvPetdBBF0ydh 47btb7zQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60976) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nyGkG-0002IK-88; Mon, 06 Jun 2022 18:42:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nyGkE-0008Qc-KL; Mon, 06 Jun 2022 18:42:26 +0100 Date: Mon, 6 Jun 2022 18:42:26 +0100 From: "Russell King (Oracle)" To: Mark Brown Subject: Re: [PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts Message-ID: References: <20220606171436.2438051-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606171436.2438051-1-broonie@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Hans Verkuil , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 06, 2022 at 06:14:36PM +0100, Mark Brown wrote: > The tda9950 driver prints an error message if it is instantiated without > an interrupt being available since the device is non-functional in that > case. Unfortunately due to packaging of tda9950 with tda998x series devices > the tda998x driver unconditionally instantiates a tda9950 so systems with a > tda998x configured without an interrupt will trigger this error message > during boot if tda9950 support is available. Reduce the severity to debug > level so this is less likely to be presented to end users, the information > is still there for system integrators who run into problems. > > We could add a check for an interrupt to the tda998x driver instead but > this feels better from an encapsulation point of view, there's still a log > message to help anyone doing system integration. As the tda998x also makes use of the interrupt, it would be trivial to avoid instantiating the tda9950 device if there's no interrupt. tda9950 does require it, and if it's missing, then it isn't functional. No point wasting memory on the struct device. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!