From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/13] platform/chrome: cros_ec_proto: arrange get_host_command_version_mask()
Date: Tue, 7 Jun 2022 00:55:33 +0000 [thread overview]
Message-ID: <Yp6iBStcJCOwqjiT@google.com> (raw)
In-Reply-To: <CABXOdTdPwvcS2eSrXsT8dNd1XnGNugD6ub-x2qscT8YRwwK0SQ@mail.gmail.com>
On Mon, Jun 06, 2022 at 09:09:25AM -0700, Guenter Roeck wrote:
> On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> >
> > - cros_ec_get_host_command_version_mask() is a private (static) function.
> > Rename it to get_host_command_version_mask().
>
> Personally I prefer to still have prefixes, even for static functions.
> If the idea is to have a shorter function name, maybe shorten the rest
> of the function name a bit.
Ack, will fix in next version.
next prev parent reply other threads:[~2022-06-07 0:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 14:10 [PATCH 00/13] platform/chrome: Kunit tests and refactor for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 01/13] platform/chrome: cros_ec_commands: fix compile errors Tzung-Bi Shih
2022-06-06 15:08 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 02/13] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 15:18 ` Guenter Roeck
2022-06-07 0:54 ` Tzung-Bi Shih
2022-06-07 14:41 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 03/13] platform/chrome: use macros for passthru indexes Tzung-Bi Shih
2022-06-06 15:22 ` Guenter Roeck
2022-06-06 15:23 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 04/13] platform/chrome: cros_ec_proto: assign buffer size from protocol info Tzung-Bi Shih
2022-06-06 15:24 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 05/13] platform/chrome: cros_ec_proto: remove redundant NULL check Tzung-Bi Shih
2022-06-06 15:46 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 06/13] platform/chrome: cros_ec_proto: use cros_ec_map_error() Tzung-Bi Shih
2022-06-06 15:55 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 07/13] platform/chrome: cros_ec_proto: separate fill_protocol_info() Tzung-Bi Shih
2022-06-06 16:06 ` Guenter Roeck
2022-06-07 0:54 ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 08/13] platform/chrome: cros_ec_proto: separate fill_protocol_info_legacy() Tzung-Bi Shih
2022-06-06 16:06 ` Guenter Roeck
2022-06-07 0:55 ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 09/13] platform/chrome: cros_ec_proto: use devm_krealloc() Tzung-Bi Shih
2022-06-06 16:04 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 10/13] platform/chrome: cros_ec_proto: arrange get_host_command_version_mask() Tzung-Bi Shih
2022-06-06 16:09 ` Guenter Roeck
2022-06-07 0:55 ` Tzung-Bi Shih [this message]
2022-06-06 14:10 ` [PATCH 11/13] platform/chrome: cros_ec_proto: fix get_host_command_version_mask() returns Tzung-Bi Shih
2022-06-06 16:16 ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 12/13] platform/chrome: cros_ec_proto: arrange get_host_event_wake_mask() Tzung-Bi Shih
2022-06-06 16:18 ` Guenter Roeck
2022-06-07 0:55 ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 13/13] platform/chrome: cros_ec_proto: fix get_host_event_wake_mask() returns Tzung-Bi Shih
2022-06-06 16:14 ` Guenter Roeck
2022-06-07 0:55 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp6iBStcJCOwqjiT@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.