From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4918C433F5 for ; Fri, 27 May 2022 16:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349472AbiE0QIt (ORCPT ); Fri, 27 May 2022 12:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349586AbiE0QIt (ORCPT ); Fri, 27 May 2022 12:08:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747B01498FA; Fri, 27 May 2022 09:08:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1024F61DCE; Fri, 27 May 2022 16:08:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 466E1C385A9; Fri, 27 May 2022 16:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653667727; bh=OlBI8wVCIAxvvfasLZa9UH7nUKu5dc9htrYEpiULe6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j8y6/wrgqMG5Oat+epe7h7DytEaI14sZ2BQgUoEE4PpE+UZoDrLkh1p0wzQnlS+Rn hl/EJzYILmBt5XtutCUugflcd316cr3XKq8rns0GY/VXwsxaS4gCRxFLAxN+ft3wum 9vOfyJmi4YXWzAK88Dmd6Vs1RYhzTrk9XXXQPkzoX8xK2Hdzu/39EM+xb52mQUqSon bR2sn31VpNjPTWq7gKVfKS1lmhokpmpXAOKTg7nf1dHoa7KXNZHvQNNerAJyCseEDc PbDMhTsXYsKqKTJF8WJyO7rhFY6I2X6yRRjJtRP6IsuBgO1KeMFan/5fCW0cGgTdAn Ixih7UrR73guQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id CFB2D4036D; Fri, 27 May 2022 13:08:43 -0300 (-03) Date: Fri, 27 May 2022 13:08:43 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, german.gomez@arm.com, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-doc@vger.kernel.org Subject: Re: [PATCH v1 4/6] perf tools: Use dynamic register set for Dwarf unwind Message-ID: References: <20220509144257.1623063-1-james.clark@arm.com> <20220509144257.1623063-5-james.clark@arm.com> <20220527061854.GA829807@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220527061854.GA829807@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Em Fri, May 27, 2022 at 02:18:54PM +0800, Leo Yan escreveu: > On Thu, May 26, 2022 at 03:19:54PM -0300, Arnaldo Carvalho de Melo wrote: > > [...] > > > Too old to support? > > > > 69 7.19 ubuntu:16.04-x-arm64 : FAIL gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) > > arch/arm64/util/perf_regs.c: In function 'arch__user_reg_mask': > > arch/arm64/util/perf_regs.c:151:28: error: 'HWCAP_SVE' undeclared (first use in this function) > > if (getauxval(AT_HWCAP) & HWCAP_SVE) > > ^ > > arch/arm64/util/perf_regs.c:151:28: note: each undeclared identifier is reported only once for each function it appears in > > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'util' failed > > make[5]: *** [util] Error 2 > > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'arm64' failed > > make[4]: *** [arm64] Error 2 > > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'arch' failed > > make[3]: *** [arch] Error 2 > > > > > > ⬢[acme@toolbox perf]$ find . -name "*.h" | xargs grep -w HWCAP_SVE > > ./arch/arm64/include/uapi/asm/hwcap.h:#define HWCAP_SVE (1 << 22) > > ⬢[acme@toolbox perf]$ > > I tested aarch64 GCC-7.4.1 which doesn't support HWCAP_SVE, but > aarch64 GCC-8.3.0 and GCC-9.4.0 support it. > > Either we can add below code: > > #ifndef HWCAP_SVE > #define HWCAP_SVE (1 << 22) > #endif > > Or directly include header file <.../asm/hwcap.h>. > > Not sure which method is preferred. Maybe the first approach can be > de-couple with Linux kernel code? Lets go KISS and just define it if not present, as you suggested above, will test now. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA993C433F5 for ; Fri, 27 May 2022 16:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Fxpp+omGrPtmeF7rUH0qgnPGrYVZfDsozA4hJZ0w44=; b=G/n5+Hy4ttOBSh LqA5KynQZxvYvWw1OmLXnYGvCAcTM3d/ncFroSU1tTzvG+WPl3KFsuTxV0HySs4ybsUfvhFVQZ6vH y5w9/i4chucCWE6b5XngC+J1GpsYDNVQJJyw+b3Xk7/y8Td+GGtvs8KA+tIv/nM2JAzczjjL61Q1A wgiv9GsMSwHdelKPnoWSe4nscL1k87N3S1J2kv/v2ji5cR/Nj0nCNnZoXgC5XaFWZMcHDj8KcjK7q qD0yC5UrJ/MmGcAACpoRVx8O5yOjwAjmJXLsnSoCIsifkuDrpAYENeFfHbIHj0JFASilE4ls+EXLn fBDlr9F7PPdLEsEfOhNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucWD-000VGH-J9; Fri, 27 May 2022 16:08:53 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucWB-000VFx-IY for linux-arm-kernel@bombadil.infradead.org; Fri, 27 May 2022 16:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=nyaS7W4ddbMGpUEkMXd4qvvJDn/QCzpN4h4+DeSRTG4=; b=Ok5UVUpTk2fXeqTpxTXxysQLfM Amg2X21u2eUrBW/8uc5oHz60VpUW9mCGQPjv450nq0z5m6HFdqJ6GDfYaGPS8/olOMJzauP98xqNy JFoWVbE2JSHJWfqFYausUSmovseZpbfWRwbs3lsOPDSZm/GDozVUxLFEKwZQ/g03BcjtG6qtm+dhj IvJUiHd5R4HpwW4fLx/rfUrBIJk+PVkm5nrjPCPeIDwJ7kdBx0aFz83Gy3WgaGTmYNGf7LUcvCcHR JzlBcQIbhxFp8lFA9fOwOM0qy0lWVKxl3lVa+fN7/LL2+oq66S7gpmrp23ykB4pmZRIy2dojn9nfR OR/ilDog==; Received: from [187.19.239.237] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucW9-002DFf-7i for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 16:08:49 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id CFB2D4036D; Fri, 27 May 2022 13:08:43 -0300 (-03) Date: Fri, 27 May 2022 13:08:43 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, german.gomez@arm.com, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-doc@vger.kernel.org Subject: Re: [PATCH v1 4/6] perf tools: Use dynamic register set for Dwarf unwind Message-ID: References: <20220509144257.1623063-1-james.clark@arm.com> <20220509144257.1623063-5-james.clark@arm.com> <20220527061854.GA829807@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220527061854.GA829807@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gRnJpLCBNYXkgMjcsIDIwMjIgYXQgMDI6MTg6NTRQTSArMDgwMCwgTGVvIFlhbiBlc2NyZXZl dToKPiBPbiBUaHUsIE1heSAyNiwgMjAyMiBhdCAwMzoxOTo1NFBNIC0wMzAwLCBBcm5hbGRvIENh cnZhbGhvIGRlIE1lbG8gd3JvdGU6Cj4gCj4gWy4uLl0KPiAKPiA+IFRvbyBvbGQgdG8gc3VwcG9y dD8KPiA+IAo+ID4gICA2OSAgICAgNy4xOSB1YnVudHU6MTYuMDQteC1hcm02NCAgICAgICAgICA6 IEZBSUwgZ2NjIHZlcnNpb24gNS40LjAgMjAxNjA2MDkgKFVidW50dS9MaW5hcm8gNS40LjAtNnVi dW50dTF+MTYuMDQuOSkKPiA+ICAgICBhcmNoL2FybTY0L3V0aWwvcGVyZl9yZWdzLmM6IEluIGZ1 bmN0aW9uICdhcmNoX191c2VyX3JlZ19tYXNrJzoKPiA+ICAgICBhcmNoL2FybTY0L3V0aWwvcGVy Zl9yZWdzLmM6MTUxOjI4OiBlcnJvcjogJ0hXQ0FQX1NWRScgdW5kZWNsYXJlZCAoZmlyc3QgdXNl IGluIHRoaXMgZnVuY3Rpb24pCj4gPiAgICAgICBpZiAoZ2V0YXV4dmFsKEFUX0hXQ0FQKSAmIEhX Q0FQX1NWRSkKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+ID4gICAgIGFy Y2gvYXJtNjQvdXRpbC9wZXJmX3JlZ3MuYzoxNTE6Mjg6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBp ZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBl YXJzIGluCj4gPiAgICAgL2dpdC9wZXJmLTUuMTguMC90b29scy9idWlsZC9NYWtlZmlsZS5idWls ZDoxMzk6IHJlY2lwZSBmb3IgdGFyZ2V0ICd1dGlsJyBmYWlsZWQKPiA+ICAgICBtYWtlWzVdOiAq KiogW3V0aWxdIEVycm9yIDIKPiA+ICAgICAvZ2l0L3BlcmYtNS4xOC4wL3Rvb2xzL2J1aWxkL01h a2VmaWxlLmJ1aWxkOjEzOTogcmVjaXBlIGZvciB0YXJnZXQgJ2FybTY0JyBmYWlsZWQKPiA+ICAg ICBtYWtlWzRdOiAqKiogW2FybTY0XSBFcnJvciAyCj4gPiAgICAgL2dpdC9wZXJmLTUuMTguMC90 b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDoxMzk6IHJlY2lwZSBmb3IgdGFyZ2V0ICdhcmNoJyBm YWlsZWQKPiA+ICAgICBtYWtlWzNdOiAqKiogW2FyY2hdIEVycm9yIDIKPiA+IAo+ID4gCj4gPiDi rKJbYWNtZUB0b29sYm94IHBlcmZdJCBmaW5kIC4gLW5hbWUgIiouaCIgfCB4YXJncyBncmVwIC13 IEhXQ0FQX1NWRQo+ID4gLi9hcmNoL2FybTY0L2luY2x1ZGUvdWFwaS9hc20vaHdjYXAuaDojZGVm aW5lIEhXQ0FQX1NWRQkJKDEgPDwgMjIpCj4gPiDirKJbYWNtZUB0b29sYm94IHBlcmZdJCAKPiAK PiBJIHRlc3RlZCBhYXJjaDY0IEdDQy03LjQuMSB3aGljaCBkb2Vzbid0IHN1cHBvcnQgSFdDQVBf U1ZFLCBidXQKPiBhYXJjaDY0IEdDQy04LjMuMCBhbmQgR0NDLTkuNC4wIHN1cHBvcnQgaXQuCj4g Cj4gRWl0aGVyIHdlIGNhbiBhZGQgYmVsb3cgY29kZToKPiAKPiAgICNpZm5kZWYgSFdDQVBfU1ZF Cj4gICAjZGVmaW5lIEhXQ0FQX1NWRQkJKDEgPDwgMjIpCj4gICAjZW5kaWYKPiAKPiBPciBkaXJl Y3RseSBpbmNsdWRlIGhlYWRlciBmaWxlIDwuLi4vYXNtL2h3Y2FwLmg+Lgo+IAo+IE5vdCBzdXJl IHdoaWNoIG1ldGhvZCBpcyBwcmVmZXJyZWQuICBNYXliZSB0aGUgZmlyc3QgYXBwcm9hY2ggY2Fu IGJlCj4gZGUtY291cGxlIHdpdGggTGludXgga2VybmVsIGNvZGU/CgpMZXRzIGdvIEtJU1MgYW5k IGp1c3QgZGVmaW5lIGl0IGlmIG5vdCBwcmVzZW50LCBhcyB5b3Ugc3VnZ2VzdGVkIGFib3ZlLAp3 aWxsIHRlc3Qgbm93LgoKLSBBcm5hbGRvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==