Re: [PATCH v2 00/15] Dynamic allocation of memory regions and IBM vTPM v2

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 2508 bytes --]

On Thu, May 19, 2022 at 06:34:48PM +0200, Daniel Kiper wrote:
> On Wed, May 18, 2022 at 11:24:48AM -0400, Stefan Berger wrote:
> > On 4/14/22 11:30, Daniel Kiper wrote:
> > > On Thu, Apr 07, 2022 at 04:41:04PM +0200, Daniel Kiper wrote:
> > > > On Mon, Mar 28, 2022 at 05:22:25PM +1100, Daniel Axtens wrote:
> > > > > Hi all,
> > > > >
> > > > > This is, at long last, an updated version of my series extending Patrick's
> > > > > dynamic memory regions to ieee1275.
> > > > >
> > > > > Noteworthy changes:
> > > > >
> > > > >   - reworked debug prints as grub_dprintfs. Folded the ieee1275 ones into the
> > > > >     ieee1275 patches.
> > > > >
> > > > >   - reworked the ieee1275 runtime memory claiming to be more resilient and better
> > > > >     documented.
> > > > >
> > > > >   - fixed comment style and hopefully addressed all other change requests.
> > > > >
> > > > >   - grub will now try asking for contiguous memory and then, if that fails, for
> > > > >     discontiguous memory - in case region merging with the discontiguous memory
> > > > >     is sufficient to allow the eventual allocation to succeed.
> > > >
> > > > Patrick, all mm and EFI code got my RB. Could you test it with your
> > > > Argon changes? If these changes pass your tests I will merge them.
> > >
> > > Patrick, ping?
> > >
> > > To be more precise, I am thinking about the patches up to #10.
> > >
> > > Daniel
> >
> > Any way we can make progress with this series before it gets all forgotten
> > about?
> 
> It is not and it will not be forgotten. I am waiting for some allocator
> tests reports. When I get them I will merge allocator stuff and review
> the rest of the code from this patch series. Sadly folks who are going
> to test the code are busy with other stuff. Though I am pinging them...
> 
> Anyway, sorry for delay...
> 
> Daniel

Sorry for the delay here, and thanks for the nudge. I've found a few
quiet moments this morning to rebase my Argon2 patch series for LUKS2 on
top of this series and found everything to work as expected. Decrypting
a volume with a memory hardness of 2GB RAM worked just fine on an EFI
x64 system. So this series is:

    Tested-by: Patrick Steinhardt <ps@pks.im>

I'm going to revive my own patch series and send it in for review
soonish. The nice thing of having waited so long is that Argon2 support
has meanwhile landed in libgcrypt, so that should make it easier to
integrate it into GRUB.

Thanks
Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]