From: Helge Deller <deller@gmx.de>
To: linux-omap@vger.kernel.org,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Imre Deak <imre.deak@solidboot.com>, Trilok Soni <soni.trilok@gmail.com>
Subject: [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning
Date: Sun, 29 May 2022 08:47:51 +0200 [thread overview]
Message-ID: <YpMXF9luBc4Sjr9h@ls3530> (raw)
The symbol hwa742_update_window_async() is exported, but there is no
prototype defined for it. That's why gcc complains:
drivers-video-fbdev-omap-hwa742.c:warning:no-previous-prototype-for-hwa742_update_window_async
Add the prototype, but I wonder if we couldn't drop exporting the symbol
instead. Since omapfb_update_window_async() is exported the same way,
are there any users outside of the tree?
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/drivers/video/fbdev/omap/omapfb.h b/drivers/video/fbdev/omap/omapfb.h
index d930152c289c..0c753ccbc1c0 100644
--- a/drivers/video/fbdev/omap/omapfb.h
+++ b/drivers/video/fbdev/omap/omapfb.h
@@ -229,5 +229,9 @@ extern int omapfb_update_window_async(struct fb_info *fbi,
struct omapfb_update_window *win,
void (*callback)(void *),
void *callback_data);
+extern int hwa742_update_window_async(struct fb_info *fbi,
+ struct omapfb_update_window *win,
+ void (*callback)(void *),
+ void *callback_data);
#endif /* __OMAPFB_H */
next reply other threads:[~2022-05-29 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 6:47 Helge Deller [this message]
2022-05-29 11:14 ` [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpMXF9luBc4Sjr9h@ls3530 \
--to=deller@gmx.de \
--cc=imre.deak@solidboot.com \
--cc=jmkrzyszt@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.