From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nvCjY-0005Hw-Ge for mharc-grub-devel@gnu.org; Sun, 29 May 2022 02:49:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvCjW-0005Hk-Px for grub-devel@gnu.org; Sun, 29 May 2022 02:49:02 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:36603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvCjI-0004W7-1M for grub-devel@gnu.org; Sun, 29 May 2022 02:49:02 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 525E632007F9; Sun, 29 May 2022 02:48:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 29 May 2022 02:48:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653806925; x=1653893325; bh=lmht+8XcIy 50tTOxi9jg6e5iOel3NyYSvjMg4ETs5+E=; b=M0Fwd8Df5gWh1AL+IbjQxj3NwD e/InU3TFe7v73FSQtU3gDBCe/31LMvrO1Tozgj6w238ro2EQTxt5fNcEphSWWM+2 b2DRx54i0gitB5keK9MSjk7ebNp2rn8s/5/y2snnthn2/5lkzjdBF1y3qCP4iyBb VEX/bT3L70ODcRO3BjC2bnMJZU+alsMMfmgGXHj86Eb/2A8RozGBbOdjripBkdI6 AY5oYVEOkDZp96IxNje/mOrXHfk+j3/pNIqO3hBihz/cfaJePBM4Bk5ag7eOULvw 3F0Nvq5yDYCVQFl/hfl52Im4YFbbfqxP4YJRDRQKmY3BBJPBfExy3JxC1mNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653806925; x=1653893325; bh=lmht+8XcIy50tTOxi9jg6e5iOel3 NyYSvjMg4ETs5+E=; b=rLc1idFM3dHfGK2vwgs/XDhK5OiGUYCLcPTDva2cm/ET pUskOouT/7b/THvGJmvnRoLmGfPezRmfU3/YCIQwsBDv5AJJEdi2WJnBqYCEvZiF drp8JS7S1XNwQlyenBdVbGKupX0cD5KM3RyQ5EtyBCqTqBZ15JBYmUHoyedIZUA+ iDQ/B0BEo8xqJ7ZG7Nb5OEsgD+wXND4ASaRwMS9VKTBvYay/8fWZGgXPvoq9u00s xkZONpgQIDMAVCO+ZGq6aQwuH1gb8vwoaWlm9CJr3qKTzfLiAHbO0vr/neqzwqE6 pFDxtv2RiCfMnhGNg5l9EgITghZ7iC/8gZPT3PcE3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeefgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeeukedtvedtffevleejtefgheehieegkeeluddvfeefgeehgfeltddtheejleffteen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesph hkshdrihhm X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 May 2022 02:48:44 -0400 (EDT) Received: from localhost (xps [10.192.0.12]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 6cf3a805 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 29 May 2022 06:48:42 +0000 (UTC) Date: Sun, 29 May 2022 08:48:41 +0200 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper , Denis 'GNUtoo' Carikli , John Lane Subject: Re: [PATCH v2 0/3] Cryptomount detached headers Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="R6SM3BUpdnDzfBBh" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.19; envelope-from=ps@pks.im; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2022 06:49:03 -0000 --R6SM3BUpdnDzfBBh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote: > Note: Description here has changed since last time, the last few sentence= s, > which describe a method for allowing backends to bypass the read hook on > the source disk. >=20 > Updates since v1: > * Add marge comment block describing at a high level the read hook opera= tion > and assumptions. > * Add code to unset read hook on source disk when exiting > grub_cryptodisk_scan_device_real(). A couple return calls were convert= ed > into gotos so that logical flows to one exit point. [snip] I've reviewed this patch series, and except for a single nit the changes all look good to me. So please feel free to add my Reviewed-by: Patrick Steinhardt , regardless of whether you decide to apply my prosed nit in 2/3 or not. Patrick --R6SM3BUpdnDzfBBh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmKTF0gACgkQVbJhu7ck PpSDfA//d8Hw35leXasP/8kS8/dp4NkDDwoCMEiCckbT3J70PQYhD2IiLw2QI4ZH 7Ta43QkWuzga0zf2CMqmBY6XqxRuRH2j9Z4rsCjj/VJDb/gzI2TdaaOUArLZWnUl d9grr0zPFyNO3NJqLerGp7Z+dZtV+AiDLt1SE5RsxbbStnIpcLi5o0q9qxTETwo6 RTWXkDxHg4phbD8uuP3W5LDC6NVtbDyAG7z5JZRitCnEJYjljSG8ZP+nMrfICV7q Ehwiv8t9atvwvYaqFfiu9ek8kt2GNpk/8qsR8HMEcAr8i3KgsxVtPphOLHEoM9Lc f+o1lgvbyzk6ka1WVFMyMFRa97ha8NW1p6yfi6Asp5P01iUi6L2p31Ucufu3yHiD Y5shu2xmUb5bDGkVdqxdMPOHvhivMmCwTnlp0lmfHJxbb4mOi9UD2KqCYHcobV6h 2I91+VSlvjb+9Vdh++T95RH8qM95/1+z/7uwUJhWfxuQndy6AX8zvgM3v8bZuuWe ESa/Bbfvsfi9c82zlpm08xoIqzBO8+VXXdkkC4p0Ni1htEbi/oTSm8oqPy3vbkA5 BHlpVA0QCmvgTtwQf3dA6uUWrkq7cBCAXBB47+bx8slPEIRrnKnK1MSGZsy1ClRa vyHSamId8D2IQeE6aM1UfOBp0kAPwlO/xml5FArLXlXSNvvcxSY= =sHGp -----END PGP SIGNATURE----- --R6SM3BUpdnDzfBBh--