From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH v2] ext4/053: update the test_dummy_encryption tests
Date: Mon, 30 May 2022 15:07:46 -0400 [thread overview]
Message-ID: <YpUWAgDJAAnbbwqs@mit.edu> (raw)
In-Reply-To: <20220530173044.156375-1-ebiggers@kernel.org>
On Mon, May 30, 2022 at 10:30:44AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Kernel commit 5f41fdaea63d ("ext4: only allow test_dummy_encryption when
> supported") tightened the requirements on when the test_dummy_encryption
> mount option is accepted. Update ext4/053 accordingly.
>
> Move the test cases to later in the file to group them with the other
> test cases that use do_mkfs to add custom mkfs options instead of using
> the "default" filesystem that the test creates at the beginning.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
I thought we were going to put in a kernel version check in so that
this won't break on pre-5.19 kernels? The thinking was that we
wouldn't be backporting commit 5f41fdaea63d to LTS or distro kernels,
so the version number check would be reliable in this instance.
Otherwise people who are testing enterprise kernels, LTS kernels,
etc., will see this test fail.
- Ted
next prev parent reply other threads:[~2022-05-30 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 17:30 [PATCH v2] ext4/053: update the test_dummy_encryption tests Eric Biggers
2022-05-30 19:07 ` Theodore Ts'o [this message]
2022-05-30 19:47 ` Eric Biggers
2022-06-03 5:31 ` Zorro Lang
2022-06-03 5:48 ` Eric Biggers
2022-06-03 7:40 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpUWAgDJAAnbbwqs@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.