Re: [PATCH] hw/nvme: deprecate the use-intel-id compatibility parameter

[Klaus Jensen <its@irrelevant.dk>]

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

On May 30 16:37, Philippe Mathieu-Daudé wrote:
> On 29/4/22 07:41, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller
> > pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI
> > identifier.
> > 
> > Deprecate the compatibility parameter so we can get rid of it once and
> > for all.
> > 
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > ---
> >   docs/about/deprecated.rst | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> > index 896e5a97abbd..450f945ac25f 100644
> > --- a/docs/about/deprecated.rst
> > +++ b/docs/about/deprecated.rst
> > @@ -356,6 +356,14 @@ contains native support for this feature and thus use of the option
> >   ROM approach is obsolete. The native SeaBIOS support can be activated
> >   by using ``-machine graphics=off``.
> > +``-device nvme,use-intel-id=on|off`` (since 7.1)
> > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > +
> > +The ``nvme`` device originally used a PCI Vendor/Device Identifier combination
> > +from Intel that was not properly allocated. Since version 5.2, the controller
> > +has used a properly allocated identifier. Deprecate the ``use-intel-id``
> > +machine compatibility parameter.
> > +
> >   Block device options
> >   ''''''''''''''''''''
> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks!

Applied to nvme-next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]