From: Phillip Potter <phil@philpotter.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 0/2] Fix some compile warnings in v5.18+
Date: Tue, 31 May 2022 07:40:24 +0100 [thread overview]
Message-ID: <YpW4WKxKIIgY0l7m@equinox> (raw)
In-Reply-To: <20220531013103.2175-1-Larry.Finger@lwfinger.net>
On Mon, May 30, 2022 at 08:31:01PM -0500, Larry Finger wrote:
> Building driver r8188eu in staging with -warray-bounds exposes two places
> where arrays are too small.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> v2 - get proper To and Cc
> v3 - Use Dan Carpenter's suggestion for correct patch.
>
> Larry Finger (2):
> staging: r8188eu: Fix undersized array in rtw_xmit.c
> staging: r8188eu: Fix warning of array overflow in ioctl_linux.c
>
> drivers/staging/r8188eu/core/rtw_xmit.c | 17 ++++-------------
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +-
> 2 files changed, 5 insertions(+), 14 deletions(-)
>
> --
> 2.36.1
>
Hi Larry,
Both patches look good to me, however I've already submitted a patch 10
days ago that does exactly what your rtw_xmit.c patch does, in
addition to fixing the changed error handling semantics for the relevant
function (in f94b47c6bde6) which broke the driver.
Regards,
Phil
next prev parent reply other threads:[~2022-05-31 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 1:31 [PATCH v3 0/2] Fix some compile warnings in v5.18+ Larry Finger
2022-05-31 1:31 ` [PATCH v3 1/2] staging: r8188eu: Fix undersized array in rtw_xmit.c Larry Finger
2022-05-31 7:25 ` Dan Carpenter
2022-05-31 1:31 ` [PATCH v3 2/2] staging: r8188eu: Fix warning of array overflow in ioctl_linux.c Larry Finger
2022-05-31 6:40 ` Phillip Potter [this message]
2022-05-31 17:16 ` [PATCH v3 0/2] Fix some compile warnings in v5.18+ Larry Finger
2022-05-31 18:44 ` Phillip Potter
2022-06-06 6:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpW4WKxKIIgY0l7m@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.