From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307CBC433F5 for ; Tue, 31 May 2022 15:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232481AbiEaPvD (ORCPT ); Tue, 31 May 2022 11:51:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbiEaPvC (ORCPT ); Tue, 31 May 2022 11:51:02 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1D847A469 for ; Tue, 31 May 2022 08:51:01 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id q12-20020a17090a304c00b001e2d4fb0eb4so3143037pjl.4 for ; Tue, 31 May 2022 08:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UCz3T3cNlUlcl+vTuj+aemzqAG1y/5K07Rxr5yFu5Yo=; b=GqsBWqb0Ny4TrESiJZj08ErKYtTdGwHK/+nXToOZhJaScEwEKYdf5g6mDyXPa4pkHN 7jvEiC5C2Tf2LunKZ0aGklhLdY+J8XYAqYn8QgIbPLzJmp5aSQrR6/uNTa/1F5d40E3M +c2SpaQKNr5WdBKa/ENa066NfJN2rxNCYWj1VwD+AeLtD/cygK9gOzKbquSnhyk/lBR6 riSvwc3k9eVJSuR0zDOGgUg/OHD51D720QpNrZIJbwffErhCUIhUE9BkirU4lcMLowR5 PIN+r1nAY/7qc6mhVgW9S5ELJms1pzC1wKlCe3GqotqRmHbjmJKsZIUSoF0B2qaSG19C D1pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UCz3T3cNlUlcl+vTuj+aemzqAG1y/5K07Rxr5yFu5Yo=; b=7W11pZxxiBMc3zA3Fp6MSe1GatXZxPuYeIcn39HGUUFwXuFi6mbQ650yBG8MYri0gI VnG14czoK8BEaG4BDPI05xle9M0oCH3WoM3W37+FMtBJDW5ADrY4AIrpuoU7+Tsfq7Sl bc0lf8XeVUcvtBuSLzaYuHrAL1ow+ZWHMIrUHO/P2C2aivA53qkZDKgjrhQzwOqkNAAu vlh/iPlGo1rxBlLZp/dhCHrJTcTXBt8ZdnUHN1Tn4gpQq72OESkVVZenCOnqTeskfWHn pJe9MypqhDNddmHjeOHiq0z9CnH6R2EgSQdjlDw9j82a6neSoZNDuYxrpLK4cG8KoTps /Stg== X-Gm-Message-State: AOAM530XlCkthIqVtrbj3dTt6P04CYQ/494XD2My+7de7hOOLdfFgIAu ia7QXGuw10eAueEySc9arQ0= X-Google-Smtp-Source: ABdhPJy1EmjHvyYV+6GxcbY07zuwfFMaWUg/I4FRa4YaJqksu4m5axodY8R2hgSM6nzpLLMzZabF+A== X-Received: by 2002:a17:903:22d0:b0:164:ec0:178c with SMTP id y16-20020a17090322d000b001640ec0178cmr2468164plg.127.1654012261013; Tue, 31 May 2022 08:51:01 -0700 (PDT) Received: from google.com ([2620:15c:202:201:3b8f:bcac:41a7:7a32]) by smtp.gmail.com with ESMTPSA id i16-20020aa787d0000000b0050dc762813csm10902539pfo.22.2022.05.31.08.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 08:50:59 -0700 (PDT) Date: Tue, 31 May 2022 08:50:57 -0700 From: Dmitry Torokhov To: Peter Zijlstra , "Rafael J. Wysocki" Cc: linux-input@vger.kernel.org, Hugh Dickins , Jarkko Nikula Subject: Re: Suspend/Resume (S3) issues with rmi_smbus Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, May 31, 2022 at 10:54:19AM +0200, Peter Zijlstra wrote: > On Mon, May 30, 2022 at 12:15:40PM -0700, Dmitry Torokhov wrote: > > > Can you check the entire list of resume operations to make sure that > > PS/2 device is resumed before RMI one? > > It reports psmouse failure *after* the rmi4 failure. Is there a knob to > make it print more device model details on resume? > > > You can also try overriding devices driven by rmi_smbus as needing > > synchronous resume (see > > https://lore.kernel.org/all/YgHTYrODoo2ou49J@google.com/). > > I can confirm this works. Let's ask Rafael if he has an idea why adding a link between PS/2 device and its SMbus companion did not seem to affect resume order. Was there a change in 5.18 timeframe (since original reporters said that adding device link helped their case). Let's also add a couple of more folks who experienced original issue to see if they observe this as well. Thanks. -- Dmitry