From: John Keeping <john@metanate.com>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Michael Wu <michael@allwinnertech.com>
Subject: Re: [PATCH v2 1/2] usb: gadget: f_fs: change ep->status safe in ffs_epfile_io()
Date: Tue, 31 May 2022 19:06:07 +0100 [thread overview]
Message-ID: <YpZZD/l1/hDXIqde@donbot> (raw)
In-Reply-To: <1654006119-23869-2-git-send-email-quic_linyyuan@quicinc.com>
On Tue, May 31, 2022 at 10:08:38PM +0800, Linyu Yuan wrote:
> If a task read/write data in blocking mode, it will wait the completion
> in ffs_epfile_io(), if function unbind occurs, ffs_func_unbind() will
> kfree ffs ep, once the task wake up, it still dereference the ffs ep to
> obtain the request status.
>
> Fix it by moving the request status to io_data which is stack-safe.
>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
Reviewed-by: John Keeping <john@metanate.com>
next prev parent reply other threads:[~2022-05-31 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 14:08 [PATCH v2 0/2] usb: f_fs: safe operation in ffs_epfile_io() Linyu Yuan
2022-05-31 14:08 ` [PATCH v2 1/2] usb: gadget: f_fs: change ep->status safe " Linyu Yuan
2022-05-31 18:06 ` John Keeping [this message]
2022-05-31 14:08 ` [PATCH v2 2/2] usb: gadget: f_fs: change ep->ep " Linyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpZZD/l1/hDXIqde@donbot \
--to=john@metanate.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael@allwinnertech.com \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.