All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Keith Busch <kbusch@fb.com>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-nvme@lists.infradead.org, axboe@kernel.dk,
	Kernel Team <Kernel-team@fb.com>,
	hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com,
	pankydev8@gmail.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv5 09/11] block: introduce bdev_iter_is_aligned helper
Date: Tue, 31 May 2022 21:46:48 +0000	[thread overview]
Message-ID: <YpaMyCfOKK5NKgL+@gmail.com> (raw)
In-Reply-To: <20220531191137.2291467-10-kbusch@fb.com>

On Tue, May 31, 2022 at 12:11:35PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Provide a convenient function for this repeatable coding pattern.
> 
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>  include/linux/blkdev.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 834b981ef01b..583cdeb8895d 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1370,6 +1370,13 @@ static inline unsigned int bdev_dma_alignment(struct block_device *bdev)
>  	return queue_dma_alignment(bdev_get_queue(bdev));
>  }
>  
> +static inline bool bvev_iter_is_aligned(struct block_device *bdev,
> +					struct iov_iter *iter)
> +{
> +	return iov_iter_is_aligned(iter, bdev_dma_alignment(bdev),
> +				   bdev_logical_block_size(bdev) - 1);
> +}

"bdev", not "bvev".

- Eric

  reply	other threads:[~2022-05-31 21:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 19:11 [PATCHv5 00/11] direct-io dma alignment Keith Busch
2022-05-31 19:11 ` [PATCHv5 01/11] block: fix infinite loop for invalid zone append Keith Busch
2022-06-01  8:03   ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 02/11] block/bio: remove duplicate append pages code Keith Busch
2022-05-31 19:11 ` [PATCHv5 03/11] block: export dma_alignment attribute Keith Busch
2022-05-31 19:11 ` [PATCHv5 04/11] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-31 19:11 ` [PATCHv5 05/11] block: add a helper function for dio alignment Keith Busch
2022-06-01  5:29   ` Christoph Hellwig
2022-06-01  8:04   ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 06/11] block/merge: count bytes instead of sectors Keith Busch
2022-06-01  8:05   ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 07/11] block/bounce: " Keith Busch
2022-06-01  7:04   ` Eric Biggers
2022-05-31 19:11 ` [PATCHv5 08/11] iov: introduce iov_iter_aligned Keith Busch
2022-06-01  5:30   ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 09/11] block: introduce bdev_iter_is_aligned helper Keith Busch
2022-05-31 21:46   ` Eric Biggers [this message]
2022-06-01  5:31   ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 10/11] block: relax direct io memory alignment Keith Busch
2022-06-01  5:31   ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 11/11] fs: add support for dma aligned direct-io Keith Busch
2022-06-01  5:32   ` Christoph Hellwig
2022-06-01  7:11 ` [PATCHv5 00/11] direct-io dma alignment Eric Biggers
2022-06-01 14:28   ` Keith Busch
2022-06-01 16:12     ` Keith Busch
2022-06-06 16:24       ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpaMyCfOKK5NKgL+@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=Kernel-team@fb.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=pankydev8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.