All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Haowen Bai <baihaowen@meizu.com>
Cc: larry.finger@lwfinger.net, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, phil@philpotter.co.uk
Subject: Re: [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy
Date: Wed, 1 Jun 2022 12:18:28 +0200	[thread overview]
Message-ID: <Ypc89GXegCft+vEq@kroah.com> (raw)
In-Reply-To: <1654077926-9687-1-git-send-email-baihaowen@meizu.com>

On Wed, Jun 01, 2022 at 06:05:26PM +0800, Haowen Bai wrote:
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy. So we drop redundant memset.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: change title for unique subjects.

That's not really unique, why is this just not 1 patch with both changes
in it as you are doing the same thing to the same driver source, just in
different locations in the files.

Please merge together.

thanks,

greg k-h

  reply	other threads:[~2022-06-01 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  9:35 [PATCH] staging: r8188eu: Drop redundant memset Haowen Bai
2022-06-01 10:01 ` Larry Finger
2022-06-01 10:05   ` [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy Haowen Bai
2022-06-01 10:18     ` Greg KH [this message]
2022-06-01 11:49       ` [PATCH V3] " Haowen Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ypc89GXegCft+vEq@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=baihaowen@meizu.com \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.