From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41BDC43334 for ; Wed, 1 Jun 2022 17:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355636AbiFAROy (ORCPT ); Wed, 1 Jun 2022 13:14:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244187AbiFAROy (ORCPT ); Wed, 1 Jun 2022 13:14:54 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6B11A3094 for ; Wed, 1 Jun 2022 10:14:52 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1nwRvl-0006xI-Kc; Wed, 01 Jun 2022 19:14:49 +0200 Date: Wed, 1 Jun 2022 19:14:49 +0200 From: Phil Sutter To: Nick Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso , Jan Engelhardt Subject: Re: [PATCH] Revert "Simplify static build extension loading" Message-ID: Mail-Followup-To: Phil Sutter , Nick , netfilter-devel@vger.kernel.org, Pablo Neira Ayuso , Jan Engelhardt References: <20220601134743.14415-1-vincent@systemli.org> <1678505c-aa11-6fcf-87b4-eeaa0113af62@systemli.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1678505c-aa11-6fcf-87b4-eeaa0113af62@systemli.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Jun 01, 2022 at 04:22:49PM +0200, Nick wrote: > More Information: > https://github.com/openwrt/openwrt/pull/9886#issuecomment-1143191713 > > I have to debug further. Well, it looks like firewall3 does a static build and calls init_extensions*(). It includes xtables.h without defining ALL_INCLUSIVE or NO_SHARED_LIBS, so ends up with the empty function definitions. Given that these functions are for internal use only, it is only harmful to declare them in the "official" libxtables header. Unless someone objects, I'll prepare a patch moving the declarations into xshared.h. Cheers, Phil