From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8061AC43334 for ; Thu, 2 Jun 2022 08:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=miiHovg7vpjKoneZH9PSnv22EAFKNfz1cdx6PLKwUIo=; b=IZen/nspC62ZX+6POzWp5lvRGx r3GqTe2arByIlof+WDohGPw1AmvxZGWB88bBiezvUhxnHvkiIUPPqiVwnydixdaypRgQX2LECrdEn 1r7BxQVXMNU5V4PY1F9XkVpQuTLk5LjBVgLeQPFUFzoENyqEYwaQF+V8QOZBJuqtEl7T2+MijkpZv t8Q6R1JypC34RjmhuAaBrJLW/8VVLnkebe3SHxtHYreMm130fcpHpTx76HUNHiVVj07sEHOPMWAkq V/WFORbhMkVXwQvdnfmovNvPodaN+ntmUe9XOxVH+RgbCvC2WBGusFX06QaD+uEPYeXfxBNUu4yvn zxh0pMIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwgA9-002CbJ-Os; Thu, 02 Jun 2022 08:26:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwgA6-002CaH-FX for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 08:26:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFDFD60A22; Thu, 2 Jun 2022 08:26:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC0F6C385A5; Thu, 2 Jun 2022 08:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654158393; bh=bQwKbQKTJEf+poPfDf97H2c1XcXfwaf7p1F0soiUTQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aKJgIEStdmCLpUG6QB5F029tkP2MUPcl12MyRfrsPn9RVmFnvrJGzEc/i0Tpg5LxU 7gf/yqZ5NnfwR/fuLCUYuzjRgXFhQGocH8NAOOo1XzxrF1hw1nM6SKHvroTL0EmISv Ouco/m1qmABxsv44q1lQYEf/K2QoYXzdIKb05v1GbuyAQrzYJRqGfe2NzjkZc/mFPg 6czYj+F7a9Y1Iop5UT3bM2f5ghH980tXlzrJEGU0BVMYlNXO6QXkH2r1oUx+nUUbp4 gWEC6XdMkL7nSsu8mnknlOlSjyD3mYZ822O0QwiCq0MXcYm4eY5NWuGyGaNDGBPfdN YzDgNDooURtpQ== Date: Thu, 2 Jun 2022 10:26:31 +0200 From: Mark Brown To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , kernel test robot Subject: Re: [PATCH] arm64/sme: Fix the ffr variable assignment Message-ID: References: <20220601171346.2143699-1-catalin.marinas@arm.com> MIME-Version: 1.0 In-Reply-To: <20220601171346.2143699-1-catalin.marinas@arm.com> X-Cookie: May your camel be as swift as the wind. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_012634_596267_899F2007 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7781424368762584429==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7781424368762584429== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SJ0wdnWzlG5MtMMg" Content-Disposition: inline --SJ0wdnWzlG5MtMMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 01, 2022 at 06:13:46PM +0100, Catalin Marinas wrote: > This variable is a bool and expected to be set to true if the FFR > state needs saving/restoring, false otherwise. In __efi_fpsimd_end() > this variable should be restored to the value of efi_sm_state but this > is a per-CPU variable, not to be read directly. Make ffr false if > !__this_cpu_read(efi_sm_state), leave it true otherwise. > - if (__this_cpu_read(efi_sm_state)) { > + if (__this_cpu_read(efi_sm_state)) > sysreg_clear_set_s(SYS_SVCR, > 0, > SVCR_SM_MASK); > - if (!system_supports_fa64()) > - ffr = efi_sm_state; > - } > + else > + ffr = false; In the case where we support FA64 we need to load FFR so this needs to be conditional on system_supports_fa64() in the case where efi_sm_state is true. --SJ0wdnWzlG5MtMMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKYdDYACgkQJNaLcl1U h9BBYAgAhLuVUeGaTw0alohIY3DEiTDl4RosIx4weQeT6c2uc17x1h6EdglZJiFa atH7rrDtbY5oQoDK243GZR+rPAQPA+GE3Vy+GlYfYCTgTUzH7UJg5F+mHg3Y6m1Y C13l5X5bN7idd8zVulp34fMJ1eZU/Wym91edVnO8qsTm/hMqaNf14oy9RgBSviuu 76Ual/z7XO0vgYCG1zE2SnAsKPn7fb4Z9QQ/blJ+mRhzvM0AIQxKbA0SBqeagzTx DWwTyIt2YGzEb8vVCSVWCEW040NrUZE6e77tAuyLF0/fIHvyltKWQ4kGheWK5KOC nPu7/80Ge9dE3j4cdBcuV9U78CyD5g== =NotY -----END PGP SIGNATURE----- --SJ0wdnWzlG5MtMMg-- --===============7781424368762584429== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7781424368762584429==--