Re: [f2fs-dev] [PATCH 1/3] Fix the struct f2fs_dentry_block size check

[Jaegeuk Kim <jaegeuk@kernel.org>]

On 06/18, Peter Collingbourne wrote:
> On Sat, Jun 18, 2022, 16:41 Chao Yu <chao@kernel.org> wrote:
> 
> > On 2022/6/15 7:17, Bart Van Assche wrote:
> > > Fix the f2fs-tools build on systems for which PAGE_SIZE != 4096.
> > >
> > > Cc: Peter Collingbourne <pcc@google.com>
> > > Reported-by: Peter Collingbourne <pcc@google.com>
> > > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> >
> > Reviewed-by: Chao Yu <chao@kernel.org>
> >
> 
> I'm not sure if this is the correct fix. From what I was able to figure out
> this is actually an on-disk data structure so it needs to be sized the same
> way as in the kernel. The kernel implementation of the file system requires
> a 4K page size which means that it only makes sense for this to be sized as
> if PAGE_SIZE was defined to 4096. It should at least be possible to use
> this tool on a non-4K page size kernel to create a file system that can be
> read on a 4K page size kernel, so I think the right fix would be to change
> the definition of this struct to use F2FS_BLKSIZE (or just hardcode 4096).

Yeah, since F2FS support 4KB page size, we need F2FS_BLKSIZE.

> 
> Peter


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel