From: Lee Jones <lee.jones@linaro.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, bleung@chromium.org,
Stephen Boyd <swboyd@chromium.org>,
Brian Norris <briannorris@chromium.org>,
"open list:CHROME HARDWARE PLATFORM SUPPORT"
<chrome-platform@lists.linux.dev>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [PATCH 2/3] platform/chrome: cros_ec_proto: Rename cros_ec_command function
Date: Wed, 8 Jun 2022 08:44:58 +0100 [thread overview]
Message-ID: <YqBTeogFDW1tqfZp@google.com> (raw)
In-Reply-To: <20220606201825.763788-3-pmalani@chromium.org>
On Mon, 06 Jun 2022, Prashant Malani wrote:
> cros_ec_command() is the name of a function as well as a struct, as such
> it can confuse indexing tools (like ctags). Avoid this by renaming it to
> cros_ec_cmd(). Update all the callsites to use the new name.
>
> This patch is a find-and-replace, so should not introduce any functional
> changes.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/mfd/cros_ec_dev.c | 4 +--
Acked-by: Lee Jones <lee.jones@linaro.org>
> drivers/platform/chrome/cros_ec_proto.c | 22 ++++++------
> drivers/platform/chrome/cros_ec_typec.c | 39 ++++++++++-----------
> drivers/platform/chrome/cros_usbpd_notify.c | 4 +--
> drivers/regulator/cros-ec-regulator.c | 24 ++++++-------
> include/linux/platform_data/cros_ec_proto.h | 2 +-
> 6 files changed, 47 insertions(+), 48 deletions(-)
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-06-08 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 20:17 [PATCH 0/3] platform/chrome: cros_ec_command() improvements Prashant Malani
2022-06-06 20:18 ` [PATCH 1/3] regulator: cros-ec: Use common cros_ec_command() Prashant Malani
2022-06-06 23:31 ` Stephen Boyd
2022-06-07 14:37 ` Guenter Roeck
2022-06-07 15:31 ` Mark Brown
2022-06-06 20:18 ` [PATCH 2/3] platform/chrome: cros_ec_proto: Rename cros_ec_command function Prashant Malani
2022-06-06 23:32 ` Stephen Boyd
2022-06-07 14:38 ` Guenter Roeck
2022-06-08 7:44 ` Lee Jones [this message]
2022-06-06 20:18 ` [PATCH 3/3] platform/chrome: cros_ec_proto: Update size arg types Prashant Malani
2022-06-06 23:34 ` Stephen Boyd
2022-06-07 14:41 ` Guenter Roeck
2022-06-08 8:20 ` [PATCH 0/3] platform/chrome: cros_ec_command() improvements patchwork-bot+chrome-platform
2022-06-10 2:30 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqBTeogFDW1tqfZp@google.com \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.