From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD40CC433EF for ; Wed, 8 Jun 2022 10:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236641AbiFHKQZ (ORCPT ); Wed, 8 Jun 2022 06:16:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236547AbiFHKP0 (ORCPT ); Wed, 8 Jun 2022 06:15:26 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1700925694C; Wed, 8 Jun 2022 03:03:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8E21ECE2761; Wed, 8 Jun 2022 10:03:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3838CC3411C; Wed, 8 Jun 2022 10:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654682581; bh=IE2ioBq3LzKNaoMouoT+ks73JxPmJtR88S4lYSVl7wA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GAaCktvfr7A5t034XvRH9WIQQr/4Mw4S4pGwpHeH4fIQQ1OC3w+8pGZSBUX9y0GLQ mgtqq5MQh0C5UQQpqLNjTSzsmtJPE/Oo1imEyoWuCfIeYrcOmnTHfbOUvxxuxYbsOI XXKH0ppnWrlYoimgq23myaUGrrd9NdQaW16h4TGAmhBBX5NCp4i8cMQjk387d88JiQ uHPdkfVZdVxnaXX/xz4qB49xdyEassZxq7C5wW2GToi1PY1VMiyNP3XmyxUpSQhuD/ w8hEhPJQlrPE5vkZm6aaML6rqgy/PNE0PefD+a42+p7LkMDHiSE2ZWn5MgafXB9SHF JV/9iIXozkOOA== Date: Wed, 8 Jun 2022 13:02:42 +0300 From: Mike Rapoport To: mawupeng Cc: ardb@kernel.org, david@redhat.com, corbet@lwn.net, will@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, chenzhou10@huawei.com, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Message-ID: References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-6-mawupeng1@huawei.com> <99900b31-2605-2c85-a1b7-9ef2666b58da@redhat.com> <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, Jun 08, 2022 at 03:27:09PM +0800, mawupeng wrote: > > 在 2022/6/7 22:49, Ard Biesheuvel 写道: > > On Tue, 7 Jun 2022 at 14:22, David Hildenbrand wrote: > > > > > > On 07.06.22 11:38, Wupeng Ma wrote: > > > > From: Ma Wupeng > > > > > > > > Initrd memory will be removed and then added in arm64_memblock_init() and this > > > > will cause it to lose all of its memblock flags. The lost of MEMBLOCK_MIRROR > > > > flag will lead to error log printed by find_zone_movable_pfns_for_nodes if > > > > the lower 4G range has some non-mirrored memory. > > > > > > > > In order to solve this problem, the lost MEMBLOCK_MIRROR flag will be > > > > reinstalled if the origin memblock has this flag. > > > > > > > > Signed-off-by: Ma Wupeng > > > > --- > > > > arch/arm64/mm/init.c | 9 +++++++++ > > > > include/linux/memblock.h | 1 + > > > > mm/memblock.c | 20 ++++++++++++++++++++ > > > > 3 files changed, 30 insertions(+) > > > > > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > > > index 339ee84e5a61..11641f924d08 100644 > > > > --- a/arch/arm64/mm/init.c > > > > +++ b/arch/arm64/mm/init.c > > > > @@ -350,9 +350,18 @@ void __init arm64_memblock_init(void) > > > > "initrd not fully accessible via the linear mapping -- please check your bootloader ...\n")) { > > > > phys_initrd_size = 0; > > > > } else { > > > > + int flags, ret; > > > > + > > > > + ret = memblock_get_flags(base, &flags); > > > > + if (ret) > > > > + flags = 0; > > > > + > > > > memblock_remove(base, size); /* clear MEMBLOCK_ flags */ > > > > memblock_add(base, size); > > > > memblock_reserve(base, size); > > > > > > Can you explain why we're removing+re-adding here exactly? Is it just to > > > clear flags as the comment indicates? > > > > > > > This should only happen if the placement of the initrd conflicts with > > a mem= command line parameter or it is not covered by memblock for > > some other reason. > > > > IOW, this should never happen, and if re-memblock_add'ing this memory > > unconditionally is causing problems, we should fix that instead of > > working around it. > > This will happen if we use initrdmem=3G,100M to reserve initrd memory below > the 4G limit to test this scenario(just for testing, I have trouble to boot > qemu with initrd enabled and memory below 4G are all mirror memory). > > Re-memblock_add'ing this memory unconditionally seems fine but clear all > flags(especially MEMBLOCK_MIRROR) may lead to some error log. > > > > > > If it's really just about clearing flags, I wonder if we rather want to > > > have an interface that does exactly that, and hides the way this is > > > actually implemented (obtain flags, remove, re-add ...), internally. > > > > > > But most probably there is more magic in the code and clearing flags > > > isn't all it ends up doing. > > > > > > > I don't remember exactly why we needed to clear the flags, but I think > > it had to do with some corner case we hit when the initrd was > > partially covered. > If "mem=" is set in command line, memblock_mem_limit_remove_map() will > remove all memory block without MEMBLOCK_NOMAP. Maybe this will bring the > memory back if this initrd mem has the MEMBLOCK_NOMAP flag? > > The rfc version [1] introduce and use memblock_clear_nomap() to clear the > MEMBLOCK_NOMAP of this initrd memblock. > So maybe the usage of memblock_remove() is just to avoid introducing new > function(memblock_clear_nomap)? > > Since commit 4c546b8a3469 ("memblock: add memblock_clear_nomap()") already > introduced memblock_clear_nomap(). Can we use this to remove flag MEMBLOCK_NOMAP > to solve this problem rather than bring flag MEMBLOCK_MIRROR back? AFAICT, there are two corner cases that re-adding initrd memory covers: * initrd memory is not a part of the memory reported to memblock, either because of firmware weirdness or because it was cut out with mem= * initrd memory overlaps a NOMAP region So to make sure initrd memory is mapped properly and retains MEMBLOCK_MIRROR I think the best we can do is memblock_add(); memblock_clear_nomap(); memblock_reserve(); > [1] https://lore.kernel.org/linux-arm-kernel/20160202180622.GP10166@arm.com/T/#t > > . -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E2A1C433EF for ; Wed, 8 Jun 2022 10:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h9i+HNndwn3Ot3yCOWCF6op1eASTiGfiGTkqwzpNnkU=; b=16KIf0Rt/VvVns oSMJydCW28Wyc//IeQJHTQMr04FImkr+BIoHrStSLyWYbcPMmWFv38Xd48Qhlrbx5z5ZmGRvXJYlG USJtwTAxryZ5ipMNlDVfm0xIEMgSdLBu5WK6sW0/zMyRT+4YYaMC1cKqr9PyPGu3PAArBTiXjsyCX 95/FKlRnYev4rwkdo15PZUmQUaBRS9aVs/TFVBsdigONQ3wka9H+jqm4+RKJPmzbgBFKmcWfg6536 90C/z3JRl0W3wxan9TrY8xQqcy+jlKUEWY4H1fdYnzNXtMKkVbDWTDGtfrxRzcWZR9nLmmRu9fGk6 4c6AKcSyj/XeeXgZ5qvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysXN-00Ca6Q-Eg; Wed, 08 Jun 2022 10:03:41 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysWp-00CZoL-LE; Wed, 08 Jun 2022 10:03:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8E1DDCE274F; Wed, 8 Jun 2022 10:03:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3838CC3411C; Wed, 8 Jun 2022 10:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654682581; bh=IE2ioBq3LzKNaoMouoT+ks73JxPmJtR88S4lYSVl7wA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GAaCktvfr7A5t034XvRH9WIQQr/4Mw4S4pGwpHeH4fIQQ1OC3w+8pGZSBUX9y0GLQ mgtqq5MQh0C5UQQpqLNjTSzsmtJPE/Oo1imEyoWuCfIeYrcOmnTHfbOUvxxuxYbsOI XXKH0ppnWrlYoimgq23myaUGrrd9NdQaW16h4TGAmhBBX5NCp4i8cMQjk387d88JiQ uHPdkfVZdVxnaXX/xz4qB49xdyEassZxq7C5wW2GToi1PY1VMiyNP3XmyxUpSQhuD/ w8hEhPJQlrPE5vkZm6aaML6rqgy/PNE0PefD+a42+p7LkMDHiSE2ZWn5MgafXB9SHF JV/9iIXozkOOA== Date: Wed, 8 Jun 2022 13:02:42 +0300 From: Mike Rapoport To: mawupeng Cc: ardb@kernel.org, david@redhat.com, corbet@lwn.net, will@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, chenzhou10@huawei.com, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Message-ID: References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-6-mawupeng1@huawei.com> <99900b31-2605-2c85-a1b7-9ef2666b58da@redhat.com> <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_030308_101889_8BB7F2BB X-CRM114-Status: GOOD ( 43.42 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMDgsIDIwMjIgYXQgMDM6Mjc6MDlQTSArMDgwMCwgbWF3dXBlbmcgd3JvdGU6 Cj4gCj4g5ZyoIDIwMjIvNi83IDIyOjQ5LCBBcmQgQmllc2hldXZlbCDlhpnpgZM6Cj4gPiBPbiBU dWUsIDcgSnVuIDIwMjIgYXQgMTQ6MjIsIERhdmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQu Y29tPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIDA3LjA2LjIyIDExOjM4LCBXdXBlbmcgTWEgd3Jv dGU6Cj4gPiA+ID4gRnJvbTogTWEgV3VwZW5nIDxtYXd1cGVuZzFAaHVhd2VpLmNvbT4KPiA+ID4g PiAKPiA+ID4gPiBJbml0cmQgbWVtb3J5IHdpbGwgYmUgcmVtb3ZlZCBhbmQgdGhlbiBhZGRlZCBp biBhcm02NF9tZW1ibG9ja19pbml0KCkgYW5kIHRoaXMKPiA+ID4gPiB3aWxsIGNhdXNlIGl0IHRv IGxvc2UgYWxsIG9mIGl0cyBtZW1ibG9jayBmbGFncy4gVGhlIGxvc3Qgb2YgTUVNQkxPQ0tfTUlS Uk9SCj4gPiA+ID4gZmxhZyB3aWxsIGxlYWQgdG8gZXJyb3IgbG9nIHByaW50ZWQgYnkgZmluZF96 b25lX21vdmFibGVfcGZuc19mb3Jfbm9kZXMgaWYKPiA+ID4gPiB0aGUgbG93ZXIgNEcgcmFuZ2Ug aGFzIHNvbWUgbm9uLW1pcnJvcmVkIG1lbW9yeS4KPiA+ID4gPiAKPiA+ID4gPiBJbiBvcmRlciB0 byBzb2x2ZSB0aGlzIHByb2JsZW0sIHRoZSBsb3N0IE1FTUJMT0NLX01JUlJPUiBmbGFnIHdpbGwg YmUKPiA+ID4gPiByZWluc3RhbGxlZCBpZiB0aGUgb3JpZ2luIG1lbWJsb2NrIGhhcyB0aGlzIGZs YWcuCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWEgV3VwZW5nIDxtYXd1cGVuZzFA aHVhd2VpLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgIGFyY2gvYXJtNjQvbW0vaW5pdC5jICAg ICB8ICA5ICsrKysrKysrKwo+ID4gPiA+ICAgaW5jbHVkZS9saW51eC9tZW1ibG9jay5oIHwgIDEg Kwo+ID4gPiA+ICAgbW0vbWVtYmxvY2suYyAgICAgICAgICAgIHwgMjAgKysrKysrKysrKysrKysr KysrKysKPiA+ID4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L21tL2luaXQuYyBiL2FyY2gvYXJtNjQv bW0vaW5pdC5jCj4gPiA+ID4gaW5kZXggMzM5ZWU4NGU1YTYxLi4xMTY0MWY5MjRkMDggMTAwNjQ0 Cj4gPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9tbS9pbml0LmMKPiA+ID4gPiArKysgYi9hcmNoL2Fy bTY0L21tL2luaXQuYwo+ID4gPiA+IEBAIC0zNTAsOSArMzUwLDE4IEBAIHZvaWQgX19pbml0IGFy bTY0X21lbWJsb2NrX2luaXQodm9pZCkKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICJp bml0cmQgbm90IGZ1bGx5IGFjY2Vzc2libGUgdmlhIHRoZSBsaW5lYXIgbWFwcGluZyAtLSBwbGVh c2UgY2hlY2sgeW91ciBib290bG9hZGVyIC4uLlxuIikpIHsKPiA+ID4gPiAgICAgICAgICAgICAg ICAgICAgICAgIHBoeXNfaW5pdHJkX3NpemUgPSAwOwo+ID4gPiA+ICAgICAgICAgICAgICAgIH0g ZWxzZSB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGludCBmbGFncywgcmV0Owo+ID4g PiA+ICsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgcmV0ID0gbWVtYmxvY2tfZ2V0X2Zs YWdzKGJhc2UsICZmbGFncyk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGlmIChyZXQp Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MgPSAwOwo+ID4gPiA+ ICsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgIG1lbWJsb2NrX3JlbW92ZShiYXNlLCBz aXplKTsgLyogY2xlYXIgTUVNQkxPQ0tfIGZsYWdzICovCj4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgICBtZW1ibG9ja19hZGQoYmFzZSwgc2l6ZSk7Cj4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgICBtZW1ibG9ja19yZXNlcnZlKGJhc2UsIHNpemUpOwo+ID4gPiAKPiA+ID4gQ2FuIHlv dSBleHBsYWluIHdoeSB3ZSdyZSByZW1vdmluZytyZS1hZGRpbmcgaGVyZSBleGFjdGx5PyBJcyBp dCBqdXN0IHRvCj4gPiA+IGNsZWFyIGZsYWdzIGFzIHRoZSBjb21tZW50IGluZGljYXRlcz8KPiA+ ID4gCj4gPiAKPiA+IFRoaXMgc2hvdWxkIG9ubHkgaGFwcGVuIGlmIHRoZSBwbGFjZW1lbnQgb2Yg dGhlIGluaXRyZCBjb25mbGljdHMgd2l0aAo+ID4gYSBtZW09IGNvbW1hbmQgbGluZSBwYXJhbWV0 ZXIgb3IgaXQgaXMgbm90IGNvdmVyZWQgYnkgbWVtYmxvY2sgZm9yCj4gPiBzb21lIG90aGVyIHJl YXNvbi4KPiA+IAo+ID4gSU9XLCB0aGlzIHNob3VsZCBuZXZlciBoYXBwZW4sIGFuZCBpZiByZS1t ZW1ibG9ja19hZGQnaW5nIHRoaXMgbWVtb3J5Cj4gPiB1bmNvbmRpdGlvbmFsbHkgaXMgY2F1c2lu ZyBwcm9ibGVtcywgd2Ugc2hvdWxkIGZpeCB0aGF0IGluc3RlYWQgb2YKPiA+IHdvcmtpbmcgYXJv dW5kIGl0Lgo+IAo+IFRoaXMgd2lsbCBoYXBwZW4gaWYgd2UgdXNlIGluaXRyZG1lbT0zRywxMDBN IHRvIHJlc2VydmUgaW5pdHJkIG1lbW9yeSBiZWxvdwo+IHRoZSA0RyBsaW1pdCB0byB0ZXN0IHRo aXMgc2NlbmFyaW8oanVzdCBmb3IgdGVzdGluZywgSSBoYXZlIHRyb3VibGUgdG8gYm9vdAo+IHFl bXUgd2l0aCBpbml0cmQgZW5hYmxlZCBhbmQgbWVtb3J5IGJlbG93IDRHIGFyZSBhbGwgbWlycm9y IG1lbW9yeSkuCj4gCj4gUmUtbWVtYmxvY2tfYWRkJ2luZyB0aGlzIG1lbW9yeSB1bmNvbmRpdGlv bmFsbHkgc2VlbXMgZmluZSBidXQgY2xlYXIgYWxsCj4gZmxhZ3MoZXNwZWNpYWxseSBNRU1CTE9D S19NSVJST1IpIG1heSBsZWFkIHRvIHNvbWUgZXJyb3IgbG9nLgo+IAo+ID4gCj4gPiA+IElmIGl0 J3MgcmVhbGx5IGp1c3QgYWJvdXQgY2xlYXJpbmcgZmxhZ3MsIEkgd29uZGVyIGlmIHdlIHJhdGhl ciB3YW50IHRvCj4gPiA+IGhhdmUgYW4gaW50ZXJmYWNlIHRoYXQgZG9lcyBleGFjdGx5IHRoYXQs IGFuZCBoaWRlcyB0aGUgd2F5IHRoaXMgaXMKPiA+ID4gYWN0dWFsbHkgaW1wbGVtZW50ZWQgKG9i dGFpbiBmbGFncywgcmVtb3ZlLCByZS1hZGQgLi4uKSwgaW50ZXJuYWxseS4KPiA+ID4gCj4gPiA+ IEJ1dCBtb3N0IHByb2JhYmx5IHRoZXJlIGlzIG1vcmUgbWFnaWMgaW4gdGhlIGNvZGUgYW5kIGNs ZWFyaW5nIGZsYWdzCj4gPiA+IGlzbid0IGFsbCBpdCBlbmRzIHVwIGRvaW5nLgo+ID4gPiAKPiA+ IAo+ID4gSSBkb24ndCByZW1lbWJlciBleGFjdGx5IHdoeSB3ZSBuZWVkZWQgdG8gY2xlYXIgdGhl IGZsYWdzLCBidXQgSSB0aGluawo+ID4gaXQgaGFkIHRvIGRvIHdpdGggc29tZSBjb3JuZXIgY2Fz ZSB3ZSBoaXQgd2hlbiB0aGUgaW5pdHJkIHdhcwo+ID4gcGFydGlhbGx5IGNvdmVyZWQuCj4gSWYg Im1lbT0iIGlzIHNldCBpbiBjb21tYW5kIGxpbmUsIG1lbWJsb2NrX21lbV9saW1pdF9yZW1vdmVf bWFwKCkgd2lsbAo+IHJlbW92ZSBhbGwgbWVtb3J5IGJsb2NrIHdpdGhvdXQgTUVNQkxPQ0tfTk9N QVAuIE1heWJlIHRoaXMgd2lsbCBicmluZyB0aGUKPiBtZW1vcnkgYmFjayBpZiB0aGlzIGluaXRy ZCBtZW0gaGFzIHRoZSBNRU1CTE9DS19OT01BUCBmbGFnPwo+IAo+IFRoZSByZmMgdmVyc2lvbiBb MV0gaW50cm9kdWNlIGFuZCB1c2UgbWVtYmxvY2tfY2xlYXJfbm9tYXAoKSB0byBjbGVhciB0aGUK PiBNRU1CTE9DS19OT01BUCBvZiB0aGlzIGluaXRyZCBtZW1ibG9jay4KPiBTbyBtYXliZSB0aGUg dXNhZ2Ugb2YgbWVtYmxvY2tfcmVtb3ZlKCkgaXMganVzdCB0byBhdm9pZCBpbnRyb2R1Y2luZyBu ZXcKPiBmdW5jdGlvbihtZW1ibG9ja19jbGVhcl9ub21hcCk/Cj4gCj4gU2luY2UgY29tbWl0IDRj NTQ2YjhhMzQ2OSAoIm1lbWJsb2NrOiBhZGQgbWVtYmxvY2tfY2xlYXJfbm9tYXAoKSIpIGFscmVh ZHkKPiBpbnRyb2R1Y2VkIG1lbWJsb2NrX2NsZWFyX25vbWFwKCkuIENhbiB3ZSB1c2UgdGhpcyB0 byByZW1vdmUgZmxhZyBNRU1CTE9DS19OT01BUAo+IHRvIHNvbHZlIHRoaXMgcHJvYmxlbSByYXRo ZXIgdGhhbiBicmluZyBmbGFnIE1FTUJMT0NLX01JUlJPUiBiYWNrPwoKQUZBSUNULCB0aGVyZSBh cmUgdHdvIGNvcm5lciBjYXNlcyB0aGF0IHJlLWFkZGluZyBpbml0cmQgbWVtb3J5IGNvdmVyczoK KiBpbml0cmQgbWVtb3J5IGlzIG5vdCBhIHBhcnQgb2YgdGhlIG1lbW9yeSByZXBvcnRlZCB0byBt ZW1ibG9jaywgZWl0aGVyCmJlY2F1c2Ugb2YgZmlybXdhcmUgd2VpcmRuZXNzIG9yIGJlY2F1c2Ug aXQgd2FzIGN1dCBvdXQgd2l0aCBtZW09CiogaW5pdHJkIG1lbW9yeSBvdmVybGFwcyBhIE5PTUFQ IHJlZ2lvbgoKU28gdG8gbWFrZSBzdXJlIGluaXRyZCBtZW1vcnkgaXMgbWFwcGVkIHByb3Blcmx5 IGFuZCByZXRhaW5zCk1FTUJMT0NLX01JUlJPUiBJIHRoaW5rIHRoZSBiZXN0IHdlIGNhbiBkbyBp cwoKCW1lbWJsb2NrX2FkZCgpOwoJbWVtYmxvY2tfY2xlYXJfbm9tYXAoKTsKCW1lbWJsb2NrX3Jl c2VydmUoKTsKCiAKPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5l bC8yMDE2MDIwMjE4MDYyMi5HUDEwMTY2QGFybS5jb20vVC8jdAo+ID4gLgoKLS0gClNpbmNlcmVs eSB5b3VycywKTWlrZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2088FC433EF for ; Wed, 8 Jun 2022 10:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHq1ZQU5oZ9N+PsFSWVmJ5pKKxeRW91XAd+O/FgNeeY=; b=Gytu6SAfM+bW35 2Ryy1Gs0I1qY4Twk0HWt746MlKwQbryG+MOaoo8FxnALmV5Hb8AT5tHrfxPlrMk0AMdYsphW+ZHQA F7+7I1aMr+ku3DfrvLTiv0i1vuqHvmc1TsmKy58rIFdMOIMaDO9e0Vs+OeYD4Zrxx65PeNR3e+Xra hfk75nFbUHYITfDG+pofvBjvKH6QwsdMGqsLLxjH8ONUMgt6BP+VliA2FPQI/mVYoxoCAG9CZsvvq 26PFGkcbTn4I5bQDXz9OFzxQ6/O4kuulnfslLZ8fvIPKZr3LC8o6FoQExDY0W0/V6CkYlkEHQXcXT YDn9GF/bRT6vfKZR5Z0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysX7-00CZz7-To; Wed, 08 Jun 2022 10:03:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysWp-00CZoL-LE; Wed, 08 Jun 2022 10:03:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8E1DDCE274F; Wed, 8 Jun 2022 10:03:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3838CC3411C; Wed, 8 Jun 2022 10:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654682581; bh=IE2ioBq3LzKNaoMouoT+ks73JxPmJtR88S4lYSVl7wA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GAaCktvfr7A5t034XvRH9WIQQr/4Mw4S4pGwpHeH4fIQQ1OC3w+8pGZSBUX9y0GLQ mgtqq5MQh0C5UQQpqLNjTSzsmtJPE/Oo1imEyoWuCfIeYrcOmnTHfbOUvxxuxYbsOI XXKH0ppnWrlYoimgq23myaUGrrd9NdQaW16h4TGAmhBBX5NCp4i8cMQjk387d88JiQ uHPdkfVZdVxnaXX/xz4qB49xdyEassZxq7C5wW2GToi1PY1VMiyNP3XmyxUpSQhuD/ w8hEhPJQlrPE5vkZm6aaML6rqgy/PNE0PefD+a42+p7LkMDHiSE2ZWn5MgafXB9SHF JV/9iIXozkOOA== Date: Wed, 8 Jun 2022 13:02:42 +0300 From: Mike Rapoport To: mawupeng Cc: ardb@kernel.org, david@redhat.com, corbet@lwn.net, will@kernel.org, catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, chenzhou10@huawei.com, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Message-ID: References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-6-mawupeng1@huawei.com> <99900b31-2605-2c85-a1b7-9ef2666b58da@redhat.com> <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <29900b05-ec44-76a2-645a-22a13399d7fd@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_030308_101889_8BB7F2BB X-CRM114-Status: GOOD ( 43.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMDgsIDIwMjIgYXQgMDM6Mjc6MDlQTSArMDgwMCwgbWF3dXBlbmcgd3JvdGU6 Cj4gCj4g5ZyoIDIwMjIvNi83IDIyOjQ5LCBBcmQgQmllc2hldXZlbCDlhpnpgZM6Cj4gPiBPbiBU dWUsIDcgSnVuIDIwMjIgYXQgMTQ6MjIsIERhdmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQu Y29tPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIDA3LjA2LjIyIDExOjM4LCBXdXBlbmcgTWEgd3Jv dGU6Cj4gPiA+ID4gRnJvbTogTWEgV3VwZW5nIDxtYXd1cGVuZzFAaHVhd2VpLmNvbT4KPiA+ID4g PiAKPiA+ID4gPiBJbml0cmQgbWVtb3J5IHdpbGwgYmUgcmVtb3ZlZCBhbmQgdGhlbiBhZGRlZCBp biBhcm02NF9tZW1ibG9ja19pbml0KCkgYW5kIHRoaXMKPiA+ID4gPiB3aWxsIGNhdXNlIGl0IHRv IGxvc2UgYWxsIG9mIGl0cyBtZW1ibG9jayBmbGFncy4gVGhlIGxvc3Qgb2YgTUVNQkxPQ0tfTUlS Uk9SCj4gPiA+ID4gZmxhZyB3aWxsIGxlYWQgdG8gZXJyb3IgbG9nIHByaW50ZWQgYnkgZmluZF96 b25lX21vdmFibGVfcGZuc19mb3Jfbm9kZXMgaWYKPiA+ID4gPiB0aGUgbG93ZXIgNEcgcmFuZ2Ug aGFzIHNvbWUgbm9uLW1pcnJvcmVkIG1lbW9yeS4KPiA+ID4gPiAKPiA+ID4gPiBJbiBvcmRlciB0 byBzb2x2ZSB0aGlzIHByb2JsZW0sIHRoZSBsb3N0IE1FTUJMT0NLX01JUlJPUiBmbGFnIHdpbGwg YmUKPiA+ID4gPiByZWluc3RhbGxlZCBpZiB0aGUgb3JpZ2luIG1lbWJsb2NrIGhhcyB0aGlzIGZs YWcuCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWEgV3VwZW5nIDxtYXd1cGVuZzFA aHVhd2VpLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgIGFyY2gvYXJtNjQvbW0vaW5pdC5jICAg ICB8ICA5ICsrKysrKysrKwo+ID4gPiA+ICAgaW5jbHVkZS9saW51eC9tZW1ibG9jay5oIHwgIDEg Kwo+ID4gPiA+ICAgbW0vbWVtYmxvY2suYyAgICAgICAgICAgIHwgMjAgKysrKysrKysrKysrKysr KysrKysKPiA+ID4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L21tL2luaXQuYyBiL2FyY2gvYXJtNjQv bW0vaW5pdC5jCj4gPiA+ID4gaW5kZXggMzM5ZWU4NGU1YTYxLi4xMTY0MWY5MjRkMDggMTAwNjQ0 Cj4gPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9tbS9pbml0LmMKPiA+ID4gPiArKysgYi9hcmNoL2Fy bTY0L21tL2luaXQuYwo+ID4gPiA+IEBAIC0zNTAsOSArMzUwLDE4IEBAIHZvaWQgX19pbml0IGFy bTY0X21lbWJsb2NrX2luaXQodm9pZCkKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICJp bml0cmQgbm90IGZ1bGx5IGFjY2Vzc2libGUgdmlhIHRoZSBsaW5lYXIgbWFwcGluZyAtLSBwbGVh c2UgY2hlY2sgeW91ciBib290bG9hZGVyIC4uLlxuIikpIHsKPiA+ID4gPiAgICAgICAgICAgICAg ICAgICAgICAgIHBoeXNfaW5pdHJkX3NpemUgPSAwOwo+ID4gPiA+ICAgICAgICAgICAgICAgIH0g ZWxzZSB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGludCBmbGFncywgcmV0Owo+ID4g PiA+ICsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgcmV0ID0gbWVtYmxvY2tfZ2V0X2Zs YWdzKGJhc2UsICZmbGFncyk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIGlmIChyZXQp Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MgPSAwOwo+ID4gPiA+ ICsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgIG1lbWJsb2NrX3JlbW92ZShiYXNlLCBz aXplKTsgLyogY2xlYXIgTUVNQkxPQ0tfIGZsYWdzICovCj4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgICBtZW1ibG9ja19hZGQoYmFzZSwgc2l6ZSk7Cj4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgICBtZW1ibG9ja19yZXNlcnZlKGJhc2UsIHNpemUpOwo+ID4gPiAKPiA+ID4gQ2FuIHlv dSBleHBsYWluIHdoeSB3ZSdyZSByZW1vdmluZytyZS1hZGRpbmcgaGVyZSBleGFjdGx5PyBJcyBp dCBqdXN0IHRvCj4gPiA+IGNsZWFyIGZsYWdzIGFzIHRoZSBjb21tZW50IGluZGljYXRlcz8KPiA+ ID4gCj4gPiAKPiA+IFRoaXMgc2hvdWxkIG9ubHkgaGFwcGVuIGlmIHRoZSBwbGFjZW1lbnQgb2Yg dGhlIGluaXRyZCBjb25mbGljdHMgd2l0aAo+ID4gYSBtZW09IGNvbW1hbmQgbGluZSBwYXJhbWV0 ZXIgb3IgaXQgaXMgbm90IGNvdmVyZWQgYnkgbWVtYmxvY2sgZm9yCj4gPiBzb21lIG90aGVyIHJl YXNvbi4KPiA+IAo+ID4gSU9XLCB0aGlzIHNob3VsZCBuZXZlciBoYXBwZW4sIGFuZCBpZiByZS1t ZW1ibG9ja19hZGQnaW5nIHRoaXMgbWVtb3J5Cj4gPiB1bmNvbmRpdGlvbmFsbHkgaXMgY2F1c2lu ZyBwcm9ibGVtcywgd2Ugc2hvdWxkIGZpeCB0aGF0IGluc3RlYWQgb2YKPiA+IHdvcmtpbmcgYXJv dW5kIGl0Lgo+IAo+IFRoaXMgd2lsbCBoYXBwZW4gaWYgd2UgdXNlIGluaXRyZG1lbT0zRywxMDBN IHRvIHJlc2VydmUgaW5pdHJkIG1lbW9yeSBiZWxvdwo+IHRoZSA0RyBsaW1pdCB0byB0ZXN0IHRo aXMgc2NlbmFyaW8oanVzdCBmb3IgdGVzdGluZywgSSBoYXZlIHRyb3VibGUgdG8gYm9vdAo+IHFl bXUgd2l0aCBpbml0cmQgZW5hYmxlZCBhbmQgbWVtb3J5IGJlbG93IDRHIGFyZSBhbGwgbWlycm9y IG1lbW9yeSkuCj4gCj4gUmUtbWVtYmxvY2tfYWRkJ2luZyB0aGlzIG1lbW9yeSB1bmNvbmRpdGlv bmFsbHkgc2VlbXMgZmluZSBidXQgY2xlYXIgYWxsCj4gZmxhZ3MoZXNwZWNpYWxseSBNRU1CTE9D S19NSVJST1IpIG1heSBsZWFkIHRvIHNvbWUgZXJyb3IgbG9nLgo+IAo+ID4gCj4gPiA+IElmIGl0 J3MgcmVhbGx5IGp1c3QgYWJvdXQgY2xlYXJpbmcgZmxhZ3MsIEkgd29uZGVyIGlmIHdlIHJhdGhl ciB3YW50IHRvCj4gPiA+IGhhdmUgYW4gaW50ZXJmYWNlIHRoYXQgZG9lcyBleGFjdGx5IHRoYXQs IGFuZCBoaWRlcyB0aGUgd2F5IHRoaXMgaXMKPiA+ID4gYWN0dWFsbHkgaW1wbGVtZW50ZWQgKG9i dGFpbiBmbGFncywgcmVtb3ZlLCByZS1hZGQgLi4uKSwgaW50ZXJuYWxseS4KPiA+ID4gCj4gPiA+ IEJ1dCBtb3N0IHByb2JhYmx5IHRoZXJlIGlzIG1vcmUgbWFnaWMgaW4gdGhlIGNvZGUgYW5kIGNs ZWFyaW5nIGZsYWdzCj4gPiA+IGlzbid0IGFsbCBpdCBlbmRzIHVwIGRvaW5nLgo+ID4gPiAKPiA+ IAo+ID4gSSBkb24ndCByZW1lbWJlciBleGFjdGx5IHdoeSB3ZSBuZWVkZWQgdG8gY2xlYXIgdGhl IGZsYWdzLCBidXQgSSB0aGluawo+ID4gaXQgaGFkIHRvIGRvIHdpdGggc29tZSBjb3JuZXIgY2Fz ZSB3ZSBoaXQgd2hlbiB0aGUgaW5pdHJkIHdhcwo+ID4gcGFydGlhbGx5IGNvdmVyZWQuCj4gSWYg Im1lbT0iIGlzIHNldCBpbiBjb21tYW5kIGxpbmUsIG1lbWJsb2NrX21lbV9saW1pdF9yZW1vdmVf bWFwKCkgd2lsbAo+IHJlbW92ZSBhbGwgbWVtb3J5IGJsb2NrIHdpdGhvdXQgTUVNQkxPQ0tfTk9N QVAuIE1heWJlIHRoaXMgd2lsbCBicmluZyB0aGUKPiBtZW1vcnkgYmFjayBpZiB0aGlzIGluaXRy ZCBtZW0gaGFzIHRoZSBNRU1CTE9DS19OT01BUCBmbGFnPwo+IAo+IFRoZSByZmMgdmVyc2lvbiBb MV0gaW50cm9kdWNlIGFuZCB1c2UgbWVtYmxvY2tfY2xlYXJfbm9tYXAoKSB0byBjbGVhciB0aGUK PiBNRU1CTE9DS19OT01BUCBvZiB0aGlzIGluaXRyZCBtZW1ibG9jay4KPiBTbyBtYXliZSB0aGUg dXNhZ2Ugb2YgbWVtYmxvY2tfcmVtb3ZlKCkgaXMganVzdCB0byBhdm9pZCBpbnRyb2R1Y2luZyBu ZXcKPiBmdW5jdGlvbihtZW1ibG9ja19jbGVhcl9ub21hcCk/Cj4gCj4gU2luY2UgY29tbWl0IDRj NTQ2YjhhMzQ2OSAoIm1lbWJsb2NrOiBhZGQgbWVtYmxvY2tfY2xlYXJfbm9tYXAoKSIpIGFscmVh ZHkKPiBpbnRyb2R1Y2VkIG1lbWJsb2NrX2NsZWFyX25vbWFwKCkuIENhbiB3ZSB1c2UgdGhpcyB0 byByZW1vdmUgZmxhZyBNRU1CTE9DS19OT01BUAo+IHRvIHNvbHZlIHRoaXMgcHJvYmxlbSByYXRo ZXIgdGhhbiBicmluZyBmbGFnIE1FTUJMT0NLX01JUlJPUiBiYWNrPwoKQUZBSUNULCB0aGVyZSBh cmUgdHdvIGNvcm5lciBjYXNlcyB0aGF0IHJlLWFkZGluZyBpbml0cmQgbWVtb3J5IGNvdmVyczoK KiBpbml0cmQgbWVtb3J5IGlzIG5vdCBhIHBhcnQgb2YgdGhlIG1lbW9yeSByZXBvcnRlZCB0byBt ZW1ibG9jaywgZWl0aGVyCmJlY2F1c2Ugb2YgZmlybXdhcmUgd2VpcmRuZXNzIG9yIGJlY2F1c2Ug aXQgd2FzIGN1dCBvdXQgd2l0aCBtZW09CiogaW5pdHJkIG1lbW9yeSBvdmVybGFwcyBhIE5PTUFQ IHJlZ2lvbgoKU28gdG8gbWFrZSBzdXJlIGluaXRyZCBtZW1vcnkgaXMgbWFwcGVkIHByb3Blcmx5 IGFuZCByZXRhaW5zCk1FTUJMT0NLX01JUlJPUiBJIHRoaW5rIHRoZSBiZXN0IHdlIGNhbiBkbyBp cwoKCW1lbWJsb2NrX2FkZCgpOwoJbWVtYmxvY2tfY2xlYXJfbm9tYXAoKTsKCW1lbWJsb2NrX3Jl c2VydmUoKTsKCiAKPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5l bC8yMDE2MDIwMjE4MDYyMi5HUDEwMTY2QGFybS5jb20vVC8jdAo+ID4gLgoKLS0gClNpbmNlcmVs eSB5b3VycywKTWlrZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK