From: Andreas Herrmann <aherrmann@suse.de>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: tj@kernel.org, axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] blk-iocost: remove the second superfluous current_hweight
Date: Fri, 10 Jun 2022 10:45:58 +0200 [thread overview]
Message-ID: <YqMExo7u9N4sVnyM@suselix> (raw)
In-Reply-To: <20220609073450.98975-1-zhouchengming@bytedance.com>
On Thu, Jun 09, 2022 at 03:34:49PM +0800, Chengming Zhou wrote:
> The commit ac33e91e2dac ("blk-iocost: implement vtime loss compensation")
> add the second current_hweight() in the loop of active iocgs list to
> get old_hwi to calculate the vtime loss of the iocg.
>
> Since the hwi can't change and the first current_hweight already get
> hwa and hwi, so this second superfluous current_hweight() can be
> removed. There should be no functional changes.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
FWIW. Looks ok.
Reviewed-by: Andreas Herrmann <aherrmann@suse.de>
prev parent reply other threads:[~2022-06-10 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 7:34 [PATCH 1/2] blk-iocost: remove the second superfluous current_hweight Chengming Zhou
2022-06-09 7:34 ` [PATCH 2/2] blk-iocost: fix vtime loss calculation when iocg deactivate Chengming Zhou
2022-06-10 8:45 ` Andreas Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqMExo7u9N4sVnyM@suselix \
--to=aherrmann@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.